Skip to content

Commit 49ce903

Browse files
committed
Prevent async from messing with tests
1 parent 30891f7 commit 49ce903

File tree

1 file changed

+46
-18
lines changed

1 file changed

+46
-18
lines changed

test/test.user.js

Lines changed: 46 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,41 +11,69 @@ test("User API", function(t) {
1111
});
1212
var user = github.getUser();
1313

14-
user.orgs(function(err, res) {
15-
t.error(err, 'user orgs');
14+
t.test('user.orgs', function(q) {
15+
user.orgs(function(err, res) {
16+
q.error(err, 'user orgs');
17+
q.end();
18+
});
1619
});
1720

18-
user.gists(function(err, res) {
19-
t.error(err, 'user gists');
21+
t.test('user.gists', function(q) {
22+
user.gists(function(err, res) {
23+
q.error(err, 'user gists');
24+
q.end();
25+
});
2026
});
2127

22-
user.notifications(function(err, res) {
23-
t.error(err, 'user notifications');
28+
t.test('user.notifications', function(q) {
29+
user.notifications(function(err, res) {
30+
q.error(err, 'user notifications');
31+
q.end();
32+
});
2433
});
2534

26-
user.show('ingalls', function(err, res) {
27-
t.error(err, 'user show');
35+
t.test('user.show', function(q) {
36+
user.show('ingalls', function(err, res) {
37+
q.error(err, 'user show');
38+
q.end();
39+
});
2840
});
2941

30-
user.userRepos(test_user.USERNAME, function(err, res) {
31-
t.error(err, 'alt user repos');
42+
t.test('user.userRepos', function(q) {
43+
user.userRepos(test_user.USERNAME, function(err, res) {
44+
q.error(err, 'alt user repos');
45+
q.end();
46+
});
3247
});
3348

34-
user.userGists(test_user.USERNAME, function(err, res) {
35-
t.error(err, 'alt user gists');
49+
t.test('user.userGists', function(q) {
50+
user.userGists(test_user.USERNAME, function(err, res) {
51+
q.error(err, 'alt user gists');
52+
q.end();
53+
});
3654
});
3755

38-
user.orgRepos('openaddresses', function(err, res) {
39-
t.error(err, 'org users');
56+
t.test('user.orgRepos', function(q) {
57+
user.orgRepos('openaddresses', function(err, res) {
58+
q.error(err, 'org users');
59+
q.end();
60+
});
4061
});
4162

42-
user.follow('ingalls', function(err, res) {
43-
t.error(err, 'follow ingalls');
63+
t.test('user.follow', function(q) {
64+
user.follow('ingalls', function(err, res) {
65+
q.error(err, 'follow ingalls');
66+
q.end();
67+
});
4468
});
4569

46-
user.unfollow('ingalls', function(err, res) {
47-
t.error(err, 'unfollow ingalls');
70+
t.test('user.unfollow', function(q) {
71+
user.unfollow('ingalls', function(err, res) {
72+
q.error(err, 'unfollow ingalls');
73+
q.end();
74+
});
4875
});
76+
4977
clearTimeout(timeout);
5078
t.end();
5179

0 commit comments

Comments
 (0)