Improve commit method

Author: ingalls

github.js

@@ -414,21 +414,25 @@
       // -------
 
       this.commit = function(parent, tree, message, cb) {
-        var data = {
-          "message": message,
-          "author": {
-            "name": options.username
-          },
-          "parents": [
-            parent
-          ],
-          "tree": tree
-        };
-
-        _request("POST", repoPath + "/git/commits", data, function(err, res) {
-          currentTree.sha = res.sha; // update latest commit
+        var user = new Github.User();
+        user.show(null, function(err, userData){
           if (err) return cb(err);
-          cb(null, res.sha);
+          var data = {
+            "message": message,
+            "author": {
+              "name": options.user,
+              "email": userData.email
+            },
+            "parents": [
+              parent
+            ],
+            "tree": tree
+          };
+          _request("POST", repoPath + "/git/commits", data, function(err, res) {
+            if (err) return cb(err);
+            currentTree.sha = res.sha; // update latest commit
+            cb(null, res.sha);
+          });
         });
       };
 

test/commit_test.js

@@ -0,0 +1,30 @@
+if (typeof require !== 'undefined') {
+    var Github = require("../")
+      , chai = require("chai");
+}
+chai.should();
+var expect = chai.expect
+  , TEST_USERNAME = "mikedeboertest"
+  , TEST_PASSWORD = "test1324"
+  , TEST_REPO = "github";
+
+var github = new Github({
+  username: TEST_USERNAME,
+  password: TEST_PASSWORD,
+  auth: "basic"
+});
+
+describe("Repo", function(){
+
+  it("should return commit errors correctly", function(done){
+    var repo = github.getRepo(TEST_USERNAME, TEST_REPO);
+    repo.commit("broken-parent-hash", "broken-tree-hash", "commit message", function(err){
+      if (err != null && err.request != null && err.request.status == 500) {
+        done();
+      } else {
+        done(new Error("No `err` passed to .commit callback"));
+      }
+    });
+  });
+
+});

test/test.repo.js

@@ -46,3 +46,23 @@ test("Repo API", function(t) {
     t.end();
 
 });
+
+test('Repo Returns commit errors correctly', function(t){
+    var timeout = setTimeout(function () { t.fail(); }, 10000);
+    var github = new Github({
+      username: test_user.USERNAME,
+      password: test_user.PASSWORD,
+      auth: "basic"
+    });
+    var repo = github.getRepo(test_user.USERNAME, test_user.REPO);
+
+    repo.commit("broken-parent-hash", "broken-tree-hash", "commit message", function(err){
+        t.ok(err, 'error thrown for bad commit');
+        t.ok(err.request);
+        t.equals(err.request.status, 422, 'Returns 422 status');
+        clearTimeout(timeout);
+        t.end();
+    });
+
+
+});

test/user.json

@@ -1,4 +1,5 @@
 {
     "USERNAME": "mikedeboertest",
-    "PASSWORD": "test1324"
+    "PASSWORD": "test1324",
+    "REPO": "github"
 }