From 380d7b74934ace8a4e95230e5f77fb70fa8981ca Mon Sep 17 00:00:00 2001 From: Neel Shah Date: Wed, 18 Mar 2026 16:08:36 +0100 Subject: [PATCH] test: fix flaky threading test --- .claude/settings.json | 1 + tests/test_utils.py | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.claude/settings.json b/.claude/settings.json index c60bf4afb1..416bb2617f 100644 --- a/.claude/settings.json +++ b/.claude/settings.json @@ -29,6 +29,7 @@ "Bash(grep:*)", "Bash(mv:*)", "Bash(source .venv/bin/activate)", + "Bash(source tox.venv/bin/activate:*)", "Bash(tox:*)", "Bash(tox.venv/bin/tox:*)", "Bash(.tox/*/bin/python:*)", diff --git a/tests/test_utils.py b/tests/test_utils.py index 1fc651f805..1fc1cbaa8f 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -942,14 +942,12 @@ def target(): assert (main_thread.ident, main_thread.name) == results.get(timeout=1) -@pytest.mark.skipif(PY38, reason="Flakes a lot on 3.8 in CI.") def test_get_current_thread_meta_failed_to_get_main_thread(): results = Queue(maxsize=1) def target(): - with mock.patch("threading.current_thread", side_effect=["fake thread"]): - with mock.patch("threading.current_thread", side_effect=["fake thread"]): - results.put(get_current_thread_meta()) + with mock.patch("threading.current_thread", return_value="fake thread"): + results.put(get_current_thread_meta()) main_thread = threading.main_thread()