fix(integrations): addressing review comments

Author: constantinius

sentry_sdk/integrations/openai_agents/utils.py

@@ -56,15 +56,15 @@ def _transform_openai_agents_content_part(
     if part_type in ("image_url", "input_image"):
         # Get URL from either format
         if part_type == "image_url":
-            image_url = content_part.get("image_url", {})
+            image_url = content_part.get("image_url") or {}
             url = (
                 image_url.get("url", "")
                 if isinstance(image_url, dict)
                 else str(image_url)
             )
         else:
             # input_image format has image_url directly
-            url = content_part.get("image_url", "")
+            url = content_part.get("image_url") or ""
 
         if url.startswith("data:"):
             try:
@@ -93,35 +93,44 @@ def _transform_openai_agents_content_part(
 
     # Handle input_audio (OpenAI audio input format)
     if part_type == "input_audio":
-        input_audio = content_part.get("input_audio", {})
-        audio_format = input_audio.get("format", "")
-        mime_type = f"audio/{audio_format}" if audio_format else ""
-        return {
-            "type": "blob",
-            "modality": "audio",
-            "mime_type": mime_type,
-            "content": input_audio.get("data", ""),
-        }
+        input_audio = content_part.get("input_audio") or {}
+        if isinstance(input_audio, dict):
+            audio_format = input_audio.get("format", "")
+            mime_type = f"audio/{audio_format}" if audio_format else ""
+            return {
+                "type": "blob",
+                "modality": "audio",
+                "mime_type": mime_type,
+                "content": input_audio.get("data", ""),
+            }
+        else:
+            return content_part
 
     # Handle image_file (Assistants API file-based images)
     if part_type == "image_file":
-        image_file = content_part.get("image_file", {})
-        return {
-            "type": "file",
-            "modality": "image",
-            "mime_type": "",
-            "file_id": image_file.get("file_id", ""),
-        }
+        image_file = content_part.get("image_file") or {}
+        if isinstance(image_file, dict):
+            return {
+                "type": "file",
+                "modality": "image",
+                "mime_type": "",
+                "file_id": image_file.get("file_id", ""),
+            }
+        else:
+            return content_part
 
     # Handle file (document attachments)
     if part_type == "file":
-        file_data = content_part.get("file", {})
-        return {
-            "type": "file",
-            "modality": "document",
-            "mime_type": "",
-            "file_id": file_data.get("file_id", ""),
-        }
+        file_data = content_part.get("file") or {}
+        if isinstance(file_data, dict):
+            return {
+                "type": "file",
+                "modality": "document",
+                "mime_type": "",
+                "file_id": file_data.get("file_id", ""),
+            }
+        else:
+            return content_part
 
     return content_part
 

tests/integrations/openai_agents/test_openai_agents.py

@@ -2005,6 +2005,78 @@ def test_openai_agents_message_truncation(sentry_init, capture_events):
         assert "small message 5" in str(parsed_messages[1])
 
 
+def test_transform_does_not_modify_original():
+    """Test that transformation does not modify the original content."""
+    import copy
+
+    content_part = {
+        "type": "image_url",
+        "image_url": {
+            "url": "data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD",
+            "detail": "high",
+        },
+    }
+    original = copy.deepcopy(content_part)
+    _transform_openai_agents_content_part(content_part)
+    assert content_part == original, "Original content_part should not be modified"
+
+    content = [
+        {"type": "text", "text": "What is in this image?"},
+        {
+            "type": "image_url",
+            "image_url": {
+                "url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUg==",
+            },
+        },
+    ]
+    original_content = copy.deepcopy(content)
+    _transform_openai_agents_message_content(content)
+    assert content == original_content, "Original content list should not be modified"
+
+
+def test_transform_handles_none_values():
+    """Test that transformation handles None values gracefully without crashing."""
+    # input_image with image_url explicitly set to None - should not crash
+    content_part = {"type": "input_image", "image_url": None}
+    result = _transform_openai_agents_content_part(content_part)
+    assert result == {"type": "uri", "modality": "image", "mime_type": "", "uri": ""}
+
+    # image_url with nested dict set to None - should not crash
+    content_part = {"type": "image_url", "image_url": None}
+    result = _transform_openai_agents_content_part(content_part)
+    assert result == {"type": "uri", "modality": "image", "mime_type": "", "uri": ""}
+
+    # input_audio with None value - gracefully returns empty blob
+    content_part = {"type": "input_audio", "input_audio": None}
+    result = _transform_openai_agents_content_part(content_part)
+    assert result == {
+        "type": "blob",
+        "modality": "audio",
+        "mime_type": "",
+        "content": "",
+    }
+
+    # image_file with None value - gracefully returns empty file reference
+    content_part = {"type": "image_file", "image_file": None}
+    result = _transform_openai_agents_content_part(content_part)
+    assert result == {
+        "type": "file",
+        "modality": "image",
+        "mime_type": "",
+        "file_id": "",
+    }
+
+    # file with None value - gracefully returns empty file reference
+    content_part = {"type": "file", "file": None}
+    result = _transform_openai_agents_content_part(content_part)
+    assert result == {
+        "type": "file",
+        "modality": "document",
+        "mime_type": "",
+        "file_id": "",
+    }
+
+
 def test_transform_image_url_to_blob():
     """Test that OpenAI image_url with data URI is converted to blob format."""
     content_part = {