ref(wsgi): Simplify file response bypass to not require uWSGI offload-threads check

Remove the _is_uwsgi_offload_threads_enabled() helper and the
associated uWSGI import. The broader condition — skip wrapping
whenever wsgi.file_wrapper is present and the response is file-like
(has fileno) — is sufficient and correct since uWSGI applies
file-handling optimizations beyond just offload-threads.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: ericapisani

sentry_sdk/integrations/wsgi.py

@@ -145,41 +145,22 @@ def __call__(
         # To avoid this and ensure that the offloading mechanism works as expected when it's
         # enabled, we check if the response is a file-like object (determined by the presence
         # of `fileno`), if the wsgi.file_wrapper is available in the environment (as if so,
-        # it would've been used in handling the file in the response), and if uWSGI's
-        # offload-threads option is configured (since offloading only occurs when offload
-        # threads are enabled).
+        # it would've been used in handling the file in the response).
+        #
+        # Even if the offload mechanism is not enabled, there are optimizations that uWSGI does for file-like objects,
+        # so we want to make sure we don't interfere with those either.
         #
         # If all conditions are met, we return the original response object directly,
         # allowing uWSGI to handle it as intended.
         if (
-            _is_uwsgi_offload_threads_enabled()
-            and environ.get("wsgi.file_wrapper")
+            environ.get("wsgi.file_wrapper")
             and getattr(response, "fileno", None) is not None
         ):
             return response
 
         return _ScopedResponse(scope, response)
 
 
-def _is_uwsgi_offload_threads_enabled() -> bool:
-    try:
-        from uwsgi import opt  # type: ignore
-    except ImportError:
-        return False
-
-    value = opt.get("offload-threads") or opt.get(b"offload-threads")
-    if not value:
-        return False
-    if isinstance(value, bytes):
-        try:
-            return int(value.decode()) > 0
-        except (ValueError, UnicodeDecodeError):
-            return False
-    if isinstance(value, int):
-        return value > 0
-    return False
-
-
 def _sentry_start_response(
     old_start_response: "StartResponse",
     transaction: "Optional[Transaction]",

tests/integrations/wsgi/test_wsgi.py

@@ -503,24 +503,16 @@ def dogpark(environ, start_response):
 
 
 @pytest.mark.parametrize(
-    "uwsgi_opt, has_file_wrapper, has_fileno, expect_wrapped",
+    "has_file_wrapper, has_fileno, expect_wrapped",
     [
-        ({"offload-threads": 1}, True, True, False),  # all conditions met → unwrapped
-        ({"offload-threads": 0}, True, True, True),  # offload disabled → wrapped
-        ({"offload-threads": 1}, False, True, True),  # no file_wrapper → wrapped
-        ({"offload-threads": 1}, True, False, True),  # no fileno → wrapped
-        (None, True, True, True),  # uwsgi not installed → wrapped
-        ({"offload-threads": b"1"}, True, True, False),  # bytes value → unwrapped
-        (
-            {b"offload-threads": b"1"},
-            True,
-            True,
-            False,
-        ),  # bytes key + bytes value → unwrapped
+        (True, True, False),  # both conditions met → unwrapped
+        (False, True, True),  # no file_wrapper → wrapped
+        (True, False, True),  # no fileno → wrapped
+        (False, False, True),  # neither condition → wrapped
     ],
 )
-def test_uwsgi_offload_threads_response_wrapping(
-    sentry_init, uwsgi_opt, has_file_wrapper, has_fileno, expect_wrapped
+def test_file_response_wrapping(
+    sentry_init, has_file_wrapper, has_fileno, expect_wrapped
 ):
     sentry_init()
 
@@ -538,26 +530,18 @@ def app(environ, start_response):
 
     middleware = SentryWsgiMiddleware(app)
 
-    if uwsgi_opt is not None:
-        uwsgi_mock = mock.MagicMock()
-        uwsgi_mock.opt = uwsgi_opt
-        patch_ctx = mock.patch.dict("sys.modules", uwsgi=uwsgi_mock)
-    else:
-        patch_ctx = mock.patch.dict("sys.modules", {"uwsgi": None})
-
-    with patch_ctx:
-        result = middleware(
-            {
-                "REQUEST_METHOD": "GET",
-                "PATH_INFO": "/",
-                "SERVER_NAME": "localhost",
-                "SERVER_PORT": "80",
-                "wsgi.url_scheme": "http",
-                "wsgi.input": mock.MagicMock(),
-                **environ_extra,
-            },
-            lambda status, headers: None,
-        )
+    result = middleware(
+        {
+            "REQUEST_METHOD": "GET",
+            "PATH_INFO": "/",
+            "SERVER_NAME": "localhost",
+            "SERVER_PORT": "80",
+            "wsgi.url_scheme": "http",
+            "wsgi.input": mock.MagicMock(),
+            **environ_extra,
+        },
+        lambda status, headers: None,
+    )
 
     if expect_wrapped:
         assert isinstance(result, _ScopedResponse)