Skip to content

Commit 18ad281

Browse files
committed
finish -> end
1 parent 5f33d30 commit 18ad281

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

sentry_sdk/integrations/strawberry.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,10 @@ def on_operation(self) -> "Generator[None, None, None]":
231231
if self.graphql_span.containing_transaction:
232232
self.graphql_span.containing_transaction.op = op
233233

234-
self.graphql_span.finish()
234+
if isinstance(self.graphql_span, StreamedSpan):
235+
self.graphql_span.end()
236+
else:
237+
self.graphql_span.finish()
235238

236239
def on_validate(self) -> "Generator[None, None, None]":
237240
self.validation_span: "Union[StreamedSpan, Span]"
@@ -253,7 +256,10 @@ def on_validate(self) -> "Generator[None, None, None]":
253256

254257
yield
255258

256-
self.validation_span.finish()
259+
if isinstance(self.validation_span, StreamedSpan):
260+
self.validation_span.end()
261+
else:
262+
self.validation_span.finish()
257263

258264
def on_parse(self) -> "Generator[None, None, None]":
259265
self.parsing_span: "Union[StreamedSpan, Span]"
@@ -273,7 +279,10 @@ def on_parse(self) -> "Generator[None, None, None]":
273279

274280
yield
275281

276-
self.parsing_span.finish()
282+
if isinstance(self.parsing_span, StreamedSpan):
283+
self.parsing_span.end()
284+
else:
285+
self.parsing_span.finish()
277286

278287
def should_skip_tracing(
279288
self,

0 commit comments

Comments
 (0)