updated tests

Author: antonpirker

sentry_sdk/integrations/dedupe.py

@@ -26,8 +26,8 @@ class DedupeIntegration(Integration):
     def __init__(self):
         # type: () -> None
         self._last_seen = ContextVar("last-seen", default=None)
-        self.in_app_include = []  # type: List[str]
-        self.in_app_exclude = []  # type: List[str]
+        self.in_app_include = None  # type: Optional[List[str]]
+        self.in_app_exclude = None  # type: Optional[List[str]]
         self.project_root = None  # type: Optional[str]
 
     def _is_frame_in_app(self, namespace, abs_path):
@@ -87,23 +87,23 @@ def _create_exception_fingerprint(self, exc_info):
     @staticmethod
     def setup_once():
         # type: () -> None
-        client = sentry_sdk.get_client()
-        integration = client.get_integration(DedupeIntegration)
-        if integration is not None:
-            integration.in_app_include = client.options.get("in_app_include") or []
-            integration.in_app_exclude = client.options.get("in_app_exclude") or []
-            integration.project_root = client.options.get("project_root") or None
-
         @add_global_event_processor
         def processor(event, hint):
             # type: (Event, Optional[Hint]) -> Optional[Event]
             if hint is None:
                 return event
 
-            integration = sentry_sdk.get_client().get_integration(DedupeIntegration)
+            client = sentry_sdk.get_client()
+            integration = client.get_integration(DedupeIntegration)
+
             if integration is None:
                 return event
 
+            if integration.in_app_include is None:
+                integration.in_app_include = client.options.get("in_app_include") or []
+                integration.in_app_exclude = client.options.get("in_app_exclude") or []
+                integration.project_root = client.options.get("project_root") or None
+
             exc_info = hint.get("exc_info", None)
             if exc_info is None:
                 return event

tests/test_basics.py

@@ -220,7 +220,9 @@ def before_breadcrumb(crumb, hint):
             crumb["data"] = {"foo": "bar"}
             return crumb
 
-    sentry_init(before_send=before_send, before_breadcrumb=before_breadcrumb)
+    sentry_init(
+        before_send=before_send, before_breadcrumb=before_breadcrumb
+    )  # , disabled_integrations=[DedupeIntegration])
     events = capture_events()
 
     monkeypatch.setattr(
@@ -230,7 +232,7 @@ def before_breadcrumb(crumb, hint):
     def do_this():
         add_breadcrumb(message="Hello", hint={"foo": 42})
         try:
-            raise ValueError("aha!")
+            raise ValueError(f"aha! {time.time()}")
         except Exception:
             capture_exception()
 
@@ -368,15 +370,19 @@ def _(scope):
 
 
 def test_breadcrumbs(sentry_init, capture_events):
-    sentry_init(max_breadcrumbs=10)
+    sentry_init(max_breadcrumbs=10, in_app_include=["tests"])
     events = capture_events()
 
     for i in range(20):
         add_breadcrumb(
             category="auth", message="Authenticated user %s" % i, level="info"
         )
 
-    capture_exception(ValueError())
+    try:
+        raise ValueError()
+    except Exception:
+        capture_exception()
+
     (event,) = events
 
     assert len(event["breadcrumbs"]["values"]) == 10
@@ -392,7 +398,11 @@ def test_breadcrumbs(sentry_init, capture_events):
 
     sentry_sdk.get_isolation_scope().clear()
 
-    capture_exception(ValueError())
+    try:
+        raise ValueError()
+    except Exception:
+        capture_exception()
+
     (event,) = events
     assert len(event["breadcrumbs"]["values"]) == 0