fix(core): backfill OpenAI responses model in spans

Author: meronogbai

packages/core/src/tracing/openai/utils.ts

@@ -1,4 +1,5 @@
 import type { Span } from '../../types-hoist/span';
+import { updateSpanName } from '../../utils/spanUtils';
 import {
   GEN_AI_CONVERSATION_ID_ATTRIBUTE,
   GEN_AI_REQUEST_DIMENSIONS_ATTRIBUTE,
@@ -201,6 +202,12 @@ export function addChatCompletionAttributes(
  */
 export function addResponsesApiAttributes(span: Span, response: OpenAIResponseObject, recordOutputs?: boolean): void {
   setCommonResponseAttributes(span, response.id, response.model, response.created_at);
+  if (typeof response.model === 'string' && response.model.length > 0) {
+    span.setAttributes({
+      [GEN_AI_REQUEST_MODEL_ATTRIBUTE]: response.model,
+    });
+    updateSpanName(span, `${OPENAI_OPERATIONS.CHAT} ${response.model}`);
+  }
   if (response.status) {
     span.setAttributes({
       [GEN_AI_RESPONSE_FINISH_REASONS_ATTRIBUTE]: JSON.stringify([response.status]),

packages/core/test/lib/utils/openai-utils.test.ts

@@ -1,6 +1,8 @@
-import { describe, expect, it } from 'vitest';
+import { describe, expect, it, vi } from 'vitest';
 import {
+  addResponsesApiAttributes,
   buildMethodPath,
+  extractRequestParameters,
   getOperationName,
   getSpanOperation,
   isChatCompletionChunk,
@@ -10,6 +12,7 @@ import {
   isResponsesApiStreamEvent,
   shouldInstrument,
 } from '../../../src/tracing/openai/utils';
+import type { OpenAIResponseObject } from '../../../src/tracing/openai/types';
 
 describe('openai-utils', () => {
   describe('getOperationName', () => {
@@ -67,6 +70,31 @@ describe('openai-utils', () => {
     });
   });
 
+  describe('extractRequestParameters', () => {
+    it('should include the request model when it is explicitly provided', () => {
+      expect(
+        extractRequestParameters({
+          model: 'gpt-4.1-mini',
+          temperature: 0.2,
+        }),
+      ).toEqual({
+        'gen_ai.request.model': 'gpt-4.1-mini',
+        'gen_ai.request.temperature': 0.2,
+      });
+    });
+
+    it('should default the request model to unknown when it is not provided', () => {
+      expect(
+        extractRequestParameters({
+          temperature: 0.2,
+        }),
+      ).toEqual({
+        'gen_ai.request.model': 'unknown',
+        'gen_ai.request.temperature': 0.2,
+      });
+    });
+  });
+
   describe('isChatCompletionResponse', () => {
     it('should return true for valid chat completion responses', () => {
       const validResponse = {
@@ -185,4 +213,30 @@ describe('openai-utils', () => {
       expect(isConversationResponse({ object: null })).toBe(false);
     });
   });
+
+  describe('addResponsesApiAttributes', () => {
+    it('should backfill the request model and span name from the response model', () => {
+      const span = {
+        setAttributes: vi.fn(),
+        updateName: vi.fn(),
+      };
+
+      addResponsesApiAttributes(
+        span as unknown as Parameters<typeof addResponsesApiAttributes>[0],
+        {
+          object: 'response',
+          id: 'resp_123',
+          model: 'gpt-4.1-mini',
+          created_at: 1704067200,
+          status: 'completed',
+        } as unknown as OpenAIResponseObject,
+        false,
+      );
+
+      expect(span.setAttributes).toHaveBeenCalledWith({
+        'gen_ai.request.model': 'gpt-4.1-mini',
+      });
+      expect(span.updateName).toHaveBeenCalledWith('chat gpt-4.1-mini');
+    });
+  });
 });