From e71d692573f8e6dbb477d8affe90269ca2a89a3a Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Tue, 29 Jul 2025 13:15:26 +0200 Subject: [PATCH 1/4] Do not use Sentry logging API if logs are disabled --- .../src/main/java/io/sentry/log4j2/SentryAppender.java | 3 ++- .../sentry-samples-log4j2/src/main/resources/sentry.properties | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java b/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java index a32af15e2ea..f273d2e8e1b 100644 --- a/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java +++ b/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java @@ -191,7 +191,8 @@ public void start() { @Override public void append(final @NotNull LogEvent eventObject) { - if (eventObject.getLevel().isMoreSpecificThan(minimumLevel)) { + if (scopes.getOptions().getLogs().isEnabled() + && eventObject.getLevel().isMoreSpecificThan(minimumLevel)) { captureLog(eventObject); } if (eventObject.getLevel().isMoreSpecificThan(minimumEventLevel)) { diff --git a/sentry-samples/sentry-samples-log4j2/src/main/resources/sentry.properties b/sentry-samples/sentry-samples-log4j2/src/main/resources/sentry.properties index 47c00f6405f..b2310e08f89 100644 --- a/sentry-samples/sentry-samples-log4j2/src/main/resources/sentry.properties +++ b/sentry-samples/sentry-samples-log4j2/src/main/resources/sentry.properties @@ -1,2 +1,3 @@ in-app-includes="io.sentry.samples" logs.enabled=true +debug=true From dff3aa99e0cf480c5b52ed310f62fff8fcbc8db8 Mon Sep 17 00:00:00 2001 From: Sentry Github Bot Date: Tue, 29 Jul 2025 11:17:34 +0000 Subject: [PATCH 2/4] Format code --- .../src/main/java/io/sentry/log4j2/SentryAppender.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java b/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java index f273d2e8e1b..dddc6f3b902 100644 --- a/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java +++ b/sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java @@ -192,7 +192,7 @@ public void start() { @Override public void append(final @NotNull LogEvent eventObject) { if (scopes.getOptions().getLogs().isEnabled() - && eventObject.getLevel().isMoreSpecificThan(minimumLevel)) { + && eventObject.getLevel().isMoreSpecificThan(minimumLevel)) { captureLog(eventObject); } if (eventObject.getLevel().isMoreSpecificThan(minimumEventLevel)) { From c93b2d1eaa989831b72adfa3a72dc7f845946303 Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Tue, 29 Jul 2025 13:26:10 +0200 Subject: [PATCH 3/4] changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 97a3d669871..af9d34ca35f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,8 @@ - Allow multiple UncaughtExceptionHandlerIntegrations to be active at the same time ([#4462](https://github.com/getsentry/sentry-java/pull/4462)) - Prevent repeated scroll target determination during a single scroll gesture ([#4557](https://github.com/getsentry/sentry-java/pull/4557)) - This should reduce the number of ANRs seen in `SentryGestureListener` +- Do not use Sentry logging API if logs are disabled ([#4573](https://github.com/getsentry/sentry-java/pull/4573)) + - This was causing Sentry SDK to log warnings: "Sentry Log is disabled and this 'logger' call is a no-op." ## 8.17.0 From c9187e9423f5b4a72f7c5d9c550e24c5f741522c Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Tue, 29 Jul 2025 13:26:42 +0200 Subject: [PATCH 4/4] mention log4j2 in changelog entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index af9d34ca35f..bb38633c0d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,7 +26,7 @@ - Allow multiple UncaughtExceptionHandlerIntegrations to be active at the same time ([#4462](https://github.com/getsentry/sentry-java/pull/4462)) - Prevent repeated scroll target determination during a single scroll gesture ([#4557](https://github.com/getsentry/sentry-java/pull/4557)) - This should reduce the number of ANRs seen in `SentryGestureListener` -- Do not use Sentry logging API if logs are disabled ([#4573](https://github.com/getsentry/sentry-java/pull/4573)) +- Do not use Sentry logging API in Log4j2 if logs are disabled ([#4573](https://github.com/getsentry/sentry-java/pull/4573)) - This was causing Sentry SDK to log warnings: "Sentry Log is disabled and this 'logger' call is a no-op." ## 8.17.0