From 35b25a4edc3037e2c46ea53823244db4ecb666ba Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Mon, 31 Mar 2025 12:28:01 +0200 Subject: [PATCH 1/3] Remove not yet implemented from flush comments --- sentry/src/main/java/io/sentry/IScopes.java | 2 +- sentry/src/main/java/io/sentry/ISentryClient.java | 2 +- sentry/src/main/java/io/sentry/Sentry.java | 2 +- sentry/src/main/java/io/sentry/transport/ITransport.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sentry/src/main/java/io/sentry/IScopes.java b/sentry/src/main/java/io/sentry/IScopes.java index 42b434ca2db..40884f63947 100644 --- a/sentry/src/main/java/io/sentry/IScopes.java +++ b/sentry/src/main/java/io/sentry/IScopes.java @@ -376,7 +376,7 @@ default void configureScope(@NotNull ScopeCallback callback) { boolean isHealthy(); /** - * Flushes events queued up, but keeps the scopes enabled. Not implemented yet. + * Flushes events queued up, but keeps the scopes enabled. * * @param timeoutMillis time in milliseconds */ diff --git a/sentry/src/main/java/io/sentry/ISentryClient.java b/sentry/src/main/java/io/sentry/ISentryClient.java index 22389f2b6e5..198f77f2f0d 100644 --- a/sentry/src/main/java/io/sentry/ISentryClient.java +++ b/sentry/src/main/java/io/sentry/ISentryClient.java @@ -40,7 +40,7 @@ public interface ISentryClient { void close(boolean isRestarting); /** - * Flushes events queued up, but keeps the client enabled. Not implemented yet. + * Flushes events queued up, but keeps the client enabled. * * @param timeoutMillis time in milliseconds */ diff --git a/sentry/src/main/java/io/sentry/Sentry.java b/sentry/src/main/java/io/sentry/Sentry.java index dc9de2a203d..70d4c7b380e 100644 --- a/sentry/src/main/java/io/sentry/Sentry.java +++ b/sentry/src/main/java/io/sentry/Sentry.java @@ -1030,7 +1030,7 @@ public static boolean isHealthy() { } /** - * Flushes events queued up to the current Scopes. Not implemented yet. + * Flushes events queued up to the current Scopes. * * @param timeoutMillis time in milliseconds */ diff --git a/sentry/src/main/java/io/sentry/transport/ITransport.java b/sentry/src/main/java/io/sentry/transport/ITransport.java index ccc3db4a0cb..ec9ae43f998 100644 --- a/sentry/src/main/java/io/sentry/transport/ITransport.java +++ b/sentry/src/main/java/io/sentry/transport/ITransport.java @@ -20,7 +20,7 @@ default boolean isHealthy() { } /** - * Flushes events queued up, but keeps the client enabled. Not implemented yet. + * Flushes events queued up, but keeps the client enabled. * * @param timeoutMillis time in milliseconds */ From 53b24e08ac8ecd25c980411b8af78bde538e1a72 Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Mon, 31 Mar 2025 12:31:16 +0200 Subject: [PATCH 2/3] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b027fd7834b..9a2e881fbb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -100,6 +100,7 @@ - In certain cases the SDK was not able to provide a transaction name automatically and thus did not finish the transaction for the request. - We now first try `SpringMvcTransactionNameProvider` which would provide the route as transaction name. - If that does not return anything, we try `SpringServletTransactionNameProvider` next, which returns the URL of the request. +- Remove "not yet implemented" from `Sentry.flush` comment ([#4305](https://github.com/getsentry/sentry-java/pull/4305)) ### Behavioral Changes From f07ee5cde8538025d66504029818b86ad849db55 Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Tue, 1 Apr 2025 06:20:44 +0200 Subject: [PATCH 3/3] move changelog entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a2e881fbb0..c3c79ad7d7c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ - The value of the `Sentry-Version-Name` attribute looks like `sentry-8.5.0-otel-2.10.0` - Fix tags missing for compose view hierarchies ([#4275](https://github.com/getsentry/sentry-java/pull/4275)) - Do not leak SentryFileInputStream/SentryFileOutputStream descriptors and channels ([#4296](https://github.com/getsentry/sentry-java/pull/4296)) +- Remove "not yet implemented" from `Sentry.flush` comment ([#4305](https://github.com/getsentry/sentry-java/pull/4305)) ### Internal @@ -100,7 +101,6 @@ - In certain cases the SDK was not able to provide a transaction name automatically and thus did not finish the transaction for the request. - We now first try `SpringMvcTransactionNameProvider` which would provide the route as transaction name. - If that does not return anything, we try `SpringServletTransactionNameProvider` next, which returns the URL of the request. -- Remove "not yet implemented" from `Sentry.flush` comment ([#4305](https://github.com/getsentry/sentry-java/pull/4305)) ### Behavioral Changes