fix(okhttp): Finalize OkHttpEvent even if no active span (#4469)

* fix(okhttp): Finalize OkHttpEvent even if no active span

* Changelog

* Update sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

Author: romtsn

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Send UI Profiling app start chunk when it finishes ([#4423](https://github.com/getsentry/sentry-java/pull/4423))
 - Republish Javadoc [#4457](https://github.com/getsentry/sentry-java/pull/4457)
+- Finalize `OkHttpEvent` even if no active span in `SentryOkHttpInterceptor` [#4469](https://github.com/getsentry/sentry-java/pull/4469)
 
 ## 8.13.2
 

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpEvent.kt

@@ -27,7 +27,7 @@ internal class SentryOkHttpEvent(private val scopes: IScopes, private val reques
     internal val callSpan: ISpan?
     private var response: Response? = null
     private var clientErrorResponse: Response? = null
-    private val isEventFinished = AtomicBoolean(false)
+    internal val isEventFinished = AtomicBoolean(false)
     private var url: String
     private var method: String
 

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

@@ -192,6 +192,8 @@ public open class SentryOkHttpInterceptor(
 
     private fun finishSpan(span: ISpan?, request: Request, response: Response?, isFromEventListener: Boolean, okHttpEvent: SentryOkHttpEvent?) {
         if (span == null) {
+            // tracing can be disabled, or there can be no active span, but we still want to finalize the OkHttpEvent when both SentryOkHttpInterceptor and SentryOkHttpEventListener are used
+            okHttpEvent?.finish()
             return
         }
         if (beforeSpan != null) {

sentry-okhttp/src/test/java/io/sentry/okhttp/SentryOkHttpInterceptorTest.kt

@@ -650,4 +650,15 @@ class SentryOkHttpInterceptorTest {
         val okHttpEvent = SentryOkHttpEventListener.eventMap[call]!!
         assertEquals(fixture.server.url("/hello/v1").toUrl().toString(), okHttpEvent.callSpan!!.getData("url"))
     }
+
+    @Test
+    fun `when no active http span still finalizes okHttpEvent`() {
+        val client = fixture.getSut(isSpanActive = false, eventListener = SentryOkHttpEventListener(fixture.scopes))
+        val request = getRequest("/hello/")
+        val call = client.newCall(request)
+        call.execute()
+
+        val okHttpEvent = SentryOkHttpEventListener.eventMap[call]!!
+        assertTrue(okHttpEvent.isEventFinished.get())
+    }
 }