Skip to content

Commit 1737697

Browse files
authored
Merge pull request #5025 from getsentry/01-13-create_metricsunit_constants
feat(metrics): [Trace Metrics 30] Create MetricsUnit constants
2 parents f2dca3b + 735f8f1 commit 1737697

File tree

20 files changed

+260
-85
lines changed

20 files changed

+260
-85
lines changed

sentry-samples/sentry-samples-spring-7/src/main/java/io/sentry/samples/spring7/web/MetricController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring7.web;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -21,13 +22,14 @@ String count() {
2122

2223
@GetMapping("gauge/{value}")
2324
String gauge(@PathVariable("value") Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
2930
String distribution(@PathVariable("value") Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-4-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot4/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot4;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-4-opentelemetry/src/main/java/io/sentry/samples/spring/boot4/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot4;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-4-webflux/src/main/java/io/sentry/samples/spring/boot4/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot4;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-4/src/main/java/io/sentry/samples/spring/boot4/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot4;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-jakarta-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot.jakarta;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-jakarta-opentelemetry/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot.jakarta;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot.jakarta;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

sentry-samples/sentry-samples-spring-boot-opentelemetry/src/main/java/io/sentry/samples/spring/boot/MetricController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sentry.samples.spring.boot;
22

33
import io.sentry.Sentry;
4+
import io.sentry.metrics.MetricsUnit;
45
import org.slf4j.Logger;
56
import org.slf4j.LoggerFactory;
67
import org.springframework.web.bind.annotation.GetMapping;
@@ -20,14 +21,15 @@ String count() {
2021
}
2122

2223
@GetMapping("gauge/{value}")
23-
String gauge(@PathVariable Long value) {
24-
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
24+
String gauge(@PathVariable("value") Long value) {
25+
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
2526
return "gauge metric tracked";
2627
}
2728

2829
@GetMapping("distribution/{value}")
29-
String distribution(@PathVariable Long value) {
30-
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
30+
String distribution(@PathVariable("value") Long value) {
31+
Sentry.metrics()
32+
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
3133
return "distribution metric tracked";
3234
}
3335
}

0 commit comments

Comments
 (0)