views: update note visualization

Signed-off-by: DATVenancio <daniel.venancio@profusion.mobi>
Signed-off-by: Victor Accarini <victor.accarini@profusion.mobi>

Author: DATVenancio

patchwork/tests/views/test_patch.py

@@ -248,7 +248,10 @@ def test_comment_redirect(self):
         self.assertRedirects(response, redirect_url)
 
     def test_show_maintainer_note(self):
-        patch = create_patch()
+        project = create_project()
+        user_default = create_user(project)
+        user_maintainer = create_maintainer(project)
+        patch = create_patch(project=project)
         note = create_patch_comment(patch=patch, msgid='')
         requested_url = reverse(
             'patch-detail',
@@ -257,6 +260,20 @@ def test_show_maintainer_note(self):
                 'msgid': patch.encoded_msgid,
             },
         )
+
+        # No authentication
+        response = self.client.get(requested_url)
+        self.assertNotIn('# Maintainer Note'.encode('utf-8'), response.content)
+        self.assertNotIn(note.content.encode('utf-8'), response.content)
+
+        # Auth with default user
+        self.client.login(username=user_default.username, password=user_default.username)
+        response = self.client.get(requested_url)
+        self.assertNotIn('# Maintainer Note'.encode('utf-8'), response.content)
+        self.assertNotIn(note.content.encode('utf-8'), response.content)
+
+        # Auth with maintainer user
+        self.client.login(username=user_maintainer.username, password=user_maintainer.username)
         response = self.client.get(requested_url)
         self.assertIn('# Maintainer Note'.encode('utf-8'), response.content)
         self.assertIn(note.content.encode('utf-8'), response.content)

patchwork/views/cover.py

@@ -58,8 +58,10 @@ def cover_detail(request, project_id, msgid):
         handle_post_maintainer_note(cover, request)
     )
 
+    if is_maintainer:
+        context['note'] = note
+
     context['comments'] = comments
-    context['note'] = note
     context['is_maintainer'] = is_maintainer
     context['create_note_form'] = create_note_form
     context['edit_note_form'] = edit_note_form

patchwork/views/patch.py

@@ -165,7 +165,9 @@ def patch_detail(request, project_id, msgid):
         related_same_project = []
         related_different_project = []
 
-    context['note'] = note
+    if is_maintainer:
+        context['note'] = note
+
     context['comments'] = comments
     context['checks'] = Patch.filter_unique_checks(
         patch.check_set.all().select_related('user'),