Replace pyright with pre-commit

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>

Author: NotTheEvilOne

.pre-commit-config.yaml

@@ -0,0 +1,25 @@
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.14.5
+    hooks:
+      - id: ruff
+        args: [ --fix ]
+      - id: ruff-format
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v6.0.0
+    hooks:
+      - id: check-yaml
+        args: [ --allow-multiple-documents ]
+      - id: check-json
+      - id: check-toml
+      - id: check-merge-conflict
+      - id: mixed-line-ending
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: 'v1.18.2'
+    hooks:
+    -   id: mypy
+        args: [--strict, --ignore-missing-imports, --check-untyped-defs]
+        additional_dependencies:
+          - types-PyYAML

Makefile

@@ -74,9 +74,9 @@ lint: install-dev
 	$(POETRY) run isort --check-only .
 	@echo
 	@echo "------------------------------------------------------------------------------------------------------------------------"
-	@echo "--// PYRIGHT //---------------------------------------------------------------------------------------------------------"
+	@echo "--// PRE-COMMIT //------------------------------------------------------------------------------------------------------"
 	@echo "------------------------------------------------------------------------------------------------------------------------"
-	$(POETRY) run pyright
+	$(POETRY) run pre-commit run --all-files
 
 security: install-dev
 	@if [ "$(CI)" = "true" ]; then \

docs/index.rst

@@ -26,4 +26,3 @@ Indices and tables
 * :ref:`genindex`
 * :ref:`modindex`
 * :ref:`search`
-

hack/print_feature_extensions.sh

@@ -3,14 +3,14 @@
 
 search_and_print_directories() {
     local pattern="$1"
-    local base_pattern="${pattern%%.*}" 
-    
+    local base_pattern="${pattern%%.*}"
+
     while IFS= read -r file; do
         dir=$(dirname "$file" | sed 's|^\./||')
-        
+
         suffix="${file##*/}"
-        suffix="${suffix#"$base_pattern"}" 
-        
+        suffix="${suffix#"$base_pattern"}"
+
         echo "('$dir', '$suffix'),"
     done < <(find . -type f -name "$pattern" | sort -u)
 }

poetry.lock

@@ -10,9 +10,9 @@ packages = [{ include = "gardenlinux", from = "src" }]
 [tool.poetry.dependencies]
 python = ">=3.13"
 apt-repo = "^0.5"
-boto3 = "^1.40.57"
-click = "^8.2.1"
-cryptography = "^46.0.1"
+boto3 = "^1.40.74"
+click = "^8.3.1"
+cryptography = "^46.0.3"
 jsonschema = "^4.25.1"
 networkx = "^3.5"
 oras = "^0.2.38"
@@ -23,14 +23,14 @@ gitpython = "^3.1.45"
 
 [tool.poetry.group.dev.dependencies]
 bandit = "^1.8.6"
-black = "^25.1.0"
-moto = "^5.1.12"
-python-dotenv = "^1.1.1"
+black = "^25.11.0"
+moto = "^5.1.16"
+pre-commit = "^4.4.0"
+python-dotenv = "^1.2.1"
 pytest = "^8.4.1"
 pytest-cov = "^7.0.0"
 isort = "^7.0.0"
 requests-mock = "^1.12.1"
-pyright = "^1.1.403"
 
 [tool.poetry.group.docs.dependencies]
 sphinx-rtd-theme = "^3.0.2"
@@ -53,19 +53,6 @@ line_length = 120
 known_first_party = ["gardenlinux"]
 skip = ["test-data", ".venv", "**/__pycache", ".pytest-cache", "hack"]
 
-[tool.pyright]
-typeCheckingMode = "strict"
-venvPath = "."
-venv = ".venv"
-exclude = [
-    "test-data",
-    "docs",
-    "hack",
-    ".venv",
-    ".pytest-cache",
-    "**/__pycache",
-]
-
 [tool.bandit]
 skips = ["B101", "B404"] # allow asserts, subprocesses
 exclude_dirs = ["tests"]

pyproject.toml

@@ -8,7 +8,7 @@
 from configparser import UNNAMED_SECTION, ConfigParser
 from os import PathLike, environ
 from pathlib import Path
-from typing import List, Optional
+from typing import Optional
 
 from ..constants import (
     ARCHS,

pyrightconfig.json

@@ -283,15 +283,15 @@ def push_index_from_directory(
 
                 if manifest["digest"] == existing_manifest["digest"]:
                     self._logger.debug(
-                        f"Skipping manifest with digest {manifest["digest"]} - already exists"
+                        f"Skipping manifest with digest {manifest['digest']} - already exists"
                     )
 
                     continue
 
             index.append_manifest(manifest)
 
             self._logger.info(
-                f"Index appended locally {manifest["annotations"]["cname"]}"
+                f"Index appended locally {manifest['annotations']['cname']}"
             )
 
             new_entries += 1
@@ -440,7 +440,7 @@ def push_manifest_and_artifacts(
                 )
 
                 self._logger.info(
-                    f"Pushed {artifact["file_name"]}: {layer_dict["digest"]}"
+                    f"Pushed {artifact['file_name']}: {layer_dict['digest']}"
                 )
             finally:
                 if cleanup_blob and file_path_name.exists():

src/gardenlinux/features/cname.py

@@ -6,7 +6,7 @@
 from .schemas import EmptyIndex
 
 
-class Index(dict):
+class Index(dict):  # type: ignore[type-arg]
     """
     OCI image index