Skip to content

Commit 4595ca7

Browse files
committed
Fix mixed cname with separate version argument parsing
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
1 parent 22be034 commit 4595ca7

2 files changed

Lines changed: 18 additions & 12 deletions

File tree

src/gardenlinux/features/__main__.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,21 @@ def main() -> None:
7474
if args.arch is not None:
7575
arch = args.arch
7676

77+
if gardenlinux_root == "":
78+
gardenlinux_root = "."
79+
7780
if args.version is not None:
7881
version = args.version
7982

8083
if arch is None or arch == "":
8184
arch = args.default_arch
8285

8386
if version is None or version == "":
84-
version_data = get_version_and_commit_id_from_files(gardenlinux_root)
85-
version = f"{version_data[0]}-{version_data[1]}"
87+
try:
88+
version_data = get_version_and_commit_id_from_files(gardenlinux_root)
89+
version = f"{version_data[0]}-{version_data[1]}"
90+
except:
91+
pass
8692

8793
if args.cname:
8894
cname = CName(args.cname, arch=arch, version=version)
@@ -106,12 +112,6 @@ def main() -> None:
106112

107113
feature_dir_name = path.basename(args.feature_dir)
108114

109-
if gardenlinux_root == "":
110-
gardenlinux_root = "."
111-
112-
if gardenlinux_root == "":
113-
gardenlinux_root = "."
114-
115115
additional_filter_func = lambda node: node not in args.ignore
116116

117117
if args.type == "arch":
@@ -199,6 +199,9 @@ def get_version_and_commit_id_from_files(gardenlinux_root: str) -> tuple[str, st
199199
with open(path.join(gardenlinux_root, "VERSION"), "r") as fp:
200200
version = fp.read().strip()
201201

202+
if commit_id is None or version is None:
203+
raise RuntimeError("Failed to read version or commit ID from files")
204+
202205
return (version, commit_id)
203206

204207

src/gardenlinux/features/cname_main.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,15 @@ def main():
5151
if args.arch is not None:
5252
arch = args.arch
5353

54-
if args.version is not None:
55-
version = args.version
54+
if gardenlinux_root == "":
55+
gardenlinux_root = "."
5656

5757
if not version:
58-
version_data = get_version_and_commit_id_from_files(gardenlinux_root)
59-
version = f"{version_data[0]}-{version_data[1]}"
58+
try:
59+
version_data = get_version_and_commit_id_from_files(gardenlinux_root)
60+
version = f"{version_data[0]}-{version_data[1]}"
61+
except:
62+
pass
6063

6164
cname = CName(args.cname, arch=arch, version=version)
6265

0 commit comments

Comments
 (0)