Add tests for .oci files

Author: Leon-hk

src/gardenlinux/features/reproducibility/comparator.py

@@ -73,7 +73,7 @@ def _unpack(file: PathLike[str]) -> tempfile.TemporaryDirectory[str]:
             with tempfile.TemporaryDirectory() as extracted:
                 # Extract .oci file
                 with tarfile.open(file, "r") as tar:
-                    tar.extractall(path=extracted)
+                    tar.extractall(path=extracted, filter="fully_trusted")
 
                 layers_dir = Path(extracted).joinpath("blobs/sha256")
                 assert layers_dir.is_dir()
@@ -96,14 +96,22 @@ def _unpack(file: PathLike[str]) -> tempfile.TemporaryDirectory[str]:
                         with tarfile.open(layer_path, "r") as tar:
                             for member in tar.getmembers():
                                 try:
-                                    tar.extract(member, path=output_dir.name)
+                                    tar.extract(
+                                        member,
+                                        path=output_dir.name,
+                                        filter="fully_trusted",
+                                    )
                                 except tarfile.AbsoluteLinkError:
                                     # Convert absolute link to relative link
                                     member.linkpath = (
                                         "../" * member.path.count("/")
                                         + member.linkpath[1:]
                                     )
-                                    tar.extract(member, path=output_dir.name)
+                                    tar.extract(
+                                        member,
+                                        path=output_dir.name,
+                                        filter="fully_trusted",
+                                    )
                                 except tarfile.TarError as e:
                                     print(f"Skipping {member.name} due to error: {e}")
         else:

test-data/reproducibility/compare/a.oci

@@ -153,26 +153,28 @@ def test_formatter_main(
     assert received == expected
 
 
-def test_comparator() -> None:
+@pytest.mark.parametrize("type", [".tar", ".oci"])
+def test_comparator_tar(type: str) -> None:
     comparator = Comparator()
 
     files, whitelist = comparator.generate(
-        compare_files.joinpath("a.tar"), compare_files.joinpath("b.tar")
+        compare_files.joinpath(f"a{type}"), compare_files.joinpath(f"b{type}")
     )
 
     assert not whitelist, "Whitelist is empty and should not filter anything"
 
     assert files == ["/a/b/c.txt"]
 
 
+@pytest.mark.parametrize("type", [".tar", ".oci"])
 def test_comparator_main(
-    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+    type: str, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
 ) -> None:
     argv = [
         "gl-diff",
         "generate",
-        str(compare_files.joinpath("a.tar")),
-        str(compare_files.joinpath("b.tar")),
+        str(compare_files.joinpath(f"a{type}")),
+        str(compare_files.joinpath(f"b{type}")),
     ]
 
     monkeypatch.setattr(sys, "argv", argv)