incorporated changes from gardenlinux issue #3485

Author: vivus-ignis

src/gardenlinux/github/__main__.py

@@ -715,7 +715,7 @@ def write_to_release_id_file(release_id):
         sys.exit(1)
 
 
-def create_github_release(owner, repo, tag, commitish, body):
+def create_github_release(owner, repo, tag, commitish, latest, body):
     token = os.environ.get("GITHUB_TOKEN")
     if not token:
         raise ValueError("GITHUB_TOKEN environment variable not set")
@@ -732,6 +732,7 @@ def create_github_release(owner, repo, tag, commitish, body):
         "body": body,
         "draft": False,
         "prerelease": False,
+        "make_latest": latest
     }
 
     response = requests.post(
@@ -797,6 +798,7 @@ def main():
     create_parser.add_argument("--repo", default="gardenlinux")
     create_parser.add_argument("--tag", required=True)
     create_parser.add_argument("--commit", required=True)
+    create_parser.add_argument('--latest', action='store_true', default=False)
     create_parser.add_argument("--dry-run", action="store_true", default=False)
 
     upload_parser = subparsers.add_parser("upload")
@@ -811,10 +813,12 @@ def main():
     if args.command == "create":
         body = create_github_release_notes(args.tag, args.commit)
         if args.dry_run:
+            print("Dry Run ...")
+            print("This release would be created:")
             print(body)
         else:
             release_id = create_github_release(
-                args.owner, args.repo, args.tag, args.commit, body
+                args.owner, args.repo, args.tag, args.commit, args.latest, body
             )
             write_to_release_id_file(f"{release_id}")
             LOGGER.info(f"Release created with ID: {release_id}")

tests/github/test_release_page.py

@@ -200,6 +200,7 @@ def test_create_github_release_needs_github_token():
                 "gardenlinux",
                 TEST_GARDENLINUX_RELEASE,
                 TEST_GARDENLINUX_COMMIT,
+                False,
                 "")
             assert str(exn.value) == "GITHUB_TOKEN environment variable not set", \
                 "Expected an exception to be raised on missing GITHUB_TOKEN environment variable"
@@ -218,6 +219,7 @@ def test_create_github_release_raise_on_failure(caplog, github_token):
                 "gardenlinux",
                 TEST_GARDENLINUX_RELEASE,
                 TEST_GARDENLINUX_COMMIT,
+                False,
                 "")
         assert any("Failed to create release" in record.message for record in caplog.records), "Expected a failure log record"
 
@@ -234,6 +236,7 @@ def test_create_github_release(caplog, github_token):
             "gardenlinux",
             TEST_GARDENLINUX_RELEASE,
             TEST_GARDENLINUX_COMMIT,
+            False,
             "") == 101
         assert any("Release created successfully" in record.message for record in caplog.records), "Expected a success log record"
 
@@ -384,7 +387,7 @@ def test_script_create_dry_run(monkeypatch, capfd):
     gh.main()
     captured = capfd.readouterr()
 
-    assert captured.out == f"{TEST_GARDENLINUX_RELEASE} {TEST_GARDENLINUX_COMMIT}\n", \
+    assert captured.out == f"Dry Run ...\nThis release would be created:\n{TEST_GARDENLINUX_RELEASE} {TEST_GARDENLINUX_COMMIT}\n", \
         "Expected dry-run create to return generated release notes text"
 
 
@@ -394,7 +397,7 @@ def test_script_create(monkeypatch, caplog):
     monkeypatch.setattr("gardenlinux.github.__main__.create_github_release_notes",
                         lambda tag, commit: f"{tag} {commit}")
     monkeypatch.setattr("gardenlinux.github.__main__.create_github_release",
-                        lambda a1, a2, a3, a4, a5: TEST_GARDENLINUX_RELEASE)
+                        lambda a1, a2, a3, a4, a5, a6: TEST_GARDENLINUX_RELEASE)
 
     gh.main()