fix: make paste deduplication name-aware#219
Merged
Merged
Conversation
Paste collisions used to be content-only: pasting a clip whose XML matched any existing clip was silently skipped, regardless of name. This broke variant tracking (paste, rename, repaste leaves the user with only the renamed copy). Dedup now keys on (name, folder). Same name + same content skips as a true duplicate. Different name + same content lands as a variant. Same name + different content prompts the user via a new IClipCollisionPrompt with Replace / Keep both / Cancel choices and an apply-to-all option for batch (group) pastes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(name, folder)rather than XML-content alone. Pasting a clip whose name and content both already exist still skips silently; everything else gets an explicit decision.IClipCollisionPromptmodal (Replace / Keep both / Cancel) for same-name + different-content. "Apply to all remaining clips in this paste" keeps batch (group) pastes from re-prompting once the user has made a call.NullClipCollisionPromptdefault, which returnsCancelso collisions never silently mutate existing clips.