fix: duplicate variable name

Author: fullstackondemand

src/Controller/AbstractAuthController.php

@@ -28,7 +28,7 @@ public function login($req, $res) {
             throw new HttpBadRequestException($req, "Username or password is required.");
 
         /** Check User Entity */
-        $user = errorHandler($this->model->findBy(['username' => $username]));
+        $user = errorHandler($this->_model->findBy(['username' => $username]));
 
         if (!$user)
             throw new HttpUnauthorizedException($req, 'Invalid user credentials');

src/Controller/AbstractController.php

@@ -9,14 +9,14 @@
 class AbstractController {
 
     /** Entity All Data */
-    private $data;
+    private $_data;
 
     /** Model Class Object */
-    private $model;
+    protected $_model;
 
     public function __construct($model, $data) {
-        $this->data = $data;
-        $this->model = $model;
+        $this->_data = $data;
+        $this->_model = $model;
     }
 
     /** Find All Data */
@@ -26,14 +26,14 @@ public function findAll($req, $res) {
         $filter = $req->getQueryParams()['filter'] ?? null;
 
         /** Filter Data */
-        $data = $this->data;
+        $data = $this->_data;
 
         // Selected Column Fetch All Data
         if ($filter):
             $data = [];
             $filter = explode(",", $filter);
 
-            foreach ($this->data as $item)
+            foreach ($this->_data as $item)
                 array_push($data, array_intersect_key((array) $item, array_flip($filter)));
         endif;
 
@@ -44,28 +44,28 @@ public function findAll($req, $res) {
     public function findByColumn($req, $res, $args) {
 
         foreach ($args as $key => $value)
-            $data = array_filter($this->data, fn($item) => $item->$key == $args[$key]);
+            $data = array_filter($this->_data, fn($item) => $item->$key == $args[$key]);
 
         checkNull($data, $req);
         return response($req, $res, args: new Response(data: [...$data]));
     }
 
     /** Delete Data by Id */
     public function delete($req, $res, $args) {
-        $data = $this->model->delete($args['id']);
+        $data = $this->_model->delete($args['id']);
         checkNull($data, $req);
         return response($req, $res, new Response(message: "This item has been successfully removed.", data: $data));
     }
 
     /** Insert Data */
     public function insert($req, $res, $args) {
-        $data = $this->model->insert($req->getParsedBody());
+        $data = $this->_model->insert($req->getParsedBody());
         return response($req, $res, new Response(message: "This item has been successfully added.", data: $data));
     }
 
     /** Update by Id */
     public function update($req, $res, $args) {
-        $data = $this->model->update($req->getParsedBody(), $args["id"]);
+        $data = $this->_model->update($req->getParsedBody(), $args["id"]);
         checkNull($data, $req);
         return response($req, $res, new Response(message: "This item has been successfully updated.", data: $data));
     }

src/Middleware/AbstractAuthMiddleware.php

@@ -14,10 +14,10 @@
 abstract class AbstractAuthMiddleware implements MiddlewareInterface {
 
     /** User Class Object */
-    private $user;
+    private $_user;
 
     public function __construct($user) {
-        $this->user = $user;
+        $this->_user = $user;
     }
 
     public function process(Request $req, RequestHandler $handler): ResponseInterface {
@@ -40,7 +40,7 @@ public function process(Request $req, RequestHandler $handler): ResponseInterfac
             throw new HttpUnauthorizedException($req, "Invalid access token");
 
         /** Check User Entity */
-        $user = $this->user->findById($decodedToken['id']);
+        $user = $this->_user->findById($decodedToken['id']);
 
         if (!$user)
             throw new HttpUnauthorizedException($req, "Invalid access token");