Skip to content

[Bug] The Esc key should be disabled when a modal is in the "in progress" state #2792

@FeBe95

Description

@FeBe95

Description

Steps to reproduce:

  1. Add a dummy (text) file to your repo that has a file size of > 10 MB.
  2. Right-click the file in the "Unstaged" panel.
  3. Select "Stash 1 file".
  4. Click "Save Stash".
  5. While the modal is still open, hit the Esc key on your keyboard.

Expected outcome:

  • The "Save stash" modal stays open because stashing is in progress.
  • The 🞩 (Close) button appears disabled and is not clickable.
  • The Cancel button appears disabled and is not clickable.

Actual outcome:

  • The "Save stash" modal gets closed, the stashing progress continues in the background.
  • The 🞩 (Close) button appears enabled, but is not clickable.
  • The Cancel button appears disabled and is not clickable.

The UI does not update when the background progress has eventually finished, and the stash is saved. This leaves the UI in an unstable state where it shows files that are stashed now and don't actually exist in anymore in the repo folder.

Note

This also applies to other modals, e.g. the "Apply Stash" modal.

Screenshots

Save Stash Modal:

Image

Apply Stash Modal:

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions