Skip to content

interactive rebase focus mismatch targets wrong commit #2558

@cruzdanilo

Description

@cruzdanilo

summary

after the new focusable update dependent branches checkbox was added to the interactive rebase dialog, keyboard behavior became inconsistent.

the commit list still reacts to cmd+up / cmd+down (commits move), but action shortcuts can apply to a different commit (often the first commit in the list), not the one that was just moved or appears active.

this looks like a focus/selection mismatch between controls in the dialog.

steps to reproduce

  1. open the interactive rebase dialog.
  2. use cmd+up or cmd+down to move a commit in the list.
  3. press an action shortcut (for example e, r, s, f, or d).
  4. observe which commit gets the action.

expected behavior

keyboard movement and action shortcuts should target the same commit row.
if the checkbox has focus, commit-list shortcuts should not partially apply.

actual behavior

cmd+up / cmd+down can move commits in the list, but action shortcuts may apply to a different row (commonly the first row), causing operations to run on the wrong commit.

impact

this can silently rewrite or alter the wrong commit during rebase and is easy to miss.

notes

screen recording attached: https://github.com/user-attachments/assets/a8ac235b-d4fc-41ce-8db9-1c8e9cf2814c

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions