From 8dfbfab49b290a969ed7bb6248f3880137ef177d Mon Sep 17 00:00:00 2001 From: "J. Kirby Ross" Date: Sun, 28 Sep 2025 16:25:42 -0700 Subject: [PATCH 1/6] chore(ci/docs): Enforce pedantic rigor and normalize notation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ach! Even ze machine's notation must be clean and without superfluous ornamentation. Zis movement ensures consistent syntactic rigor across all automated workflows, preparing our score for distribution. * **Syntactic Normalization:** Switched single quotes to double quotes (`"3.x"`) and removed excessive whitespace around list elements in YAML. The music must be metrically precise. * **Relocation:** Updated all `uses:` paths and example documentation (in README, Instructions, and scripts) to reflect the final, true location of the *Draft Punks* concerto repository. The score must be fetched from its proper concert hall (`flyingrobots/draft-punks`). * **Thematic Example:** Updated the example PR number to a thematically appropriate '69' in the seeding script's documentation. Discipline must be absolute. The metronome is steady. *— P.R. PhiedBach, Kapellmeister of Commits* --- .github/workflows/apply-feedback.yml | 4 ++-- .github/workflows/auto-seed-review.yml | 4 ++-- .github/workflows/coderabbit-status.yml | 2 +- .github/workflows/seed-review.yml | 2 +- Instructions.md | 4 ++-- README.md | 8 ++++---- tools/review/seed_feedback_from_github.py | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/apply-feedback.yml b/.github/workflows/apply-feedback.yml index 2f6165c..438fc27 100644 --- a/.github/workflows/apply-feedback.yml +++ b/.github/workflows/apply-feedback.yml @@ -2,9 +2,9 @@ name: Apply PR Feedback Replies on: push: - branches-ignore: [ main ] + branches-ignore: [main] paths: - - 'docs/code-reviews/**.md' + - "docs/code-reviews/**.md" permissions: contents: read diff --git a/.github/workflows/auto-seed-review.yml b/.github/workflows/auto-seed-review.yml index 3dba75c..f154eb9 100644 --- a/.github/workflows/auto-seed-review.yml +++ b/.github/workflows/auto-seed-review.yml @@ -21,7 +21,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.x' + python-version: "3.x" - name: Seed feedback doc into repo env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -55,7 +55,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.x' + python-version: "3.x" - name: Try to seed and push to fork (if maintainers can modify) env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/coderabbit-status.yml b/.github/workflows/coderabbit-status.yml index 262babc..c8ed452 100644 --- a/.github/workflows/coderabbit-status.yml +++ b/.github/workflows/coderabbit-status.yml @@ -16,7 +16,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.x' + python-version: "3.x" - name: Check unresolved CodeRabbit threads env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/seed-review.yml b/.github/workflows/seed-review.yml index f00a85b..7a25339 100644 --- a/.github/workflows/seed-review.yml +++ b/.github/workflows/seed-review.yml @@ -18,7 +18,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.x' + python-version: "3.x" - name: Run seeding script env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/Instructions.md b/Instructions.md index e817544..1bab971 100644 --- a/Instructions.md +++ b/Instructions.md @@ -57,7 +57,7 @@ on: jobs: seed: - uses: neuroglyph/draft-punks/.github/workflows/seed-review.yml@v1.0.0 + uses: flyingrobots/draft-punks/.github/workflows/seed-review.yml@v1.0.0 secrets: inherit ``` @@ -70,7 +70,7 @@ on: jobs: apply: - uses: neuroglyph/draft-punks/.github/workflows/apply-feedback.yml@v1.0.0 + uses: flyingrobots/draft-punks/.github/workflows/apply-feedback.yml@v1.0.0 secrets: inherit ``` diff --git a/README.md b/README.md index 1f31aef..35977eb 100644 --- a/README.md +++ b/README.md @@ -93,7 +93,7 @@ on: jobs: seed: - uses: neuroglyph/draft-punks/.github/workflows/seed-review.yml@v1.0.0 + uses: flyingrobots/draft-punks/.github/workflows/seed-review.yml@v1.0.0 secrets: inherit ``` @@ -106,7 +106,7 @@ on: jobs: apply: - uses: neuroglyph/draft-punks/.github/workflows/apply-feedback.yml@v1.0.0 + uses: flyingrobots/draft-punks/.github/workflows/apply-feedback.yml@v1.0.0 secrets: inherit ``` @@ -130,8 +130,8 @@ status: archive # Code Review Feedback -| Date | Agent | SHA | Branch | PR | -|------|-------|-----|--------|----| +| Date | Agent | SHA | Branch | PR | +| ---------- | ----- | ------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------- | | 2025-09-16 | Codex | `e4f3f906eb454cb103eb8cc6899df8dfbf6e2349` | [feat/changelog-and-sweep-4](https://github.com/neuroglyph/git-mind/tree/feat/changelog-and-sweep-4 "neuroglyph/git-mind:feat/changelog-and-sweep-4") | [PR#169](https://github.com/neuroglyph/git-mind/pull/169) | ## Instructions diff --git a/tools/review/seed_feedback_from_github.py b/tools/review/seed_feedback_from_github.py index de4b527..b8082e2 100755 --- a/tools/review/seed_feedback_from_github.py +++ b/tools/review/seed_feedback_from_github.py @@ -11,7 +11,7 @@ Usage: python3 tools/review/seed_feedback_from_github.py \ - --owner neuroglyph --repo git-mind --pr 169 \ + --owner flyingrobots --repo draft-punks --pr 69 \ [--commit ] [--out docs/code-reviews] If --commit is omitted, the PR head SHA is used. From 3e4796edfecc7a5f59dc0d5fcfda910ff966169f Mon Sep 17 00:00:00 2001 From: "P.R. PhiedBach" Date: Sun, 28 Sep 2025 23:27:43 +0000 Subject: [PATCH 2/6] opus(PR#1): seed rehearsal score (8dfbfab49b290a969ed7bb6248f3880137ef177d) --- ...dfbfab49b290a969ed7bb6248f3880137ef177d.md | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md diff --git a/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md b/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md new file mode 100644 index 0000000..bad4b3b --- /dev/null +++ b/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md @@ -0,0 +1,104 @@ +--- +title: 8dfbfab49b290a969ed7bb6248f3880137ef177d.md +description: Preserved review artifacts and rationale. +audience: [contributors] +domain: [quality] +tags: [review] +status: archive +--- + +# Code Review Feedback + +| Date | Agent | SHA | Branch | PR | +|------|-------|-----|--------|----| +| 2025-09-28 | CodeRabbit (and reviewers) | `8dfbfab49b290a969ed7bb6248f3880137ef177d` | [chore/format](https://github.com/flyingrobots/draft-punks/tree/chore/format "flyingrobots/draft-punks:chore/format") | [PR#1](https://github.com/flyingrobots/draft-punks/pull/1) | + +## CODE REVIEW FEEDBACK + +### General comment — coderabbitai[bot] + +```text + + + +> [!NOTE] +> Currently processing new changes in this PR. This may take a few minutes, please wait... +> +>
+> 📥 Commits +> +> Reviewing files that changed from the base of the PR and between 5547a98558eff02ecce2a39e40e6813d24516caa and 8dfbfab49b290a969ed7bb6248f3880137ef177d. +> +>
+> +>
+> 📒 Files selected for processing (7) +> +> * `.github/workflows/apply-feedback.yml` (1 hunks) +> * `.github/workflows/auto-seed-review.yml` (2 hunks) +> * `.github/workflows/coderabbit-status.yml` (1 hunks) +> * `.github/workflows/seed-review.yml` (1 hunks) +> * `Instructions.md` (2 hunks) +> * `README.md` (3 hunks) +> * `tools/review/seed_feedback_from_github.py` (1 hunks) +> +>
+> +> ```ascii +> _________________________________________________________________________________________________________________________________________________________________ +> < Don't use wizard code you don't understand. Wizards can generate reams of code. Make sure you understand all of it before you incorporate it into your project. > +> ----------------------------------------------------------------------------------------------------------------------------------------------------------------- +> \ +> \ \ +> \ /\ +> ( ) +> .( o ). +> ``` + + + + + + +
+✨ Finishing touches + +- [ ] 📝 Generate Docstrings +
+🧪 Generate unit tests + +- [ ] Create PR with unit tests +- [ ] Post copyable unit tests in a comment +- [ ] Commit unit tests in branch `chore/format` + +
+ +
+ + + + + +--- + +Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. + +
+❤️ Share + +- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) +- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) +- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) +- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) + +
+ +Comment `@coderabbitai help` to get the list of available commands and usage tips. + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 + +{response} + From 27b99435126e3d7a58706a4f6e0d20a5c02b1608 Mon Sep 17 00:00:00 2001 From: James Ross Date: Sun, 28 Sep 2025 18:36:13 -0700 Subject: [PATCH 3/6] Apply suggestion from @coderabbitai[bot] Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: James Ross --- .../PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md b/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md index bad4b3b..6efd30c 100644 --- a/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md +++ b/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md @@ -98,7 +98,7 @@ Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. ``` -_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 +_Meta_: {response} From 0369361800224ce5ac3de8f1bf7cce73446d4ffa Mon Sep 17 00:00:00 2001 From: "P.R. PhiedBach" Date: Mon, 29 Sep 2025 01:36:23 +0000 Subject: [PATCH 4/6] opus(PR#1): seed rehearsal score (27b99435126e3d7a58706a4f6e0d20a5c02b1608) --- ...7b99435126e3d7a58706a4f6e0d20a5c02b1608.md | 249 ++++++++++++++++++ 1 file changed, 249 insertions(+) create mode 100644 docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md diff --git a/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md b/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md new file mode 100644 index 0000000..38842ad --- /dev/null +++ b/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md @@ -0,0 +1,249 @@ +--- +title: 27b99435126e3d7a58706a4f6e0d20a5c02b1608.md +description: Preserved review artifacts and rationale. +audience: [contributors] +domain: [quality] +tags: [review] +status: archive +--- + +# Code Review Feedback + +| Date | Agent | SHA | Branch | PR | +|------|-------|-----|--------|----| +| 2025-09-29 | CodeRabbit (and reviewers) | `27b99435126e3d7a58706a4f6e0d20a5c02b1608` | [chore/format](https://github.com/flyingrobots/draft-punks/tree/chore/format "flyingrobots/draft-punks:chore/format") | [PR#1](https://github.com/flyingrobots/draft-punks/pull/1) | + +## CODE REVIEW FEEDBACK + +### docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md:103 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟡 Minor_ + +**FIX THE RAW URL; THE LINTER IS SCREAMING FOR A REASON.** + +Leaving a naked URL in Line 101 violates MD034 and makes the doc look like it was thrown together during a power outage. Wrap it in proper Markdown so the pipeline stops whining. Based on static analysis. + +Apply this diff so we stop shipping lint errors: +```diff +-_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 ++_Meta_: +``` + + + +
+📝 Committable suggestion + +> ‼️ **IMPORTANT** +> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. + +```suggestion +_Meta_: + +{response} +``` + +
+ + + +
+🧰 Tools + +
+🪛 markdownlint-cli2 (0.18.1) + +101-101: Bare URL used + +(MD034, no-bare-urls) + +
+ +
+ +
+🤖 Prompt for AI Agents + +``` +In docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md around +lines 101 to 103 there is a naked/raw URL that violates MD034; replace the raw +URL with a proper Markdown link (e.g., use [descriptive text](https://...) or +otherwise format it as an explicit link) so the linter stops flagging the file +and the doc renders cleanly. +``` + +
+ + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386420430 + +{response} + +### README.md:136 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟠 Major_ + +**FIX THE STALE LINK NOW.** + +Line [135] is STILL pointing at `neuroglyph/...` even though this PR screams about switching everything to `flyingrobots`. That bad data nukes the whole “align our house score” goal. Update the branch and PR URLs to the new org before shipping this lie. + +
+🤖 Prompt for AI Agents + +``` +In README.md around lines 133 to 136 the branch and PR links still point to the +old org "neuroglyph"; update both the branch URL and the PR URL to use the new +org "flyingrobots" (i.e., change the base domain paths from +github.com/neuroglyph/... to github.com/flyingrobots/...) so the branch and PR +links correctly reference the flyingrobots/git-mind repo; keep the displayed +branch text, SHA and PR number unchanged. +``` + +
+ + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386420432 + +{response} + +### General comment — coderabbitai[bot] + +```text + + + +> [!NOTE] +> Currently processing new changes in this PR. This may take a few minutes, please wait... +> +>
+> 📥 Commits +> +> Reviewing files that changed from the base of the PR and between 3e4796edfecc7a5f59dc0d5fcfda910ff966169f and 27b99435126e3d7a58706a4f6e0d20a5c02b1608. +> +>
+> +>
+> 📒 Files selected for processing (1) +> +> * `docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md` (1 hunks) +> +>
+> +> ```ascii +> ________________________________________________________ +> < PR looks good? I’ll just summon three more edge cases. > +> -------------------------------------------------------- +> \ +> \ (\__/) +> (•ㅅ•) +> / 　 づ +> ``` + + + + + + + +## Summary by CodeRabbit + +- Documentation + - Updated references to the new organization for workflow actions. + - Refreshed README tables and examples for clearer formatting. + - Added an archival code-review report for transparency. + - Clarified setup/instructions and revised a tooling usage example. + - General readability and consistency improvements across docs. + +- Chores + - Standardized quoting and spacing in CI workflows for consistency; no functional or behavioral changes. + + +## Walkthrough +Documentation and workflow YAMLs were reformatted and retargeted: GitHub Actions quoting normalized; action references switched from neuroglyph to flyingrobots; README/Instructions updated accordingly. A new archival code-review markdown was added. A Python tool’s example usage comment was updated. No logic or control-flow changes anywhere. + +## Changes +| Cohort / File(s) | Summary | +|---|---| +| **GitHub Actions formatting**
` .github/workflows/apply-feedback.yml`, `.github/workflows/auto-seed-review.yml`, `.github/workflows/coderabbit-status.yml`, `.github/workflows/seed-review.yml` | Standardized quoting and minor spacing; no functional changes. | +| **Docs: action source updates**
`Instructions.md`, `README.md` | Switched workflow references from `neuroglyph/draft-punks/...` to `flyingrobots/draft-punks/...`; README table/header formatting adjusted. | +| **Archival review doc**
`docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md` | Added a new markdown record of code-review feedback with metadata, tables, and checklists. | +| **Tooling comment update**
`tools/review/seed_feedback_from_github.py` | Updated usage example comment (owner/repo/PR); no code or logic modifications. | + +## Estimated code review effort +🎯 1 (Trivial) | ⏱️ ~3 minutes + +## Poem +> Quotation marks marched, neat and tight, +> Workflows saluted—left, right, right. +> Docs changed badges, swapped their flights, +> A review scroll joined archive nights. +> Code stayed still (as it damn well should). +> Ship it clean—because formats must be good. + + + + + +## Pre-merge checks and finishing touches +
+❌ Failed checks (1 inconclusive) + +| Check name | Status | Explanation | Resolution | +| :---------: | :------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | +| Title Check | ❓ Inconclusive | The pull request title “Kapellmeister's Errata: Align Our House Score” is thematically tied to the concept of errata and alignment, but it relies on metaphor rather than clearly stating the core changes—namely updating workflow repository references from neuroglyph to flyingrobots/draft-punks and standardizing YAML formatting—which may obscure its purpose to team members browsing the history. | Consider revising the title to explicitly mention the key updates, for example “Update GitHub Actions references and standardize YAML formatting,” so that the main technical changes are immediately clear to reviewers. | + +
+
+✅ Passed checks (2 passed) + +| Check name | Status | Explanation | +| :----------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | +| Description Check | ✅ Passed | The pull request description clearly outlines the specific modifications—including replacing `neuroglyph` action references with `flyingrobots/draft-punks`, tightening YAML notation, and updating the README table and seeding script usage example—that directly match the changes in the code and documentation. | +| Docstring Coverage | ✅ Passed | No functions found in the changes. Docstring coverage check skipped. | + +
+ + + + + +--- + +Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. + +
+❤️ Share + +- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) +- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) +- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) +- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) + +
+ +Comment `@coderabbitai help` to get the list of available commands and usage tips. + + + + + + + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 + +{response} + From 85ac499f573fd79192a02aae02d2b0d97fcbc8c8 Mon Sep 17 00:00:00 2001 From: "J. Kirby Ross" Date: Sun, 28 Sep 2025 18:41:35 -0700 Subject: [PATCH 5/6] chore: CodeRabbit feedbacks --- README.md | 2 +- ...7b99435126e3d7a58706a4f6e0d20a5c02b1608.md | 42 ++++++++++++++++++- ...dfbfab49b290a969ed7bb6248f3880137ef177d.md | 22 +++++++++- tools/review/check_coderabbit_threads.py | 33 +++++++++------ 4 files changed, 83 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 35977eb..9ef8201 100644 --- a/README.md +++ b/README.md @@ -132,7 +132,7 @@ status: archive | Date | Agent | SHA | Branch | PR | | ---------- | ----- | ------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------- | -| 2025-09-16 | Codex | `e4f3f906eb454cb103eb8cc6899df8dfbf6e2349` | [feat/changelog-and-sweep-4](https://github.com/neuroglyph/git-mind/tree/feat/changelog-and-sweep-4 "neuroglyph/git-mind:feat/changelog-and-sweep-4") | [PR#169](https://github.com/neuroglyph/git-mind/pull/169) | +| 2025-09-16 | Codex | `e4f3f906eb454cb103eb8cc6899df8dfbf6e2349` | [feat/changelog-and-sweep-4](https://github.com/flyingrobots/git-mind/tree/feat/changelog-and-sweep-4 "flyingrobots/git-mind:feat/changelog-and-sweep-4") | [PR#169](https://github.com/flyingrobots/git-mind/pull/169) | ## Instructions diff --git a/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md b/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md index 38842ad..366fd1c 100644 --- a/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md +++ b/docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md @@ -82,7 +82,26 @@ and the doc renders cleanly. _Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386420430 -{response} +> [!note]- **Accepted** +> | Confidence | Remarks | +> |------------|---------| +> | 10 | Auto-applied a patch from CodeRabbit | +> +> ## Lesson Learned +> +> Raw URLS bad +> +> ## What did you do to address this feedback? +> +> Accepted CodeRabbit's help. +> +> ## Regression Avoidance Strategy +> +> N/A +> +> ## Notes +> +> None. ### README.md:136 — coderabbitai[bot] @@ -245,5 +264,24 @@ Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. _Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 -{response} +> [!note]- **Accepted** +> | Confidence | Remarks | +> |------------|---------| +> | 0 | This seems like a bug... | +> +> ## Lesson Learned +> +> N/A. +> +> ## What did you do to address this feedback? +> +> Nothing. +> +> ## Regression Avoidance Strategy +> +> N/A. +> +> ## Notes +> +> None. diff --git a/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md b/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md index 6efd30c..83a3121 100644 --- a/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md +++ b/docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md @@ -100,5 +100,25 @@ Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. _Meta_: -{response} + +> [!note]- **Accepted** +> | Confidence | Remarks | +> |------------|---------| +> | 0 | This seems like a bug... | +> +> ## Lesson Learned +> +> N/A. +> +> ## What did you do to address this feedback? +> +> Nothing. +> +> ## Regression Avoidance Strategy +> +> N/A. +> +> ## Notes +> +> None. diff --git a/tools/review/check_coderabbit_threads.py b/tools/review/check_coderabbit_threads.py index 8793eb3..db6db38 100755 --- a/tools/review/check_coderabbit_threads.py +++ b/tools/review/check_coderabbit_threads.py @@ -10,28 +10,37 @@ from __future__ import annotations import argparse +import json import os import sys from typing import List, Tuple - -import requests +from urllib import error, request GRAPHQL_ENDPOINT = "https://api.github.com/graphql" CODERABBIT_LOGIN = "coderabbitai" def github_graphql(token: str, query: str, variables: dict) -> dict: - response = requests.post( - GRAPHQL_ENDPOINT, - json={"query": query, "variables": variables}, - headers={"Authorization": f"Bearer {token}", "Accept": "application/vnd.github+json"}, - timeout=30, - ) - if response.status_code != 200: + payload = json.dumps({"query": query, "variables": variables}).encode("utf-8") + headers = { + "Authorization": f"Bearer {token}", + "Accept": "application/vnd.github+json", + "Content-Type": "application/json", + } + req = request.Request(GRAPHQL_ENDPOINT, data=payload, headers=headers, method="POST") + + try: + with request.urlopen(req, timeout=30) as response: + body = response.read() + except error.HTTPError as exc: + error_body = exc.read().decode("utf-8", "replace") raise RuntimeError( - f"GitHub GraphQL API returned {response.status_code}: {response.text}" - ) - data = response.json() + f"GitHub GraphQL API returned {exc.code}: {error_body}" + ) from exc + except error.URLError as exc: + raise RuntimeError(f"GitHub GraphQL request failed: {exc}") from exc + + data = json.loads(body.decode("utf-8")) if "errors" in data: raise RuntimeError(f"GitHub GraphQL error: {data['errors']}") return data["data"] From 10c2e69af85ebbccedcb387353e83cdba9092941 Mon Sep 17 00:00:00 2001 From: "P.R. PhiedBach" Date: Mon, 29 Sep 2025 01:41:48 +0000 Subject: [PATCH 6/6] opus(PR#1): seed rehearsal score (85ac499f573fd79192a02aae02d2b0d97fcbc8c8) --- ...5ac499f573fd79192a02aae02d2b0d97fcbc8c8.md | 521 ++++++++++++++++++ 1 file changed, 521 insertions(+) create mode 100644 docs/code-reviews/PR1/85ac499f573fd79192a02aae02d2b0d97fcbc8c8.md diff --git a/docs/code-reviews/PR1/85ac499f573fd79192a02aae02d2b0d97fcbc8c8.md b/docs/code-reviews/PR1/85ac499f573fd79192a02aae02d2b0d97fcbc8c8.md new file mode 100644 index 0000000..70234ae --- /dev/null +++ b/docs/code-reviews/PR1/85ac499f573fd79192a02aae02d2b0d97fcbc8c8.md @@ -0,0 +1,521 @@ +--- +title: 85ac499f573fd79192a02aae02d2b0d97fcbc8c8.md +description: Preserved review artifacts and rationale. +audience: [contributors] +domain: [quality] +tags: [review] +status: archive +--- + +# Code Review Feedback + +| Date | Agent | SHA | Branch | PR | +|------|-------|-----|--------|----| +| 2025-09-29 | CodeRabbit (and reviewers) | `85ac499f573fd79192a02aae02d2b0d97fcbc8c8` | [chore/format](https://github.com/flyingrobots/draft-punks/tree/chore/format "flyingrobots/draft-punks:chore/format") | [PR#1](https://github.com/flyingrobots/draft-punks/pull/1) | + +## CODE REVIEW FEEDBACK + +### docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md:103 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟡 Minor_ + +**FIX THE RAW URL; THE LINTER IS SCREAMING FOR A REASON.** + +Leaving a naked URL in Line 101 violates MD034 and makes the doc look like it was thrown together during a power outage. Wrap it in proper Markdown so the pipeline stops whining. Based on static analysis. + +Apply this diff so we stop shipping lint errors: +```diff +-_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 ++_Meta_: +``` + + + +
+📝 Committable suggestion + +> ‼️ **IMPORTANT** +> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. + +```suggestion +_Meta_: + +{response} +``` + +
+ + + +
+🧰 Tools + +
+🪛 markdownlint-cli2 (0.18.1) + +101-101: Bare URL used + +(MD034, no-bare-urls) + +
+ +
+ +
+🤖 Prompt for AI Agents + +``` +In docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md around +lines 101 to 103 there is a naked/raw URL that violates MD034; replace the raw +URL with a proper Markdown link (e.g., use [descriptive text](https://...) or +otherwise format it as an explicit link) so the linter stops flagging the file +and the doc renders cleanly. +``` + +
+ + + + + +✅ Addressed in commit 27b9943 +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386420430 + +{response} + +### README.md:136 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟠 Major_ + +**FIX THE STALE LINK NOW.** + +Line [135] is STILL pointing at `neuroglyph/...` even though this PR screams about switching everything to `flyingrobots`. That bad data nukes the whole “align our house score” goal. Update the branch and PR URLs to the new org before shipping this lie. + +
+🤖 Prompt for AI Agents + +``` +In README.md around lines 133 to 136 the branch and PR links still point to the +old org "neuroglyph"; update both the branch URL and the PR URL to use the new +org "flyingrobots" (i.e., change the base domain paths from +github.com/neuroglyph/... to github.com/flyingrobots/...) so the branch and PR +links correctly reference the flyingrobots/git-mind repo; keep the displayed +branch text, SHA and PR number unchanged. +``` + +
+ + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386420432 + +{response} + +### docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md:76 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟠 Major_ + +**ADD A LANGUAGE TAG TO THIS CODE FENCE.** + +Why am I staring at another anonymous fence? markdownlint (MD040/MD031) is already barfing. Slap a language on it and give it breathing room, or this archive stays blocked. + +```diff + 🤖 Prompt for AI Agents + +-``` +-In docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md around +-lines 101 to 103 there is a naked/raw URL that violates MD034; replace the raw +-URL with a proper Markdown link (e.g., use [descriptive text](https://...) or +-otherwise format it as an explicit link) so the linter stops flagging the file +-and the doc renders cleanly. +-``` +- +- ++```text ++In docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md around ++lines 101 to 103 there is a naked/raw URL that violates MD034; replace the raw ++URL with a proper Markdown link (e.g., use [descriptive text](https://...) or ++otherwise format it as an explicit link) so the linter stops flagging the file ++and the doc renders cleanly. ++``` ++ ++ +``` + +
+🧰 Tools + +
+🪛 markdownlint-cli2 (0.18.1) + +68-68: Fenced code blocks should have a language specified + +(MD040, fenced-code-language) + +
+ +
+ +
+🤖 Prompt for AI Agents + +```` +In docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md around +lines 68 to 76, the code fence is missing a language tag and contains a +naked/raw URL that triggers MD040/MD031 and MD034; update the opening fence to +include an appropriate language (e.g., ```text or ```diff) and replace the raw +URL inside the fenced block with a proper Markdown link using descriptive text +(e.g., [description](https://...)) so the linter no longer flags the file and +the block renders correctly. +```` + +
+ + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386501504 + +{response} + +### docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md:133 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟠 Major_ + +**STOP SHIPPING BARE URLs.** + +Line 113 is still naked, so MD034 keeps screaming. Wrap the link properly; this is basic hygiene. + +```diff +-_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386420430 ++_Meta_: +``` + + + +
+📝 Committable suggestion + +> ‼️ **IMPORTANT** +> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. + +```suggestion +
+ + + + +_Meta_: +``` + + + + + +
+🧰 Tools + +
+🪛 markdownlint-cli2 (0.18.1) + +106-106: Fenced code blocks should be surrounded by blank lines + +(MD031, blanks-around-fences) + +--- + +106-106: Fenced code blocks should have a language specified + +(MD040, fenced-code-language) + +
+ +
+ +
+🤖 Prompt for AI Agents + +``` +In docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md around +lines 106 to 114 there is a bare URL on line 113 triggering MD034; replace it +with a proper markdown link or enclose it in angle brackets to avoid a naked URL +(e.g., convert to [descriptive text](https://example.com) or +), ensuring link text is descriptive if possible. +``` + +
+ + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386501505 + +{response} + +### docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md:145 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟠 Major_ + +**TAG THE SECOND CODE FENCE TOO.** + +Didn't learn from the first one? This second prompt block also violates MD040/MD031. Fix it the same way so the linter shuts up. + +```diff + 🤖 Prompt for AI Agents + +-``` +-In README.md around lines 133 to 136 the branch and PR links still point to the +-old org "neuroglyph"; update both the branch URL and the PR URL to use the new +-org "flyingrobots" (i.e., change the base domain paths from +-github.com/neuroglyph/... to github.com/flyingrobots/...) so the branch and PR +-links correctly reference the flyingrobots/git-mind repo; keep the displayed +-branch text, SHA and PR number unchanged. +-``` +- +- ++```text ++In README.md around lines 133 to 136 the branch and PR links still point to the ++old org "neuroglyph"; update both the branch URL and the PR URL to use the new ++org "flyingrobots" (i.e., change the base domain paths from ++github.com/neuroglyph/... to github.com/flyingrobots/...) so the branch and PR ++links correctly reference the flyingrobots/git-mind repo; keep the displayed ++branch text, SHA and PR number unchanged. ++``` ++ ++ +``` + +
+🤖 Prompt for AI Agents + +```` +docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md around lines +118 to 126: the second fenced code block is not tagged with a language which +triggers MD040/MD031; update the opening fence to include the language +identifier "text" (i.e., change ``` to ```text) and ensure the closing fence +remains ``` so the block is properly tagged and the linter stops complaining. +```` + +
+ + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386501507 + +{response} + +### docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md:266 — coderabbitai[bot] + +```text +_⚠️ Potential issue_ | _🟠 Major_ + +**NO RAW LINKS IN THE FOOTER EITHER.** + +You fixed one `_Meta_` link and then left this one raw? Come on. Wrap it or expect the lint job to torch the PR again. + +```diff +-_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 ++_Meta_: +``` + + + +
+📝 Committable suggestion + +> ‼️ **IMPORTANT** +> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. + +```suggestion +_Meta_: +``` + +
+ + + +
+🧰 Tools + +
+🪛 markdownlint-cli2 (0.18.1) + +246-246: Bare URL used + +(MD034, no-bare-urls) + +
+ +
+ +
+🤖 Prompt for AI Agents + +``` +In docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md around +lines 246 to 247, there is a raw URL in the footer ("_Meta_: +https://github.com/...") which violates the no-raw-links rule; replace or wrap +the raw link using the project's preferred format (e.g., Markdown link text +[Meta] or reference-style link) so the footer contains a wrapped/linkified URL +consistent with the other fixes. +``` + +
+ + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#discussion_r2386501509 + +{response} + +### General comment — coderabbitai[bot] + +```text + + + +> [!NOTE] +> Currently processing new changes in this PR. This may take a few minutes, please wait... +> +>
+> 📥 Commits +> +> Reviewing files that changed from the base of the PR and between 0369361800224ce5ac3de8f1bf7cce73446d4ffa and 85ac499f573fd79192a02aae02d2b0d97fcbc8c8. +> +>
+> +>
+> 📒 Files selected for processing (4) +> +> * `README.md` (3 hunks) +> * `docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md` (1 hunks) +> * `docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md` (1 hunks) +> * `tools/review/check_coderabbit_threads.py` (1 hunks) +> +>
+> +> ```ascii +> _______________________________ +> < Copilot: Off. CodeRabbit: On. > +> ------------------------------- +> \ +> \ \ +> \ /\ +> ( ) +> .( o ). +> ``` + + + + + + + +## Summary by CodeRabbit + +- Documentation + - Updated references to GitHub Actions from the old organization to the new one. + - Improved README formatting, including the Code Review Feedback table. + - Added archival code-review documents for better traceability. + - Refreshed a usage example to reflect current repository and PR details. + +- Chores + - Standardized quoting and spacing in CI workflows; no behavioral changes. + + +## Walkthrough +Reformatted several GitHub Actions YAMLs (quoting/spacing), swapped workflow action references from `neuroglyph/draft-punks/...` to `flyingrobots/draft-punks/...` in docs and README, added two archival code-review markdowns, and updated a tooling usage example comment. No runtime logic or control-flow changes. + +## Changes +| Cohort / File(s) | Summary | +|---|---| +| **GitHub Actions formatting**
`.github/workflows/apply-feedback.yml`, `.github/workflows/auto-seed-review.yml`, `.github/workflows/coderabbit-status.yml`, `.github/workflows/seed-review.yml` | Normalized quoting and minor spacing in workflow YAMLs; no behavioral changes. | +| **Docs: action source updates**
`Instructions.md`, `README.md` | Replaced `neuroglyph/draft-punks/...` references with `flyingrobots/draft-punks/...`; README table/header formatting adjusted. | +| **Archival review docs**
`docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md`, `docs/code-reviews/PR1/27b99435126e3d7a58706a4f6e0d20a5c02b1608.md` | Added two archival Markdown records documenting CodeRabbit review feedback with metadata, tables, and checklists. | +| **Tooling comment update**
`tools/review/seed_feedback_from_github.py` | Updated example usage comment (owner/repo/PR); no code or logic changes. | + +## Estimated code review effort +🎯 2 (Simple) | ⏱️ ~10 minutes + +## Poem +> Quotation marks aligned in tidy rows, +> Actions switched their flighty avo's. +> Two review scrolls find archive light, +> A comment tweaked — the rest sits tight. +> Formats primped; the code stays right. + + + + + +## Pre-merge checks and finishing touches +
+❌ Failed checks (1 inconclusive) + +| Check name | Status | Explanation | Resolution | +| :---------: | :------------- | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | +| Title Check | ❓ Inconclusive | This title is a dizzying piece of poetic fluff that fails to tell anyone what was actually changed, forcing reviewers to decipher the metaphor instead of instantly knowing that we updated workflow references and standardized YAML formatting! It’s too vague and artsy to serve the primary purpose of a pull request title, which is to concisely convey the main change. We need clarity, not musical allegory! | Rename the pull request title to a direct summary of the actual modifications, such as “Update GitHub Actions workflow references to flyingrobots/draft-punks and standardize YAML quoting,” so reviewers can immediately grasp the changes made. | + +
+
+✅ Passed checks (2 passed) + +| Check name | Status | Explanation | +| :----------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | +| Description Check | ✅ Passed | Despite the theatrical flourish, the description clearly outlines replacing repository references, tightening YAML notation, and updating the README, so it’s fully relevant and provides sufficient context for reviewers to understand the scope of the changes. | +| Docstring Coverage | ✅ Passed | No functions found in the changes. Docstring coverage check skipped. | + +
+ + + + + +--- + +Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. + +
+❤️ Share + +- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) +- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) +- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) +- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) + +
+ +Comment `@coderabbitai help` to get the list of available commands and usage tips. + + + + + + + + + +``` + +_Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 + +{response} +