From b4632b4a311d0aadc1628ce90fcaa9957254020a Mon Sep 17 00:00:00 2001 From: Kenzie Davisson Date: Thu, 7 May 2026 15:56:25 -0700 Subject: [PATCH 1/2] Add retry to eval_integration_test.dart to help with flake. --- .../test/shared/eval_integration_test.dart | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/packages/devtools_app/test/shared/eval_integration_test.dart b/packages/devtools_app/test/shared/eval_integration_test.dart index d8bec3aa0b9..a8d70338129 100644 --- a/packages/devtools_app/test/shared/eval_integration_test.dart +++ b/packages/devtools_app/test/shared/eval_integration_test.dart @@ -70,9 +70,11 @@ void main() { expect(instance2.classRef!.name, '_Future'); }, timeout: const Timeout.factor(2), - // TODO(https://github.com/flutter/devtools/issues/6998): if this flake - // is addressed, we can unskip this for the Flutter customer tests. + // TODO(https://github.com/flutter/devtools/issues/9484): if this flake + // is addressed, we can unskip this for the Flutter customer tests and + // remove the retry. tags: skipForCustomerTestsTag, + retry: 3, ); test( @@ -99,9 +101,11 @@ void main() { expect(instance.valueAsString, '42'); }, timeout: const Timeout.factor(2), - // TODO(https://github.com/flutter/devtools/issues/6998): if this flake - // is addressed, we can unskip this for the Flutter customer tests. + // TODO(https://github.com/flutter/devtools/issues/9484): if this flake + // is addressed, we can unskip this for the Flutter customer tests and + // remove the retry. tags: skipForCustomerTestsTag, + retry: 3, ); test( @@ -151,9 +155,11 @@ void main() { expect(error.valueAsString, 'foo'); }, timeout: const Timeout.factor(2), - // TODO(https://github.com/flutter/devtools/issues/6998): if this flake - // is addressed, we can unskip this for the Flutter customer tests. + // TODO(https://github.com/flutter/devtools/issues/9484): if this flake + // is addressed, we can unskip this for the Flutter customer tests and + // remove the retry. tags: skipForCustomerTestsTag, + retry: 3, ); }); }); From 0bb941e7f559ebed0c50299ec9a024ad7e5afb26 Mon Sep 17 00:00:00 2001 From: Kenzie Davisson Date: Thu, 7 May 2026 16:03:53 -0700 Subject: [PATCH 2/2] dry --- .../test/shared/eval_integration_test.dart | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/devtools_app/test/shared/eval_integration_test.dart b/packages/devtools_app/test/shared/eval_integration_test.dart index a8d70338129..f6f16e637a5 100644 --- a/packages/devtools_app/test/shared/eval_integration_test.dart +++ b/packages/devtools_app/test/shared/eval_integration_test.dart @@ -71,10 +71,8 @@ void main() { }, timeout: const Timeout.factor(2), // TODO(https://github.com/flutter/devtools/issues/9484): if this flake - // is addressed, we can unskip this for the Flutter customer tests and - // remove the retry. + // is addressed, we can unskip this for the Flutter customer tests. tags: skipForCustomerTestsTag, - retry: 3, ); test( @@ -102,10 +100,8 @@ void main() { }, timeout: const Timeout.factor(2), // TODO(https://github.com/flutter/devtools/issues/9484): if this flake - // is addressed, we can unskip this for the Flutter customer tests and - // remove the retry. + // is addressed, we can unskip this for the Flutter customer tests. tags: skipForCustomerTestsTag, - retry: 3, ); test( @@ -156,11 +152,11 @@ void main() { }, timeout: const Timeout.factor(2), // TODO(https://github.com/flutter/devtools/issues/9484): if this flake - // is addressed, we can unskip this for the Flutter customer tests and - // remove the retry. + // is addressed, we can unskip this for the Flutter customer tests. tags: skipForCustomerTestsTag, - retry: 3, ); - }); + // TODO(https://github.com/flutter/devtools/issues/9484): if this flake + // is addressed, we can remove the retry. + }, retry: 3); }); }