Skip to content

Commit 2d18e08

Browse files
committed
chore: Set public GPG key id as a environment variable
1 parent 33074a0 commit 2d18e08

2 files changed

Lines changed: 2 additions & 15 deletions

File tree

.github/resources/settings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</activation>
2222
<properties>
2323
<gpg.executable>gpg</gpg.executable>
24-
<gpg.keyname>40232A3CABB94E75E654F6A973E5C093C01673CB</gpg.keyname>
24+
<gpg.keyname>${env.GPG_KEYID}</gpg.keyname>
2525
<gpg.passphrase>${env.GPG_PASSPHRASE}</gpg.passphrase>
2626
</properties>
2727
</profile>

.github/workflows/release.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ jobs:
101101
env:
102102
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
103103
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
104+
GPG_KEYID: ${{ vars.GPG_KEYID }}
104105
CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }}
105106
CENTRAL_TOKEN: ${{ secrets.CENTRAL_TOKEN }}
106107

@@ -112,17 +113,3 @@ jobs:
112113
--title "Firebase Admin Java SDK ${{ steps.preflight.outputs.version }}"
113114
--notes '${{ steps.preflight.outputs.changelog }}'
114115

115-
# Post to Twitter if explicitly opted-in by adding the label 'release:tweet'.
116-
- name: Post to Twitter
117-
if: success() &&
118-
contains(github.event.pull_request.labels.*.name, 'release:tweet')
119-
uses: firebase/firebase-admin-node/.github/actions/send-tweet@2e2b36a84ba28679bcb7aecdacabfec0bded2d48 # Admin Node SDK v13.6.0
120-
with:
121-
status: >
122-
${{ steps.preflight.outputs.version }} of @Firebase Admin Java SDK is available.
123-
https://github.com/firebase/firebase-admin-java/releases/tag/${{ steps.preflight.outputs.version }}
124-
consumer-key: ${{ secrets.TWITTER_CONSUMER_KEY }}
125-
consumer-secret: ${{ secrets.TWITTER_CONSUMER_SECRET }}
126-
access-token: ${{ secrets.TWITTER_ACCESS_TOKEN }}
127-
access-token-secret: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
128-
continue-on-error: true

0 commit comments

Comments
 (0)