add better support for role tests

Author: janishar

tests/auth/authentication/mock.ts

@@ -9,7 +9,7 @@ import { IKeystore } from '../../../src/database/model/Keystore';
 
 export const ACCESS_TOKEN = 'xyz';
 
-export const USER_ID = new Types.ObjectId('5e7b95923085872d3c378f35'); // random id with object id format
+export const USER_ID = new Types.ObjectId(); // random id with object id format
 
 export const mockUserFindById = jest.fn(async (id: Types.ObjectId) => {
 	if (USER_ID.equals(id)) return <IUser>{ _id: new Types.ObjectId(id) };
@@ -46,8 +46,8 @@ export const addHeaders = (request: any) => request
 	.set('Content-Type', 'application/json')
 	.set('x-api-key', API_KEY);
 
-export const addAuthHeaders = (request: any) => request
+export const addAuthHeaders = (request: any, userId: Types.ObjectId = USER_ID) => request
 	.set('Content-Type', 'application/json')
 	.set('x-api-key', API_KEY)
 	.set('x-access-token', ACCESS_TOKEN)
-	.set('x-user-id', USER_ID);
+	.set('x-user-id', userId.toHexString());

tests/auth/authorization/index.test.ts

@@ -2,7 +2,7 @@ import { addAuthHeaders } from '../authentication/mock';
 
 // import the mock for the current test after all other mock imports
 // this will prevent the different implementations by the other mock
-import { mockRoleRepoFindByCode, mockUserFindByIdForWriter } from './mock';
+import { mockRoleRepoFindByCode, mockUserFindById, USER_ID_WRITER } from './mock';
 
 import app from '../../../src/app';
 import supertest from 'supertest';
@@ -15,15 +15,15 @@ describe('authentication validation for editor', () => {
 
 	beforeEach(() => {
 		mockRoleRepoFindByCode.mockClear();
-		mockUserFindByIdForWriter.mockClear();
+		mockUserFindById.mockClear();
 	});
 
 	it('Should response with 401 if user do not have editor role', async () => {
 		const response = await addAuthHeaders(request.get(endpoint));
 		expect(response.status).toBe(401);
 		expect(response.body.message).toMatch(/denied/);
 		expect(mockRoleRepoFindByCode).toBeCalledTimes(1);
-		expect(mockUserFindByIdForWriter).toBeCalledTimes(1);
+		expect(mockUserFindById).toBeCalledTimes(1);
 		expect(mockRoleRepoFindByCode).toBeCalledWith(RoleCode.EDITOR);
 	});
 });
@@ -35,14 +35,14 @@ describe('authentication validation for writer', () => {
 
 	beforeEach(() => {
 		mockRoleRepoFindByCode.mockClear();
-		mockUserFindByIdForWriter.mockClear();
+		mockUserFindById.mockClear();
 	});
 
 	it('Should response with 404 if user have writer role', async () => {
-		const response = await addAuthHeaders(request.get(endpoint));
+		const response = await addAuthHeaders(request.get(endpoint), USER_ID_WRITER);
 		expect(response.status).toBe(404);
 		expect(mockRoleRepoFindByCode).toBeCalledTimes(1);
-		expect(mockUserFindByIdForWriter).toBeCalledTimes(1);
+		expect(mockUserFindById).toBeCalledTimes(1);
 		expect(mockRoleRepoFindByCode).toBeCalledWith(RoleCode.WRITER);
 	});
 });

tests/auth/authorization/mock.ts

@@ -5,18 +5,35 @@ import { Types } from 'mongoose';
 import { IUser } from '../../../src/database/model/User';
 import { RoleCode, IRole } from '../../../src/database/model/Role';
 
-const LEARNER_ROLE_ID = new Types.ObjectId('5e7b95923085872d3c378f35'); // RONDOM ID
-const WRITER_ROLE_ID = new Types.ObjectId('56cb91bdc3464f14678934ca'); // RONDOM ID
-const EDITOR_ROLE_ID = new Types.ObjectId('58cd7cfcf9f1150515ee9fb0'); // RONDOM ID
 
-export const mockUserFindByIdForWriter = jest.fn(async (id: Types.ObjectId) => {
+export const LEARNER_ROLE_ID = new Types.ObjectId(); // random id
+export const WRITER_ROLE_ID = new Types.ObjectId(); // random id
+export const EDITOR_ROLE_ID = new Types.ObjectId(); // random id
+
+export const USER_ID_WRITER = new Types.ObjectId(); // random id
+export const USER_ID_EDITOR = new Types.ObjectId(); // random id
+
+export const mockUserFindById = jest.fn(async (id: Types.ObjectId) => {
 	if (USER_ID.equals(id)) return <IUser>{
 		_id: USER_ID,
+		roles: [
+			<IRole>{ _id: LEARNER_ROLE_ID, code: RoleCode.LEARNER },
+		]
+	};
+	if (USER_ID_WRITER.equals(id)) return <IUser>{
+		_id: USER_ID_WRITER,
 		roles: [
 			<IRole>{ _id: LEARNER_ROLE_ID, code: RoleCode.LEARNER },
 			<IRole>{ _id: WRITER_ROLE_ID, code: RoleCode.WRITER },
 		]
 	};
+	if (USER_ID_EDITOR.equals(id)) return <IUser>{
+		_id: USER_ID_EDITOR,
+		roles: [
+			<IRole>{ _id: LEARNER_ROLE_ID, code: RoleCode.LEARNER },
+			<IRole>{ _id: WRITER_ROLE_ID, code: RoleCode.EDITOR },
+		]
+	};
 	else return null;
 });
 
@@ -43,7 +60,7 @@ export const mockRoleRepoFindByCode = jest.fn(
 	});
 
 jest.mock('../../../src/database/repository/UserRepo', () => ({
-	get findById() { return mockUserFindByIdForWriter; }
+	get findById() { return mockUserFindById; }
 }));
 
 jest.mock('../../../src/database/repository/RoleRepo', () => ({