Skip to content

Commit cc6fb69

Browse files
committed
Layout and PEP8 related improvements
1 parent 8580893 commit cc6fb69

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

python-ethtool/ethtool.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,8 @@ static PyObject *get_flags (PyObject *self __unused, PyObject *args)
321321
close(fd);
322322

323323
return Py_BuildValue("h", ifr.ifr_flags);
324-
325-
326324
}
325+
327326
static PyObject *get_netmask (PyObject *self __unused, PyObject *args)
328327
{
329328
struct ifreq ifr;

tests/parse_ifconfig.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,12 @@
5555
dec + dot +
5656
dec + ')')
5757

58+
5859
def parse_ip4addr(addr):
5960
import socket
6061
return (socket.inet_aton(addr))
6162

63+
6264
class IfConfig:
6365
"""
6466
Wrapper around a single invocation of "ifconfig"

tests/test_ethtool.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
for dev in ifconfig.devices:
3636
print(dev)
3737

38+
3839
class EthtoolTests(unittest.TestCase):
3940

4041
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -191,7 +192,7 @@ def test_invalid_devices(self):
191192

192193
get_fns = ('get_broadcast', 'get_businfo', 'get_coalesce', 'get_flags',
193194
'get_gso', 'get_hwaddr', 'get_ipaddr', 'get_module',
194-
'get_netmask', 'get_ringparam', 'get_sg', 'get_tso',
195+
'get_netmask', 'get_ringparam', 'get_sg', 'get_tso',
195196
'get_ufo')
196197
for fnname in get_fns:
197198
self.assertRaisesNoSuchDevice(getattr(ethtool, fnname),
@@ -231,7 +232,7 @@ def test_get_interface_info_all(self):
231232
def test_get_active_devices(self):
232233
for devname in ethtool.get_active_devices():
233234
self._functions_accepting_devnames(devname)
234-
235+
235236
def test_etherinfo_objects(self):
236237
devnames = ethtool.get_devices()
237238
eis = ethtool.get_interfaces_info(devnames)

0 commit comments

Comments
 (0)