Added suggestions

Author: ojeda-e

lib/matplotlib/tests/test_lines.py

@@ -20,15 +20,6 @@
 from matplotlib.testing.decorators import image_comparison, check_figures_equal
 
 
-@pytest.fixture
-def cases():
-    """Define a list of markevery cases to plot."""
-    cases = [None, 8, (30, 8), [16, 24, 30], [0, -1],
-             slice(100, 200, 3), 0.1, 0.3, 1.5,
-             (0.0, 0.1), (0.45, 0.1)]
-    return cases
-
-
 def test_segment_hits():
     """Test a problematic case."""
     cx, cy = 553, 902
@@ -355,22 +346,26 @@ def test_input_copy(fig_test, fig_ref):
 
 
 @check_figures_equal(extensions=["png"])
-def test_markevery_prop_cycle(fig_test, fig_ref, cases):
+def test_markevery_prop_cycle(fig_test, fig_ref):
+    """Test that we can set markevery prop_cycle."""
+    cases = [None, 8, (30, 8), [16, 24, 30], [0, -1],
+             slice(100, 200, 3), 0.1, 0.3, 1.5,
+             (0.0, 0.1), (0.45, 0.1)]
 
     cmap = plt.get_cmap('jet')
     colors = cmap(np.linspace(0.2, 0.8, len(cases)))
 
-    x = np.linspace(0, 2 * np.pi)
-    offsets = np.linspace(0, 2 * np.pi, 11, endpoint=False)
-    yy = np.transpose([np.sin(x + phi) for phi in offsets])
+    x = np.linspace(-1, 1)
+    y = 5 * x**2
 
-    axs = fig_ref.add_axes([0.1, 0.1, 0.6, 0.75])
-    for i in range(len(cases)):
-        axs.plot(yy[:, i], markevery=cases[i],  c=colors[i])
+    axs = fig_ref.add_subplot()
+    for i, markevery in enumerate(cases):
+        axs.plot(y - i, 'o-', markevery=markevery, color=colors[i])
 
     matplotlib.rcParams['axes.prop_cycle'] = cycler(markevery=cases,
                                                     color=colors)
 
-    ax = fig_test.add_axes([0.1, 0.1, 0.6, 0.75])
-    for i in range(len(cases)):
-        ax.plot(yy[:, i])
+    ax = fig_test.add_subplot()
+    for i, _ in enumerate(cases):
+	    ax.plot(y - i, 'o-')
+