refactor: move valid and invalid email addresses to test classes

Signed-off-by: Kenny Pflug <kenny.pflug@live.de>

Author: feO2x

Code/Light.GuardClauses.Tests/StringAssertions/InvalidEmailAddresses.cs

@@ -0,0 +1,33 @@
+using Xunit;
+
+namespace Light.GuardClauses.Tests.StringAssertions;
+
+public class InvalidEmailAddresses : TheoryData<string>
+{
+    public InvalidEmailAddresses()
+    {
+        Add("plainaddress");
+        Add("#@%^%#$@#$@#.com");
+        Add("@domain.com");
+        Add("Joe Smith <email@domain.com>");
+        Add("email.domain.com");
+        Add("email@domain@domain.com");
+        Add(".email@domain.com");
+        Add("email.@domain.com");
+        Add("email..email@domain.com");
+        Add("email@domain.com (Joe Smith)");
+        Add("email@domain");
+        Add("email@-domain.com");
+        Add("email@111.222.333.44444");
+        Add("email@domain..com");
+        Add("email@256.256.256.256");
+    }
+}
+
+public sealed class InvalidEmailAddressesWithNull : InvalidEmailAddresses
+{
+    public InvalidEmailAddressesWithNull()
+    {
+        Add(null);
+    }
+}

Code/Light.GuardClauses.Tests/StringAssertions/IsEmailAddressTests.cs

@@ -6,59 +6,17 @@ namespace Light.GuardClauses.Tests.StringAssertions;
 
 public sealed class IsEmailAddressTests
 {
-    public static readonly TheoryData<string> InvalidEmailAddresses =
-    [
-        null,
-        "plainaddress",
-        "#@%^%#$@#$@#.com",
-        "@domain.com",
-        "Joe Smith <email@domain.com>",
-        "email.domain.com",
-        "email@domain@domain.com",
-        ".email@domain.com",
-        "email.@domain.com",
-        "email..email@domain.com",
-        "email@domain.com (Joe Smith)",
-        "email@domain",
-        "email@-domain.com",
-        "email@111.222.333.44444",
-        "email@domain..com",
-        "email@256.256.256.256",
-    ];
-
     [Theory]
-    [MemberData(nameof(InvalidEmailAddresses))]
+    [ClassData(typeof(InvalidEmailAddressesWithNull))]
     public void IsNotValidEmailAddress(string email)
     {
         var isValid = email.IsEmailAddress();
 
         isValid.Should().BeFalse();
     }
 
-    public static readonly TheoryData<string> ValidEmailAddresses =
-    [
-        "email@domain.com",
-        "firstname.lastname@domain.com",
-        "email@subdomain.domain.com",
-        "firstname+lastname@domain.com",
-        "email@123.123.123.123",
-        "1234567890@domain.com",
-        "email@domain-one.com",
-        "_______@domain.com",
-        "email@domain.name",
-        "email@domain.co.jp",
-        "firstname-lastname@domain.com",
-        "email@domain.museum", // Long TLD (>4 chars)
-        "email@domain.travel", // Another long TLD
-        "email@domain.photography", // Even longer TLD
-        "email@[IPv6:2001:db8::1]", // IPv6 format
-        "\"quoted\"@domain.com", // Quoted local part
-        "user.name+tag+sorting@example.com", // Gmail-style + addressing
-        "あいうえお@domain.com", // Unicode character test
-    ];
-
     [Theory]
-    [MemberData(nameof(ValidEmailAddresses))]
+    [ClassData(typeof(ValidEmailAddresses))]
     public void IsValidEmailAddress(string email)
     {
         var isValid = email.IsEmailAddress();
@@ -68,7 +26,7 @@ public void IsValidEmailAddress(string email)
 
 #if NET8_0
     [Theory]
-    [MemberData(nameof(InvalidEmailAddresses))]
+    [ClassData(typeof(InvalidEmailAddressesWithNull))]
     public void IsNotValidEmailAddress_ReadOnlySpan(string email)
     {
         var span = new ReadOnlySpan<char>(email?.ToCharArray() ?? []);
@@ -78,7 +36,7 @@ public void IsNotValidEmailAddress_ReadOnlySpan(string email)
     }
 
     [Theory]
-    [MemberData(nameof(ValidEmailAddresses))]
+    [ClassData(typeof(ValidEmailAddresses))]
     public void IsValidEmailAddress_ReadOnlySpan(string email)
     {
         var span = email.AsSpan();
@@ -88,7 +46,7 @@ public void IsValidEmailAddress_ReadOnlySpan(string email)
     }
 
     [Theory]
-    [MemberData(nameof(InvalidEmailAddresses))]
+    [ClassData(typeof(InvalidEmailAddressesWithNull))]
     public void IsNotValidEmailAddress_Span(string email)
     {
         var span = new Span<char>(email?.ToCharArray() ?? []);
@@ -98,7 +56,7 @@ public void IsNotValidEmailAddress_Span(string email)
     }
 
     [Theory]
-    [MemberData(nameof(ValidEmailAddresses))]
+    [ClassData(typeof(ValidEmailAddresses))]
     public void IsValidEmailAddress_Span(string email)
     {
         var span = new Span<char>(email.ToCharArray());
@@ -108,7 +66,7 @@ public void IsValidEmailAddress_Span(string email)
     }
 
     [Theory]
-    [MemberData(nameof(InvalidEmailAddresses))]
+    [ClassData(typeof(InvalidEmailAddressesWithNull))]
     public void IsNotValidEmailAddress_Memory(string email)
     {
         var memory = email?.ToCharArray().AsMemory() ?? Memory<char>.Empty;
@@ -118,7 +76,7 @@ public void IsNotValidEmailAddress_Memory(string email)
     }
 
     [Theory]
-    [MemberData(nameof(ValidEmailAddresses))]
+    [ClassData(typeof(ValidEmailAddresses))]
     public void IsValidEmailAddress_Memory(string email)
     {
         var memory = email.ToCharArray().AsMemory();
@@ -128,7 +86,7 @@ public void IsValidEmailAddress_Memory(string email)
     }
 
     [Theory]
-    [MemberData(nameof(InvalidEmailAddresses))]
+    [ClassData(typeof(InvalidEmailAddressesWithNull))]
     public void IsNotValidEmailAddress_ReadOnlyMemory(string email)
     {
         var memory = new ReadOnlyMemory<char>(email?.ToCharArray() ?? []);
@@ -138,7 +96,7 @@ public void IsNotValidEmailAddress_ReadOnlyMemory(string email)
     }
 
     [Theory]
-    [MemberData(nameof(ValidEmailAddresses))]
+    [ClassData(typeof(ValidEmailAddresses))]
     public void IsValidEmailAddress_ReadOnlyMemory(string email)
     {
         var memory = new ReadOnlyMemory<char>(email.ToCharArray());

Code/Light.GuardClauses.Tests/StringAssertions/ValidEmailAddresses.cs

@@ -0,0 +1,28 @@
+using Xunit;
+
+namespace Light.GuardClauses.Tests.StringAssertions;
+
+public sealed class ValidEmailAddresses : TheoryData<string>
+{
+    public ValidEmailAddresses()
+    {
+        Add("email@domain.com");
+        Add("firstname.lastname@domain.com");
+        Add("email@subdomain.domain.com");
+        Add("firstname+lastname@domain.com");
+        Add("email@123.123.123.123");
+        Add("1234567890@domain.com");
+        Add("email@domain-one.com");
+        Add("_______@domain.com");
+        Add("email@domain.name");
+        Add("email@domain.co.jp");
+        Add("firstname-lastname@domain.com");
+        Add("email@domain.museum"); // Long TLD (>4 chars)
+        Add("email@domain.travel"); // Another long TLD
+        Add("email@domain.photography"); // Even longer TLD
+        Add("email@[IPv6:2001:db8::1]"); // IPv6 format
+        Add("\"quoted\"@domain.com"); // Quoted local part
+        Add("user.name+tag+sorting@example.com"); // Gmail-style + addressing
+        Add("あいうえお@domain.com"); // Unicode character test
+    }
+}