ESM build attempts to import CJS build modules from 'entities'

[barneycarroll]

Parser.ts hardcodes an import identifier pointing to the CJS build of entities:

htmlparser2/src/Parser.ts

Line 2 in b3ce38c

import { fromCodePoint } from "entities/lib/decode.js";

This breaks pure ESM parsing of the ESM build. I'm not sure what a conventional solution would look like, but assume there ought to be an 'abstract' identifier path which would resolve by parsing package.json depending on environment?

[maxgurewitz]

@barneycarroll were you able to address this?

[barneycarroll]

@maxgurewitz the closed source project I was using that depended on htmlparser2 (via linkedom) uses a custom JavaScript parser, so the issue was worked around there. I know various open source bundlers and runtime hacks allow inter-operating CJS & ESM, but I couldn’t recommend a generic solution.

[fb55]

Fixed with #2381 (to be released soon)