π· Setup GH actions workflow to check sources for typos#160
Conversation
This reverts commit 9028c1b.
savannahostrowski
left a comment
There was a problem hiding this comment.
Yeah, I went with Husky here rather than pre-commit/prek since this repo is node-only. Husky installs automatically with bun install and there's no second toolchain for contributors.
I tested and we could layer a soft typos check into the Husky pre-commit hook which runs typos only if the CLI is on PATH, and skips with an install hint otherwise. So no hard local dependency, but anyone who's brew installed typos-cli gets the check at commit time.
But this way, it won't run in CI, right? I think checking it in CI is more important, but you can decide π |
|
Right, I'm saying, we should have this but perhaps also consider having this run locally on commit, optionally, if the user has the CLI installed. |
Set up GH actions workflow to catch typos in sources.
In other repos we use it as pre-commit hook (see fastapi/fastapi#15482), but here we don't have prek, so I think GH action will be fine
Checked by introducing typo in 9028c1b: