make check Fails on main Due to Non-ASCII Characters in block_based_table_iterator.cc

[mohakgoel1]

While running make check on the latest main branch of RocksDB OSS, the build consistently fails due to the presence of non-ASCII characters in the file:

table/block_based/block_based_table_iterator.cc

Error Output

Below is the exact failure seen during the build:

build_tools/check-sources.sh
table/block_based/block_based_table_iterator.cc:1092:  //  next_scan_idx: ----------------- <E2><94><90>
table/block_based/block_based_table_iterator.cc:1093:  //                             <E2><96><BC>
table/block_based/block_based_table_iterator.cc:1095:  //  Seek target: <-- Case 1 --> <E2><96><B2> <--- Case 2 -->
table/block_based/block_based_table_iterator.cc:1096:  //
^^^^ Use only ASCII characters in source files
make[1]: *** [Makefile:1242: check-sources] Error 1
make: *** [Makefile:1035: check] Error 2

Expected Behavior

make check should pass without errors on the main branch.

Actual Behavior

The script build_tools/check-sources.sh fails because the above lines contain non-ASCII Unicode symbols (likely arrow or formatting characters).

Steps to Reproduce

• Clone RocksDB (main branch):

git clone https://github.com/facebook/rocksdb.git
cd rocksdb

• Run:

make check

• The build fails with the error shown above.

Suggested Fix

Remove or replace the non-ASCII characters (<94><90>, <96>, <96>, etc.) with pure ASCII equivalents such as -->, <--, or plain comments.

Environment

• Branch: main
• OS: Ubuntu 22.04 ARM64
• Compiler: gcc (Ubuntu 13.1.0-8ubuntu1~22.04) 13.1.0
• Reproducible: Yes, 100%

[malkhabir]

Seems like a Linux-only issue.

[mohakgoel1]

Hi @malkhabir

Thanks for the update!
Do we have any plans to fix this issue in the main branch? Since it consistently breaks make check on Linux environments, it would be good to know if a patch is already planned or being tracked.