From 781ee75b959f9405c0c4a4fd09816d471d18e12c Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Thu, 12 Feb 2026 03:15:23 -0800 Subject: [PATCH] Move RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION to its only consumer Summary: Move the RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION define from RCTDefines.h to RCTDevSettings.mm, which is its only consumer. This removes a __has_include dependency from the shared header, making RCTDefines.h usable as a standalone lightweight target without pulling in RCTPackagerConnection.h. Changelog: [Internal] Differential Revision: D93018381 --- packages/react-native/React/Base/RCTDefines.h | 8 -------- packages/react-native/React/CoreModules/RCTDevSettings.mm | 8 ++++++++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/react-native/React/Base/RCTDefines.h b/packages/react-native/React/Base/RCTDefines.h index b9bf3288acf5cb..a36b359b615cc7 100644 --- a/packages/react-native/React/Base/RCTDefines.h +++ b/packages/react-native/React/Base/RCTDefines.h @@ -95,14 +95,6 @@ #define RCT_DEV_MENU RCT_DEV #endif -#ifndef RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION -#if RCT_DEV && (__has_include("RCTPackagerConnection.h") || __has_include()) -#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 1 -#else -#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 0 -#endif -#endif - #if RCT_DEV #define RCT_IF_DEV(...) __VA_ARGS__ #else diff --git a/packages/react-native/React/CoreModules/RCTDevSettings.mm b/packages/react-native/React/CoreModules/RCTDevSettings.mm index 712d890386fd6d..cc4cb1c74e52c3 100644 --- a/packages/react-native/React/CoreModules/RCTDevSettings.mm +++ b/packages/react-native/React/CoreModules/RCTDevSettings.mm @@ -36,6 +36,14 @@ #import #endif +#ifndef RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION +#if RCT_DEV && (__has_include("RCTPackagerConnection.h") || __has_include()) +#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 1 +#else +#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 0 +#endif +#endif + #if RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION #import #endif