Commit bdfac9c
Fix multiple lint warnings in NativeViewHierarchyManager (#55499)
Summary:
Fixed multiple lint warnings in NativeViewHierarchyManager.java:
1. ClownyBooleanExpression: Added SuppressLint for intentionally disabled
DEBUG_MODE (ReactBuildConfig.DEBUG && false). This pattern is used to
easily enable debug mode by changing to just ReactBuildConfig.DEBUG.
2. NullableAnnotationShouldNotAddToPrimitiveTypes: Removed Nullable from
getInstanceHandle() which returns a primitive long. Primitives can't be
null; this method throws exceptions instead of returning null.
3. NotInvokedPrivateMethod: Removed unused private methods arrayContains()
and getReactContextForView() which were dead code.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D919929351 parent ad8ac5e commit bdfac9c
1 file changed
Lines changed: 4 additions & 25 deletions
File tree
- packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager
Lines changed: 4 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
79 | 83 | | |
80 | 84 | | |
81 | 85 | | |
| |||
248 | 252 | | |
249 | 253 | | |
250 | 254 | | |
251 | | - | |
252 | 255 | | |
253 | 256 | | |
254 | 257 | | |
| |||
523 | 526 | | |
524 | 527 | | |
525 | 528 | | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | 529 | | |
539 | 530 | | |
540 | 531 | | |
| |||
851 | 842 | | |
852 | 843 | | |
853 | 844 | | |
854 | | - | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
863 | | - | |
864 | | - | |
865 | | - | |
866 | 845 | | |
867 | 846 | | |
868 | 847 | | |
| |||
0 commit comments