Remove unused functions in GenericPieces

Summary:
Remove these functions as they are not called outside tests.
It'll make the migration to MultiRangeCachePieces cleaner.

Differential Revision: D90874867

fbshipit-source-id: c25d33ba912cac8272dc9cea9346a1207c00aae7

Author: fdmeta

cachelib/common/piecewise/GenericPieces.h

@@ -99,39 +99,7 @@ class GenericPieces : public GenericPiecesBase {
            1;
   }
 
-  uint64_t getRequestedSizeOfAPiece(uint64_t pieceIndex) const {
-    if (startPieceIndex_ == endPieceIndex_) {
-      XDCHECK_EQ(pieceIndex, startPieceIndex_);
-      return requestedEndByte_ - requestedStartByte_ + 1;
-    }
-
-    if (pieceIndex == startPieceIndex_) {
-      // For the first piece, trim bytes before requestedStartByte_
-      return pieceSize_ - requestedStartByte_ % pieceSize_;
-    } else if (pieceIndex == endPieceIndex_) {
-      // For the last piece, trim bytes after requestedEndByte_
-      return requestedEndByte_ % pieceSize_ + 1;
-    } else {
-      return pieceSize_;
-    }
-  }
-
-  uint64_t getBytesToTrimAtStart() const {
-    return requestedStartByte_ - startPieceIndex_ * pieceSize_;
-  }
-
-  uint64_t getBytesToTrimAtEnd() const {
-    return getLastByteOffsetOfLastPiece() - requestedEndByte_;
-  }
-
-  uint64_t getRequestedSize() const {
-    return (requestedEndByte_ - requestedStartByte_ + 1);
-  }
-
   uint64_t getStartPieceIndex() const { return startPieceIndex_; }
-  [[nodiscard]] uint64_t getStartPieceOffset() const {
-    return startPieceIndex_ * pieceSize_;
-  }
   uint64_t getEndPieceIndex() const { return endPieceIndex_; }
   uint64_t getRequestedStartByte() const { return requestedStartByte_; }
   uint64_t getRequestedEndByte() const { return requestedEndByte_; }

cachelib/common/piecewise/GenericPiecesTest.cpp

@@ -33,13 +33,8 @@ TEST(GenericPiecesTests, Normal) {
   EXPECT_EQ(0, cp.getCurFetchingPieceIndex());
   EXPECT_EQ(999, cp.getLastByteOffsetOfLastPiece());
   EXPECT_EQ(256, cp.getSizeOfAPiece(0));
-  EXPECT_EQ(256, cp.getRequestedSizeOfAPiece(0));
   EXPECT_EQ(232, cp.getSizeOfAPiece(3));
-  EXPECT_EQ(232, cp.getRequestedSizeOfAPiece(3));
   EXPECT_EQ(1000, cp.getTotalSize());
-  EXPECT_EQ(0, cp.getBytesToTrimAtStart());
-  EXPECT_EQ(0, cp.getBytesToTrimAtEnd());
-  EXPECT_EQ(1000, cp.getRequestedSize());
   EXPECT_EQ(1000, cp.getRemainingBytes());
   cp.updateFetchIndex();
   EXPECT_EQ(744, cp.getRemainingBytes());
@@ -56,14 +51,9 @@ TEST(GenericPiecesTests, Normal) {
   EXPECT_EQ(1, cp.getCurFetchingPieceIndex());
   EXPECT_EQ(767, cp.getLastByteOffsetOfLastPiece());
   EXPECT_EQ(256, cp.getSizeOfAPiece(1));
-  EXPECT_EQ(252, cp.getRequestedSizeOfAPiece(1));
   EXPECT_EQ(256, cp.getSizeOfAPiece(2));
-  EXPECT_EQ(248, cp.getRequestedSizeOfAPiece(2));
   EXPECT_EQ(512, cp.getTotalSize());
-  EXPECT_EQ(500, cp.getRequestedSize());
   EXPECT_EQ(512, cp.getRemainingBytes());
-  EXPECT_EQ(4, cp.getBytesToTrimAtStart());
-  EXPECT_EQ(8, cp.getBytesToTrimAtEnd());
   cp.updateFetchIndex();
   EXPECT_EQ(256, cp.getRemainingBytes());
 
@@ -78,12 +68,8 @@ TEST(GenericPiecesTests, Normal) {
   EXPECT_EQ(3, cp.getCurFetchingPieceIndex());
   EXPECT_EQ(999, cp.getLastByteOffsetOfLastPiece());
   EXPECT_EQ(232, cp.getSizeOfAPiece(3));
-  EXPECT_EQ(196, cp.getRequestedSizeOfAPiece(3));
   EXPECT_EQ(232, cp.getTotalSize());
-  EXPECT_EQ(196, cp.getRequestedSize());
   EXPECT_EQ(232, cp.getRemainingBytes());
-  EXPECT_EQ(32, cp.getBytesToTrimAtStart());
-  EXPECT_EQ(4, cp.getBytesToTrimAtEnd());
   cp.updateFetchIndex();
   EXPECT_EQ(0, cp.getRemainingBytes());
 
@@ -98,14 +84,9 @@ TEST(GenericPiecesTests, Normal) {
   EXPECT_EQ(1, cp.getCurFetchingPieceIndex());
   EXPECT_EQ(999, cp.getLastByteOffsetOfLastPiece());
   EXPECT_EQ(256, cp.getSizeOfAPiece(1));
-  EXPECT_EQ(112, cp.getRequestedSizeOfAPiece(1));
   EXPECT_EQ(232, cp.getSizeOfAPiece(3));
-  EXPECT_EQ(232, cp.getRequestedSizeOfAPiece(3));
   EXPECT_EQ(744, cp.getTotalSize());
-  EXPECT_EQ(600, cp.getRequestedSize());
   EXPECT_EQ(744, cp.getRemainingBytes());
-  EXPECT_EQ(144, cp.getBytesToTrimAtStart());
-  EXPECT_EQ(0, cp.getBytesToTrimAtEnd());
   cp.updateFetchIndex();
   EXPECT_EQ(488, cp.getRemainingBytes());
 
@@ -120,14 +101,9 @@ TEST(GenericPiecesTests, Normal) {
   EXPECT_EQ(1, cp.getCurFetchingPieceIndex());
   EXPECT_EQ(999, cp.getLastByteOffsetOfLastPiece());
   EXPECT_EQ(256, cp.getSizeOfAPiece(1));
-  EXPECT_EQ(112, cp.getRequestedSizeOfAPiece(1));
   EXPECT_EQ(232, cp.getSizeOfAPiece(3));
-  EXPECT_EQ(232, cp.getRequestedSizeOfAPiece(3));
   EXPECT_EQ(744, cp.getTotalSize());
-  EXPECT_EQ(600, cp.getRequestedSize());
   EXPECT_EQ(744, cp.getRemainingBytes());
-  EXPECT_EQ(144, cp.getBytesToTrimAtStart());
-  EXPECT_EQ(0, cp.getBytesToTrimAtEnd());
   cp.updateFetchIndex();
   EXPECT_EQ(488, cp.getRemainingBytes());
 }