Potentially wrong `orig` references

[quark-zju]

Hi, I'm trying ghstack to send 3 commits. It seems to create the PR3, 4, 5 with the "base" and "head" references just fine. However, the "orig" references used the numbers 1, 2, and 3, instead of the PR numbers 3, 4, 5. Is that expected?

testrepo1 % ghstack --version
ghstack, version 0.9.4

testrepo1 % ghstack
$ git remote get-url origin
$ git cat-file -e HEAD:.github/ghstack_direct
fatal: path '.github/ghstack_direct' does not exist in 'HEAD'
$ git fetch --prune origin '+refs/heads/*:refs/remotes/origin/*'
$ git rev-list --header --topo-order --boundary HEAD '^origin/master'
$ git rev-list --boundary --header --topo-order HEAD 05dbeb054f4cde9b3bfe8b9b380c6a3c2160b8c7 3fc859abbac6fc5871a2349f8cc9b5685cc16eee b515fd9e9103e29b42f63b850fc612912d63a3a3 '^origin/master'
$ git rev-parse --show-toplevel
$ git config --default /home/quark/dotgitrepos/testrepo1/.git/hooks --get core.hooksPath
$ git for-each-ref refs/remotes/origin/gh/quark-zju '--format=%(refname)'
$ git merge-base e3946542e1ad3cd37fcaea3b6c6fffb676e24d6a origin/master
$ git config --get commit.gpgsign
$ git commit-tree -p e3946542e1ad3cd37fcaea3b6c6fffb676e24d6a cfd3fd6051594a97cba96d57848f15b1ba7d3afa
$ git commit-tree -p 49e22077f132151d69c2c66b050d3c0e773039a8 840eba4e7ee90fa7ef99d8582cf599817c23f3b2
$ git push origin 49e22077f132151d69c2c66b050d3c0e773039a8:refs/heads/gh/quark-zju/1/base 3b5a5041daec06ce3b7dd434ef2674e0a9d67db7:refs/heads/gh/quark-zju/1/head
To ssh://github.com/quark-zju/testrepo1.git
 * [new branch]      49e22077f132151d69c2c66b050d3c0e773039a8 -> gh/quark-zju/1/base
 * [new branch]      3b5a5041daec06ce3b7dd434ef2674e0a9d67db7 -> gh/quark-zju/1/head
Opened PR #3
$ git commit-tree -p e3946542e1ad3cd37fcaea3b6c6fffb676e24d6a 840eba4e7ee90fa7ef99d8582cf599817c23f3b2
$ git for-each-ref refs/remotes/origin/gh/quark-zju '--format=%(refname)'
$ git merge-base b515fd9e9103e29b42f63b850fc612912d63a3a3 origin/master
$ git commit-tree -p e3946542e1ad3cd37fcaea3b6c6fffb676e24d6a 840eba4e7ee90fa7ef99d8582cf599817c23f3b2
$ git commit-tree -p 57d61e14677e46443a1314d06326c6290bfc6f76 b4662e9148aa05c1e79d76a809278b959ea227db
$ git push origin 57d61e14677e46443a1314d06326c6290bfc6f76:refs/heads/gh/quark-zju/2/base 7baccee29130f23455e76a97d81d7e02cc22e4f3:refs/heads/gh/quark-zju/2/head
To ssh://github.com/quark-zju/testrepo1.git
 * [new branch]      57d61e14677e46443a1314d06326c6290bfc6f76 -> gh/quark-zju/2/base
 * [new branch]      7baccee29130f23455e76a97d81d7e02cc22e4f3 -> gh/quark-zju/2/head
Opened PR #4
$ git commit-tree -p daa4eeb14b7ed8df6071978eb51435a2973a81e7 b4662e9148aa05c1e79d76a809278b959ea227db
$ git for-each-ref refs/remotes/origin/gh/quark-zju '--format=%(refname)'
$ git merge-base 3fc859abbac6fc5871a2349f8cc9b5685cc16eee origin/master
$ git commit-tree -p e3946542e1ad3cd37fcaea3b6c6fffb676e24d6a b4662e9148aa05c1e79d76a809278b959ea227db
$ git commit-tree -p 6f65d6db97537456ab41882f76374ef9f2ab8584 b77cfca42f81717991a324892f4495f4c095e20a
$ git push origin 6f65d6db97537456ab41882f76374ef9f2ab8584:refs/heads/gh/quark-zju/3/base 8e5f588f4a42e70d5d810d7f05b47f265ad4c26a:refs/heads/gh/quark-zju/3/head
To ssh://github.com/quark-zju/testrepo1.git
 * [new branch]      6f65d6db97537456ab41882f76374ef9f2ab8584 -> gh/quark-zju/3/base
 * [new branch]      8e5f588f4a42e70d5d810d7f05b47f265ad4c26a -> gh/quark-zju/3/head
Opened PR #5
$ git commit-tree -p 7ba0118912e1eabe88d520d7e11b3d48c98e4f57 b77cfca42f81717991a324892f4495f4c095e20a
# Updating https://github.com/quark-zju/testrepo1/pull/3
# Updating https://github.com/quark-zju/testrepo1/pull/4
# Updating https://github.com/quark-zju/testrepo1/pull/5
$ git push origin --force daa4eeb14b7ed8df6071978eb51435a2973a81e7:refs/heads/gh/quark-zju/1/orig 7ba0118912e1eabe88d520d7e11b3d48c98e4f57:refs/heads/gh/quark-zju/2/orig f8e72b9535b7cf81f1af9b7fb4117f1d2b54d24f:refs/heads/gh/quark-zju/3/orig
To ssh://github.com/quark-zju/testrepo1.git
 * [new branch]      daa4eeb14b7ed8df6071978eb51435a2973a81e7 -> gh/quark-zju/1/orig
 * [new branch]      7ba0118912e1eabe88d520d7e11b3d48c98e4f57 -> gh/quark-zju/2/orig
 * [new branch]      f8e72b9535b7cf81f1af9b7fb4117f1d2b54d24f -> gh/quark-zju/3/orig

# Summary of changes (ghstack 0.9.4)

 - Created https://github.com/quark-zju/testrepo1/pull/3
 - Created https://github.com/quark-zju/testrepo1/pull/4
 - Created https://github.com/quark-zju/testrepo1/pull/5

Meta employees can import your changes by running
(on a Meta machine):

    ghimport -s https://github.com/quark-zju/testrepo1/pull/5

If you want to work on this diff stack on another machine:

    ghstack checkout https://github.com/quark-zju/testrepo1/pull/5

[ezyang]

Unfortunately there is no easy way to tell what PR number will be assigned when we are pushing the branches (though I suppose we could see if we could push stub PRs first, and then update them with the right contents 🤔 . I agree it would be nice if the gh numbering matched PR numbering.

[bolinfest]

It's racy, but we do this in Sapling, and tbh, it feels quite a bit nicer...