Skip to content

submit --force doesn't make all pushes force-pushes #272

@swolchok

Description

@swolchok

Through some sort of github user error (probably mine), a bunch of extra commits got added to one of my stacked PRs recently. I couldn't rebase and rerun ghstack --direct because the branches were out of sync. I was baffled as to why --force didn't resolve my issue, but it looks like it does something different? If this is an oversight, it could be fixed by adding force=self.force on

self._git_push(base_push_branches)
and
self._git_push(push_branches)
.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions