From 12c6d5c28b9948e544a808fbeda0754d1e13ed07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20B=20Nagy?= <20251272+BNAndras@users.noreply.github.com> Date: Mon, 5 Jan 2026 17:50:24 -0800 Subject: [PATCH 1/2] Sync `phone-number` tests --- exercises/practice/phone-number/.meta/tests.toml | 10 ++++++++++ exercises/practice/phone-number/PhoneNumberTests.fs | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/exercises/practice/phone-number/.meta/tests.toml b/exercises/practice/phone-number/.meta/tests.toml index ee308c3e5..24dbf07a7 100644 --- a/exercises/practice/phone-number/.meta/tests.toml +++ b/exercises/practice/phone-number/.meta/tests.toml @@ -20,6 +20,11 @@ description = "cleans numbers with multiple spaces" [598d8432-0659-4019-a78b-1c6a73691d21] description = "invalid when 9 digits" +include = false + +[2de74156-f646-42b5-8638-0ef1d8b58bc2] +description = "invalid when 9 digits" +reimplements = "598d8432-0659-4019-a78b-1c6a73691d21" [57061c72-07b5-431f-9766-d97da7c4399d] description = "invalid when 11 digits does not start with a 1" @@ -32,6 +37,11 @@ description = "valid when 11 digits and starting with 1 even with punctuation" [c6a5f007-895a-4fc5-90bc-a7e70f9b5cad] description = "invalid when more than 11 digits" +include = false + +[4a1509b7-8953-4eec-981b-c483358ff531] +description = "invalid when more than 11 digits" +reimplements = "c6a5f007-895a-4fc5-90bc-a7e70f9b5cad" [63f38f37-53f6-4a5f-bd86-e9b404f10a60] description = "invalid with letters" diff --git a/exercises/practice/phone-number/PhoneNumberTests.fs b/exercises/practice/phone-number/PhoneNumberTests.fs index ecc95d89b..a13bb3f43 100644 --- a/exercises/practice/phone-number/PhoneNumberTests.fs +++ b/exercises/practice/phone-number/PhoneNumberTests.fs @@ -22,7 +22,7 @@ let ``Cleans numbers with multiple spaces`` () = [] let ``Invalid when 9 digits`` () = - let expected: Result = Error "incorrect number of digits" + let expected: Result = Error "must not be fewer than 10 digits" clean "123456789" |> should equal expected [] @@ -42,7 +42,7 @@ let ``Valid when 11 digits and starting with 1 even with punctuation`` () = [] let ``Invalid when more than 11 digits`` () = - let expected: Result = Error "more than 11 digits" + let expected: Result = Error "must not be greater than 11 digits" clean "321234567890" |> should equal expected [] From 4762cdcc440d70396752701e0910dd42c129464c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20B=20Nagy?= <20251272+BNAndras@users.noreply.github.com> Date: Mon, 5 Jan 2026 17:59:17 -0800 Subject: [PATCH 2/2] Update error messages --- exercises/practice/phone-number/.meta/Example.fs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/practice/phone-number/.meta/Example.fs b/exercises/practice/phone-number/.meta/Example.fs index 29c54fea4..4952efa59 100644 --- a/exercises/practice/phone-number/.meta/Example.fs +++ b/exercises/practice/phone-number/.meta/Example.fs @@ -12,8 +12,8 @@ let private checkNumberLength (input:string): Result = | 10 -> Ok input | 11 when input.[0] = '1'-> Ok (input.Substring 1) | 11 -> Error "11 digits must start with 1" - | a when a > 11 -> Error "more than 11 digits" - | _ -> Error "incorrect number of digits" + | a when a > 11 -> Error "must not be greater than 11 digits" + | _ -> Error "must not be fewer than 10 digits" let private checkNoneNumericChars (input:string): Result = match input with