Refactor DA retrieval logic into daRetriever struct

Move pending event management and DA processing from Manager to a new
daRetriever type. Update tests and loops to use daRetriever. Remove
blocking waitForHeight logic from store retriever.

Author: julienrbrt

block/manager.go

@@ -164,11 +164,6 @@ type Manager struct {
 	// namespaceMigrationCompleted tracks whether we have completed the migration
 	// from legacy namespace to separate header/data namespaces
 	namespaceMigrationCompleted *atomic.Bool
-
-	// pendingSyncEvents stores height events that are waiting for their prerequisite height
-	pendingSyncEvents map[uint64][]NewHeightEvent
-	// pendingMutex protects access to pendingEvents
-	pendingMutex sync.RWMutex
 }
 
 // getInitialState tries to load lastState from Store, and if it's not available it reads genesis.
@@ -405,7 +400,6 @@ func NewManager(
 		syncNodeSignaturePayloadProvider:   managerOpts.SyncNodeSignatureBytesProvider,
 		validatorHasherProvider:            managerOpts.ValidatorHasherProvider,
 		namespaceMigrationCompleted:        &atomic.Bool{},
-		pendingSyncEvents:                  make(map[uint64][]NewHeightEvent),
 	}
 
 	// initialize da included height

block/namespace_test.go

@@ -137,6 +137,7 @@ func TestProcessNextDAHeaderAndData_MixedResults(t *testing.T) {
 				DataNamespace:   "test-data",
 			}
 			manager, mockDA, _, cancel := setupManagerForNamespaceTest(t, daConfig)
+			daManager := newDARetriever(manager)
 			defer cancel()
 
 			// Mark migration as completed to skip legacy namespace check
@@ -171,7 +172,7 @@ func TestProcessNextDAHeaderAndData_MixedResults(t *testing.T) {
 			}
 
 			ctx := context.Background()
-			err := manager.processNextDAHeaderAndData(ctx)
+			err := daManager.processNextDAHeaderAndData(ctx)
 
 			if tt.expectError {
 				require.Error(t, err, "Expected error but got none")
@@ -241,6 +242,7 @@ func TestNamespaceMigration_Completion(t *testing.T) {
 				DataNamespace:   "test-data",
 			}
 			manager, mockDA, _, cancel := setupManagerForNamespaceTest(t, daConfig)
+			daManager := newDARetriever(manager)
 			defer cancel()
 
 			// Set initial migration state
@@ -314,7 +316,7 @@ func TestNamespaceMigration_Completion(t *testing.T) {
 			// If migration should complete, expect persistence call
 
 			ctx := context.Background()
-			err := manager.processNextDAHeaderAndData(ctx)
+			err := daManager.processNextDAHeaderAndData(ctx)
 
 			require.NoError(t, err, "processNextDAHeaderAndData should not return error")
 
@@ -454,6 +456,7 @@ func TestLegacyNamespaceDetection(t *testing.T) {
 
 			// Test actual behavior in fetchBlobs
 			manager, mockDA, _, cancel := setupManagerForNamespaceTest(t, daConfig)
+			daManager := newDARetriever(manager)
 			defer cancel()
 
 			// Start with migration not completed
@@ -530,7 +533,7 @@ func TestLegacyNamespaceDetection(t *testing.T) {
 			}
 
 			ctx := context.Background()
-			err := manager.processNextDAHeaderAndData(ctx)
+			err := daManager.processNextDAHeaderAndData(ctx)
 
 			// Should succeed with no data found (returns nil on StatusNotFound)
 			require.NoError(t, err)