feedback

Author: julienrbrt

block/internal/syncing/syncer.go

@@ -915,10 +915,9 @@ func (s *Syncer) VerifyForcedInclusionTxs(ctx context.Context, currentState type
 	// were legitimately filtered (e.g., malformed, unparseable, or otherwise invalid).
 	validForcedTxs := forcedIncludedTxsEvent.Txs
 	if len(forcedIncludedTxsEvent.Txs) > 0 {
-		filterStatuses, filterErr := s.exec.FilterTxs(ctx, forcedIncludedTxsEvent.Txs, executionInfo.MaxGas, common.DefaultMaxBlobSize, true)
+		filterStatuses, filterErr := s.exec.FilterTxs(ctx, forcedIncludedTxsEvent.Txs, common.DefaultMaxBlobSize, executionInfo.MaxGas, true)
 		if filterErr != nil {
-			s.logger.Warn().Err(filterErr).Msg("failed to filter forced inclusion txs, checking no txs")
-			validForcedTxs = [][]byte{}
+			return fmt.Errorf("failed to filter forced inclusion txs: %w", filterErr)
 		} else {
 			validForcedTxs = make([][]byte, 0, len(forcedIncludedTxsEvent.Txs))
 			for i, status := range filterStatuses {

block/internal/syncing/syncer_forced_inclusion_test.go

@@ -27,6 +27,7 @@ import (
 // setupFilterTxsMock sets up the FilterTxs mock to return FilterOK for all transactions.
 // This is the default behavior for tests that don't specifically test filtering.
 func setupFilterTxsMock(mockExec *testmocks.MockExecutor) {
+	mockExec.On("GetExecutionInfo", mock.Anything).Return(execution.ExecutionInfo{MaxGas: 1000000}, nil).Maybe()
 	mockExec.On("FilterTxs", mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(
 		func(ctx context.Context, txs [][]byte, maxBytes, maxGas uint64, hasForceIncludedTransaction bool) []execution.FilterStatus {
 			result := make([]execution.FilterStatus, len(txs))