add validate to config

Author: tac0turtle

apps/testapp/cmd/init_test.go

@@ -43,7 +43,7 @@ func TestInitCommand(t *testing.T) {
 	rollconf.AddGlobalFlags(cmd, "testapp")
 
 	// Set home flag to the test directory
-	cmd.SetArgs([]string{"init", "--home", dir, "--rollkit.node.aggregator", "--rollkit.signer.passphrase", "test"})
+	cmd.SetArgs([]string{"init", "--home", dir, "--rollkit.node.aggregator", "--rollkit.signer.passphrase", "test", "--chain_id", "ev-1"})
 
 	// Execute the command
 	err = cmd.Execute()

block/namespace_test.go

@@ -225,15 +225,15 @@ func TestLegacyNamespaceDetection(t *testing.T) {
 			if tt.namespace != "" {
 				assert.Equal(t, tt.namespace, headerNS)
 			} else {
-				assert.Equal(t, "rollkit-headers", headerNS) // Default
+				assert.Equal(t, "", headerNS) // Default
 			}
 
 			if tt.dataNamespace != "" {
 				assert.Equal(t, tt.dataNamespace, dataNS)
 			} else if tt.namespace != "" {
 				assert.Equal(t, tt.namespace, dataNS)
 			} else {
-				assert.Equal(t, "rollkit-headers", dataNS) // Falls back to default namespace
+				assert.Equal(t, "", dataNS) // Falls back to default namespace
 			}
 
 			// Test actual behavior in fetchBlobs

pkg/cmd/p2p_test.go

@@ -96,6 +96,7 @@ func TestNetInfoCmd_Success(t *testing.T) {
 	rootCmd := &cobra.Command{Use: "root"}
 	rootCmd.PersistentFlags().String(config.FlagRootDir, tempDir, "Root directory for config and data")
 	rootCmd.PersistentFlags().String(config.FlagRPCAddress, rpcAddr, "RPC listen address")
+	rootCmd.PersistentFlags().String(config.FlagDANamespace, "ev-namespace", "DA Namespace")
 
 	err = v.BindPFlag(config.FlagRootDir, rootCmd.PersistentFlags().Lookup(config.FlagRootDir))
 	require.NoError(err)
@@ -174,6 +175,7 @@ func TestNetInfoCmd_NoPeers(t *testing.T) {
 	rootCmd := &cobra.Command{Use: "root"}
 	rootCmd.PersistentFlags().String(config.FlagRootDir, tempDir, "Root directory for config and data")
 	rootCmd.PersistentFlags().String(config.FlagRPCAddress, rpcAddr, "RPC listen address")
+	rootCmd.PersistentFlags().String(config.FlagDANamespace, "ev-namespace", "DA Namespace")
 
 	err = v.BindPFlag(config.FlagRootDir, rootCmd.PersistentFlags().Lookup(config.FlagRootDir))
 	require.NoError(err)

pkg/cmd/run_node.go

@@ -36,6 +36,10 @@ func ParseConfig(cmd *cobra.Command) (rollconf.Config, error) {
 		return rollconf.Config{}, fmt.Errorf("failed to validate node config: %w", err)
 	}
 
+	if nodeConfig.DA.Namespace == "" {
+		return rollconf.Config{}, errors.New("namespace cannot be empty")
+	}
+
 	return nodeConfig, nil
 }
 

pkg/cmd/run_node_test.go

@@ -159,7 +159,7 @@ func TestAggregatorFlagInvariants(t *testing.T) {
 	validValues := []bool{false, true, true}
 
 	for i, flags := range flagVariants {
-		args := append([]string{"start"}, flags...)
+		args := append([]string{"start", "--evnode.da.namespace=ev-namespace"}, flags...)
 
 		executor, sequencer, dac, keyProvider, p2pClient, ds, stopDAHeightTicker := createTestComponents(context.Background(), t)
 		defer stopDAHeightTicker()
@@ -209,9 +209,9 @@ func TestDefaultAggregatorValue(t *testing.T) {
 			// Create a new command without specifying any flags
 			var args []string
 			if tc.expected {
-				args = []string{"start", "--rollkit.node.aggregator"}
+				args = []string{"start", "--evnode.node.aggregator", "--evnode.da.namespace=ev-namespace"}
 			} else {
-				args = []string{"start", "--rollkit.node.aggregator=false"}
+				args = []string{"start", "--evnode.da.namespace=ev-namespace"}
 			}
 
 			if err := newRunNodeCmd.ParseFlags(args); err != nil {
@@ -277,6 +277,7 @@ func TestCentralizedAddresses(t *testing.T) {
 	args := []string{
 		"start",
 		"--rollkit.da.address=http://central-da:26657",
+		"--rollkit.da.namespace=ev-namespace",
 	}
 
 	executor, sequencer, dac, keyProvider, p2pClient, ds, stopDAHeightTicker := createTestComponents(context.Background(), t)

pkg/cmd/store_test.go

@@ -7,6 +7,7 @@ import (
 	"path/filepath"
 	"testing"
 
+	"github.com/evstack/ev-node/pkg/config"
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/require"
 )
@@ -60,7 +61,8 @@ func TestStoreUnsafeCleanCmd(t *testing.T) {
 
 	// Create a root command and add the subcommand
 	rootCmd := &cobra.Command{Use: "root"}
-	rootCmd.PersistentFlags().String("home", tempDir, "root directory")
+	rootCmd.PersistentFlags().String(config.FlagRootDir, tempDir, "root directory")
+	rootCmd.PersistentFlags().String(config.FlagDANamespace, "ev-namespace", "DA Namespace")
 	rootCmd.AddCommand(StoreUnsafeCleanCmd)
 
 	// Capture output

pkg/config/config.go

@@ -168,7 +168,7 @@ func (d *DAConfig) GetNamespace() string {
 	if d.Namespace != "" {
 		return d.Namespace
 	}
-	return "rollkit-headers" // Default value
+	return "" // Default value is empty string
 }
 
 // GetDataNamespace returns the namespace for data submissions, falling back to the header namespace if not set
@@ -227,7 +227,7 @@ type RPCConfig struct {
 // It creates the directory if it does not exist.
 func (c *Config) Validate() error {
 	if c.RootDir == "" {
-		return fmt.Errorf("root directory cannot be empty")
+		return errors.New("root directory cannot be empty")
 	}
 
 	fullDir := filepath.Dir(c.ConfigPath())

pkg/config/config_test.go

@@ -27,7 +27,7 @@ func TestDefaultConfig(t *testing.T) {
 	assert.Equal(t, float64(-1), def.DA.GasPrice)
 	assert.Equal(t, float64(0), def.DA.GasMultiplier)
 	assert.Equal(t, "", def.DA.SubmitOptions)
-	assert.Equal(t, "rollkit-headers", def.DA.Namespace)
+	assert.Equal(t, "", def.DA.Namespace)
 	assert.Equal(t, 1*time.Second, def.Node.BlockTime.Duration)
 	assert.Equal(t, 6*time.Second, def.DA.BlockTime.Duration)
 	assert.Equal(t, uint64(0), def.DA.StartHeight)
@@ -300,10 +300,10 @@ func TestDAConfig_GetDataNamespace(t *testing.T) {
 			expectedNamespace: "namespace",
 		},
 		{
-			name:              "Both empty, use default value from default namespace",
+			name:              "Both empty, return empty string",
 			dataNamespace:     "",
 			defaultNamespace:  "",
-			expectedNamespace: "rollkit-headers",
+			expectedNamespace: "",
 		},
 	}