Skip to content

Commit 91a747b

Browse files
committed
address comments
1 parent 74db296 commit 91a747b

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

apps/evm/single/cmd/init.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ func InitCmd() *cobra.Command {
8888
// Add flags to the command
8989
rollconf.AddFlags(initCmd)
9090
initCmd.Flags().String(rollgenesis.ChainIDFlag, "", "chain ID must be set. It is used in the genesis file and to identify the network (examples: ev-1. xo-1)")
91+
InitCmd().MarkFlagsOneRequired(rollgenesis.ChainIDFlag)
9192

9293
return initCmd
9394
}

apps/testapp/cmd/init.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ func InitCmd() *cobra.Command {
8989
// Add flags to the command
9090
rollconf.AddFlags(initCmd)
9191
initCmd.Flags().String(rollgenesis.ChainIDFlag, "", "chain ID must be set. It is used in the genesis file and to identify the network (examples: ev-1. xo-1)")
92+
InitCmd().MarkFlagsOneRequired(rollgenesis.ChainIDFlag)
9293

9394
return initCmd
9495
}

block/namespace_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ func TestLegacyNamespaceDetection(t *testing.T) {
233233
} else if tt.namespace != "" {
234234
assert.Equal(t, tt.namespace, dataNS)
235235
} else {
236-
assert.Equal(t, "", dataNS) // Falls back to default namespace
236+
assert.Equal(t, "", dataNS)
237237
}
238238

239239
// Test actual behavior in fetchBlobs

test/e2e/evm_test_common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ func setupFullNode(t *testing.T, sut *SystemUnderTest, fullNodeHome, sequencerHo
444444
"init",
445445
"--home", fullNodeHome,
446446
"--evnode.da.namespace", namespace,
447-
"--evnode.chain_id", chainID,
447+
"--chain_id", chainID,
448448
)
449449
require.NoError(t, err, "failed to init full node", output)
450450

0 commit comments

Comments
 (0)