docs: update CHANGELOG with enhancements to health and readiness checks, including E2E test updates

Author: randygrok

CHANGELOG.md

@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Use cache instead of in memory store for reaper. Persist cache on reload. Autoclean after 24 hours. ([#2811](https://github.com/evstack/ev-node/pull/2811))
 - Simplified `/health/live` endpoint to only check store accessibility (liveness) instead of business logic, following Kubernetes best practices ([#2800](https://github.com/evstack/ev-node/pull/2800))
 - Updated `/health/ready` endpoint to use `GetState()` instead of `Height()` to access block production timing information ([#2800](https://github.com/evstack/ev-node/pull/2800))
+- Updated E2E test helper `AwaitNodeUp()` to check both liveness and readiness endpoints, ensuring nodes are not just alive but ready to serve traffic ([#2800](https://github.com/evstack/ev-node/pull/2800))
 - Renamed integration test from `TestHealthEndpointWhenBlockProductionStops` to `TestReadinessEndpointWhenBlockProductionStops` to correctly test readiness endpoint ([#2800](https://github.com/evstack/ev-node/pull/2800))
 - Updated Rust client example (`client/crates/client/examples/basic.rs`) to demonstrate both liveness and readiness checks ([#2800](https://github.com/evstack/ev-node/pull/2800))
 

node/single_sequencer_integration_test.go

@@ -16,6 +16,7 @@ import (
 	coreda "github.com/evstack/ev-node/core/da"
 	coreexecutor "github.com/evstack/ev-node/core/execution"
 	evconfig "github.com/evstack/ev-node/pkg/config"
+	"github.com/evstack/ev-node/pkg/rpc/client"
 )
 
 // FullNodeTestSuite is a test suite for full node integration tests
@@ -451,7 +452,7 @@ func TestReadinessEndpointWhenBlockProductionStops(t *testing.T) {
 	// Verify readiness is READY while blocks are being produced
 	readiness, err := rpcClient.GetReadiness(ctx)
 	require.NoError(err)
-	require.Equal("READY", readiness.String(), "Readiness should be READY while producing blocks")
+	require.Equal(client.ReadinessStatus_READY, readiness, "Readiness should be READY while producing blocks")
 
 	// Wait for block production to stop (when MaxPendingHeadersAndData is reached)
 	time.Sleep(time.Duration(config.Node.MaxPendingHeadersAndData+2) * config.Node.BlockTime.Duration)
@@ -473,7 +474,7 @@ func TestReadinessEndpointWhenBlockProductionStops(t *testing.T) {
 		if err != nil {
 			return false
 		}
-		return readiness.String() == "UNREADY"
+		return readiness == client.ReadinessStatus_UNREADY
 	}, 10*time.Second, 100*time.Millisecond, "Readiness should be UNREADY after aggregator stops producing blocks (5x block time)")
 
 	// Stop the node and wait for shutdown

pkg/rpc/client/client_test.go

@@ -284,7 +284,7 @@ func TestClientGetHealth(t *testing.T) {
 		healthStatus, err := client.GetHealth(context.Background())
 
 		require.NoError(t, err)
-		require.Equal(t, "PASS", healthStatus.String())
+		require.Equal(t, HealthStatus_PASS, healthStatus)
 		mockStore.AssertExpectations(t)
 	})
 
@@ -301,7 +301,7 @@ func TestClientGetHealth(t *testing.T) {
 		healthStatus, err := client.GetHealth(context.Background())
 
 		require.NoError(t, err)
-		require.Equal(t, "FAIL", healthStatus.String())
+		require.Equal(t, HealthStatus_FAIL, healthStatus)
 		mockStore.AssertExpectations(t)
 	})
 
@@ -318,7 +318,7 @@ func TestClientGetHealth(t *testing.T) {
 		healthStatus, err := client.GetHealth(context.Background())
 
 		require.NoError(t, err)
-		require.Equal(t, "PASS", healthStatus.String())
+		require.Equal(t, HealthStatus_PASS, healthStatus)
 		mockStore.AssertExpectations(t)
 	})
 }
@@ -352,7 +352,7 @@ func TestClientGetReadiness(t *testing.T) {
 		readiness, err := client.GetReadiness(context.Background())
 
 		require.NoError(t, err)
-		require.Equal(t, "READY", readiness.String())
+		require.Equal(t, ReadinessStatus_READY, readiness)
 		mockStore.AssertExpectations(t)
 		mockP2P.AssertExpectations(t)
 	})
@@ -373,7 +373,7 @@ func TestClientGetReadiness(t *testing.T) {
 		readiness, err := client.GetReadiness(context.Background())
 
 		require.NoError(t, err)
-		require.Equal(t, "UNREADY", readiness.String())
+		require.Equal(t, ReadinessStatus_UNREADY, readiness)
 		mockP2P.AssertExpectations(t)
 	})
 
@@ -397,7 +397,7 @@ func TestClientGetReadiness(t *testing.T) {
 		readiness, err := client.GetReadiness(context.Background())
 
 		require.NoError(t, err)
-		require.Equal(t, "UNREADY", readiness.String())
+		require.Equal(t, ReadinessStatus_UNREADY, readiness)
 		mockP2P.AssertExpectations(t)
 	})
 }

test/e2e/sut_helper.go

@@ -93,7 +93,8 @@ func (s *SystemUnderTest) ExecCmd(cmd string, args ...string) {
 	s.awaitProcessCleanup(c)
 }
 
-// AwaitNodeUp waits until a node is operational by validating it produces blocks.
+// AwaitNodeUp waits until a node is operational by checking both liveness and readiness.
+// This verifies the process is alive (liveness) and ready to serve traffic (readiness).
 func (s *SystemUnderTest) AwaitNodeUp(t *testing.T, rpcAddr string, timeout time.Duration) {
 	t.Helper()
 	t.Logf("Await node is up: %s", rpcAddr)
@@ -102,8 +103,15 @@ func (s *SystemUnderTest) AwaitNodeUp(t *testing.T, rpcAddr string, timeout time
 	require.EventuallyWithT(t, func(t *assert.CollectT) {
 		c := client.NewClient(rpcAddr)
 		require.NotNil(t, c)
+
+		// Check liveness: is the process alive?
 		_, err := c.GetHealth(ctx)
-		require.NoError(t, err)
+		require.NoError(t, err, "liveness check failed")
+
+		// Check readiness: is the node ready to serve traffic?
+		readiness, err := c.GetReadiness(ctx)
+		require.NoError(t, err, "readiness check failed")
+		require.Equal(t, client.ReadinessStatus_READY, readiness, "node is not ready")
 	}, timeout, min(timeout/10, 200*time.Millisecond), "node is not up")
 }