Missing rule: ember/template-no-negated-condition

[tcjr]

I have been trying out the pre-release of all the new rules for a switch from ember-template-lint. I noticed there are two rules in ember-template-lint's recommend config that are not in this repo. For one of them, template-no-partial, the absence makes sense since partials a thing of the distant past and have no reason to exist in GTS/GJS. But the other rule, template-no-negated-condition is missing, but should probably be here. It's listed in the prepare release PR (#2369) and was ported in #2483 but now it appears to have been lost in the shuffle.

https://github.com/NullVoxPopuli/eslint-plugin-ember/blob/master/docs/rules/template-no-negated-condition.md

[NullVoxPopuli]

It's kind of a duplicate of https://github.com/ember-cli/eslint-plugin-ember/blob/master/lib/rules/template-no-negated-comparison.js

[tcjr]

That other rule is much more limited. I'm not a fan of the rule anyway, so removing it from the recommended config works for me! I didn't realize it was deliberately excluded.

[tcjr]

It's kind of a duplicate of https://github.com/ember-cli/eslint-plugin-ember/blob/master/lib/rules/template-no-negated-comparison.js

The "missing" ETL rule would flag this:

{{#if (not (eq c1 c2))}}<img>{{/if}}

The fix for it would be:

{{#if (not-eq c1 c2)}}<img>{{/if}}

However, the template-no-negated-comparison rule would flag this fixed code as invalid and instead recommend this:

{{#unless (eq c1 c2)}}<img>{{/unless}}

Personally, I'm not a fan of using unless/eq, so I'm glad this rule is not recommended.

[NullVoxPopuli]

currently none of the rules are recommended as we haven't made a recommended config for them yet -- as before with eslint rules (and also template-rules), a bunch of rules exist for various people's preferences, etc.

since no-negated-condition isn't a duplicate (and I messd up in identifying it as one), I would also be happy to receive a PR implementing it.

as for recommended rules, I'll need to write up an RFC proposing a new set / defaults

[tcjr]

The least friction for moving from an app that currently uses ember-template-lint is to turn on all the new eslint rules that were in the "recommended" config for ember-template-lint. That's how I've been trying it out on a few of my projects and it works great. Thanks for all the work you've done converting all these rules to eslint.

[tcjr]

since no-negated-condition isn't a duplicate (and I messd up in identifying it as one), I would also be happy to receive a PR implementing it.

But there already was a PR for it. That's what this is, right?
#2483

[NullVoxPopuli]

perhaps! does that rule do what you want?

if so, I can re-open and get it merged.

as for doing what ember-template-lint did, we'll need an "hbs-recommended" set of rules or something similar -- I'm not quite sure how to phrase it yet

[tcjr]

It's not that I want that rule -- it's just that it is the only rule in the recommended list that is not available in eslint. I assumed it was accidentally left out. Then I thought it was deliberately removed. Now I don't know.

For testing the eslint versions of all the template rules, I'm using this file that I import and spread into the existing eslint config.

/**
 * New and updated rules for eslint-plugin-ember v13.x.
 * This config targets the massive influx of template-tag (GJS/GTS) rules
 * ported from ember-template-lint.
 *
 * See: https://github.com/ember-cli/eslint-plugin-ember/pull/2369
 *
 * This is the list of rules that are currently in ember-template-lint's
 * recommended rule set, with these exceptions:
 *
 * - ember/template-no-negated-condition    // missing in eslint-plugin-ember
 * - ember/template-no-partial              // missing; not required anymore?
 * - ember/template-no-implicit-this        // HBS-only
 */
export const recommendedETLRules = {
  "ember/template-builtin-component-arguments": "error",
  "ember/template-deprecated-inline-view-helper": "error",
  "ember/template-deprecated-render-helper": "error",
  "ember/template-link-href-attributes": "error",
  "ember/template-link-rel-noopener": "error",
  "ember/template-no-abstract-roles": "error",
  "ember/template-no-accesskey-attribute": "error",
  "ember/template-no-action": "error",
  "ember/template-no-action-on-submit-button": "error",
  "ember/template-no-args-paths": "error",
  "ember/template-no-arguments-for-html-elements": "error",
  "ember/template-no-aria-hidden-body": "error",
  "ember/template-no-aria-unsupported-elements": "error",
  "ember/template-no-array-prototype-extensions": "error",
  "ember/template-no-at-ember-render-modifiers": "error",
  "ember/template-no-attrs-in-components": "error",
  "ember/template-no-autofocus-attribute": "error",
  "ember/template-no-block-params-for-html-elements": "error",
  "ember/template-no-builtin-form-components": "error",
  "ember/template-no-capital-arguments": "error",
  "ember/template-no-class-bindings": "error",
  "ember/template-no-curly-component-invocation": "error",
  "ember/template-no-debugger": "error",
  "ember/template-no-duplicate-attributes": "error",
  "ember/template-no-duplicate-id": "error",
  "ember/template-no-duplicate-landmark-elements": "error",
  "ember/template-no-empty-headings": "error",
  "ember/template-no-extra-mut-helper-argument": "error",
  "ember/template-no-forbidden-elements": "error",
  "ember/template-no-heading-inside-button": "error",
  "ember/template-no-html-comments": "error",
  "ember/template-no-index-component-invocation": "error",
  "ember/template-no-inline-styles": "error",
  "ember/template-no-input-block": "error",
  "ember/template-no-input-tagname": "error",
  "ember/template-no-invalid-aria-attributes": "error",
  "ember/template-no-invalid-interactive": "error",
  "ember/template-no-invalid-link-text": "error",
  "ember/template-no-invalid-link-title": "error",
  "ember/template-no-invalid-meta": "error",
  "ember/template-no-invalid-role": "error",
  "ember/template-no-link-to-positional-params": "error",
  "ember/template-no-link-to-tagname": "error",
  "ember/template-no-log": "error",
  "ember/template-no-nested-interactive": "error",
  "ember/template-no-nested-landmark": "error",
  "ember/template-no-nested-splattributes": "error",
  "ember/template-no-obscure-array-access": "error",
  "ember/template-no-obsolete-elements": "error",
  "ember/template-no-outlet-outside-routes": "error",
  "ember/template-no-passed-in-event-handlers": "error",
  "ember/template-no-pointer-down-event-binding": "error",
  "ember/template-no-positional-data-test-selectors": "error",
  "ember/template-no-positive-tabindex": "error",
  "ember/template-no-potential-path-strings": "error",
  "ember/template-no-quoteless-attributes": "error",
  "ember/template-no-redundant-fn": "error",
  "ember/template-no-redundant-role": "error",
  "ember/template-no-route-action": "error",
  "ember/template-no-scope-outside-table-headings": "error",
  "ember/template-no-shadowed-elements": "error",
  "ember/template-no-triple-curlies": "error",
  "ember/template-no-unbalanced-curlies": "error",
  "ember/template-no-unbound": "error",
  "ember/template-no-unknown-arguments-for-builtin-components": "error",
  "ember/template-no-unnecessary-component-helper": "error",
  "ember/template-no-unnecessary-curly-parens": "error",
  "ember/template-no-unnecessary-curly-strings": "error",
  "ember/template-no-unsupported-role-attributes": "error",
  "ember/template-no-unused-block-params": "error",
  "ember/template-no-valueless-arguments": "error",
  "ember/template-no-whitespace-for-layout": "error",
  "ember/template-no-whitespace-within-word": "error",
  "ember/template-no-with": "error",
  "ember/template-no-yield-only": "error",
  "ember/template-no-yield-to-default": "error",
  "ember/template-require-aria-activedescendant-tabindex": "error",
  "ember/template-require-button-type": "error",
  "ember/template-require-context-role": "error",
  "ember/template-require-has-block-helper": "error",
  "ember/template-require-iframe-title": "error",
  "ember/template-require-input-label": "error",
  "ember/template-require-lang-attribute": "error",
  "ember/template-require-mandatory-role-attributes": "error",
  "ember/template-require-media-caption": "error",
  "ember/template-require-presentational-children": "error",
  "ember/template-require-valid-alt-text": "error",
  "ember/template-require-valid-named-block-naming-format": "error",
  "ember/template-simple-modifiers": "error",
  "ember/template-simple-unless": "error",
  "ember/template-splat-attributes-only": "error",
  "ember/template-style-concatenation": "error",
  "ember/template-table-groups": "error",
};

/**
 * Exhaustive list of new and updated rules for eslint-plugin-ember v13.x.
 * This list contains everything in the recommended set PLUS all the rest of the
 * newly ported template rules.
 */
export const allETLRules = {
  ...recommendedETLRules,
  "ember/template-attribute-indentation": "error",
  "ember/template-attribute-order": "error",
  "ember/template-block-indentation": "error",
  "ember/template-eol-last": "error",
  "ember/template-linebreak-style": "error",
  "ember/template-modifier-name-case": "error",
  "ember/template-no-action-modifiers": "error",
  "ember/template-no-bare-strings": "error",
  "ember/template-no-bare-yield": "error",
  "ember/template-no-chained-this": "error",
  "ember/template-no-deprecated": "error",
  "ember/template-no-dynamic-subexpression-invocations": "error",
  "ember/template-no-element-event-actions": "error",
  "ember/template-no-implicit-this": "error",
  "ember/template-no-inline-event-handlers": "error",
  "ember/template-no-inline-linkto": "error",
  "ember/template-no-jsx-attributes": "error",
  "ember/template-no-model-argument-in-route-templates": "error",
  "ember/template-no-multiple-empty-lines": "error",
  "ember/template-no-mut-helper": "error",
  "ember/template-no-negated-comparison": "error",
  "ember/template-no-only-default-slot": "error",
  "ember/template-no-page-title-component": "error",
  "ember/template-no-restricted-invocations": "error",
  "ember/template-no-splattributes-with-class": "error",
  "ember/template-no-this-in-template-only-components": "error",
  "ember/template-no-trailing-spaces": "error",
  "ember/template-no-unavailable-this": "error",
  "ember/template-no-unnecessary-concat": "error",
  "ember/template-no-yield-block-params-to-else-inverse": "error",
  "ember/template-quotes": "error",
  "ember/template-require-each-key": "error",
  "ember/template-require-form-method": "error",
  "ember/template-require-iframe-src-attribute": "error",
  "ember/template-require-splattributes": "error",
  "ember/template-require-strict-mode": "error",
  "ember/template-require-valid-form-groups": "error",
  "ember/template-self-closing-void-elements": "error",
  "ember/template-sort-invocations": "error",
  "ember/template-template-length": "error",
};

[tcjr]

Nice, the rule was restored in #2708
Thanks, @johanrd!