MD -> Heex == escaping issues?

[evantravers]

Hey gang! I've got a bunch of .md files, which I think the MDex converter picks up by default in Tableau. I recently converted my EEx layout for HEEx because want the component system. All the HEEx pages render correctly inside the HEEx layout, but any .md file show up as escaped HTML.

I was trying to follow the https://github.com/mhanberg/tableau_demo_heex/blob/main/lib/tableau_demo_heex.ex example.

Instead of doing render(@inner_content) I could do something like:

defp inner_html(assigns) do
  case render(assigns.inner_content) do
    html when is_binary(html) -> Phoenix.HTML.raw(html)
    other -> other
  end
end

But it feels like that is a bit of an antipattern reflecting that I don't understand the pipeline fully.

[evantravers]

Spent my last tokens in Claude… and I ended up making a custom converter wrapping Tableau.MDExConverter:

defmodule Travers.MDExConverter do
  def convert(filepath, front_matter, body, assigns) do
    Tableau.MDExConverter.convert(filepath, front_matter, body, assigns)
    |> Phoenix.HTML.raw()
  end
end

This wraps the String.t() returned by MDExConverter in {:safe, string} so that heex won't escape it. It feels like a better solution than what I had.

[mhanberg]

Do your layouts call this function?

https://github.com/elixir-tools/tableau_new/blob/d3952f289d6c94d80ba9d71d99ec223d02396bae/priv/templates/heex/lib/layouts/root_layout.ex#L37

[evantravers]

Yes, it does.

[mhanberg]

What version of mdex are you using?

[evantravers]

0.11.6

Thanks for glancing at this @mhanberg!

[evantravers]

Yeah… my converter causes problems when I branched out into the Tableau.RSSExtension, because now RSSExtension is getting {:safe, <string>} which it doesn't expect.

[mhanberg]

I still need to look into this deeper, I can't tell if this is a regression from a library changing or if this has never worked and I didn't notice because I don't use HEEx.

[evantravers]

Lemme add you to my repo so you can play with it.

[evantravers]

So I downloaded the https://github.com/mhanberg/tableau_demo_heex/blob/main/lib/tableau_demo_heex.ex, added a PageExtension, added a test.md page, and it does the same behavior. Should I raise this to a issue and start working on it?

[evantravers]

I should say that I left it at the original commit, I didn't update any deps.