From 627e6ce4fe1441e44a35b1f887de54a30c8be71c Mon Sep 17 00:00:00 2001 From: Simon Hohl Date: Wed, 11 Feb 2026 10:09:14 +0100 Subject: [PATCH 1/4] Add another example to `Integer.parse/1` "Remainder" does not mean the mathematical definition of the term. --- lib/elixir/lib/integer.ex | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/elixir/lib/integer.ex b/lib/elixir/lib/integer.ex index 25b658cd546..6d58983ddab 100644 --- a/lib/elixir/lib/integer.ex +++ b/lib/elixir/lib/integer.ex @@ -289,6 +289,9 @@ defmodule Integer do iex> Integer.parse("three") :error + iex> Integer.parse("37 war elephants") + {37, " war elephants"} + iex> Integer.parse("34", 10) {34, ""} From 754e90ee885b6e4c2d12a7b1e702c57d4bcc2546 Mon Sep 17 00:00:00 2001 From: Simon Hohl Date: Wed, 11 Feb 2026 20:45:06 +0100 Subject: [PATCH 2/4] Remove term remainder from `Integer.parse/1` The term has a mathematical definition, which does not apply here and might be confusing. --- lib/elixir/lib/integer.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/elixir/lib/integer.ex b/lib/elixir/lib/integer.ex index 6d58983ddab..27334fe81fc 100644 --- a/lib/elixir/lib/integer.ex +++ b/lib/elixir/lib/integer.ex @@ -270,7 +270,7 @@ defmodule Integer do An optional `base` to the corresponding integer can be provided. If `base` is not given, 10 will be used. - If successful, returns a tuple in the form of `{integer, remainder_of_binary}`. + If successful, returns a tuple in the form of `{integer, remaining_part_of_binary}`. Otherwise `:error`. Raises an error if `base` is less than 2 or more than 36. From bebf3be44a8bd18846fb982438ad7d13c287e303 Mon Sep 17 00:00:00 2001 From: Simon Hohl Date: Thu, 12 Feb 2026 07:09:34 +0100 Subject: [PATCH 3/4] Update lib/elixir/lib/integer.ex Co-authored-by: Dave Lucia --- lib/elixir/lib/integer.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/elixir/lib/integer.ex b/lib/elixir/lib/integer.ex index 27334fe81fc..fe23b96e448 100644 --- a/lib/elixir/lib/integer.ex +++ b/lib/elixir/lib/integer.ex @@ -270,7 +270,7 @@ defmodule Integer do An optional `base` to the corresponding integer can be provided. If `base` is not given, 10 will be used. - If successful, returns a tuple in the form of `{integer, remaining_part_of_binary}`. + If successful, returns a tuple in the form of `{integer, remaining_string}`. Otherwise `:error`. Raises an error if `base` is less than 2 or more than 36. From 286bf0206a049abe7be949387a111747f9ea824d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Thu, 12 Feb 2026 14:53:31 +0100 Subject: [PATCH 4/4] Apply suggestions from code review --- lib/elixir/lib/integer.ex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/elixir/lib/integer.ex b/lib/elixir/lib/integer.ex index fe23b96e448..67787faa1de 100644 --- a/lib/elixir/lib/integer.ex +++ b/lib/elixir/lib/integer.ex @@ -289,8 +289,8 @@ defmodule Integer do iex> Integer.parse("three") :error - iex> Integer.parse("37 war elephants") - {37, " war elephants"} + iex> Integer.parse("404 not found") + {404, " not found"} iex> Integer.parse("34", 10) {34, ""}