Optimize

Author: duy.tran.yb

tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/xychart/linechart/TmfCommonXLineChartTooltipProvider.java

@@ -23,16 +23,14 @@
 import org.eclipse.swt.graphics.Point;
 import org.eclipse.swt.graphics.RGBA;
 import org.eclipse.swt.widgets.Control;
-import org.eclipse.tracecompass.internal.tmf.ui.Messages;
 import org.eclipse.tracecompass.tmf.core.presentation.RGBAColor;
-import org.eclipse.tracecompass.tmf.core.timestamp.ITmfTimestamp;
-import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestamp;
 import org.eclipse.tracecompass.tmf.ui.viewers.TmfAbstractToolTipHandler;
 import org.eclipse.tracecompass.tmf.ui.viewers.TmfAbstractToolTipHandler.ToolTipString;
 import org.eclipse.tracecompass.tmf.ui.viewers.xychart.IAxis;
 import org.eclipse.tracecompass.tmf.ui.viewers.xychart.ITmfChartTimeProvider;
 import org.eclipse.tracecompass.tmf.ui.viewers.xychart.IXYSeries;
 import org.eclipse.tracecompass.tmf.ui.viewers.xychart.TmfBaseProvider;
+import org.eclipse.tracecompass.tmf.ui.viewers.xychart.linechart.TmfCommonXAxisChartViewer;
 
 /**
  * Displays a tooltip on line charts. For each series, it shows the y value at
@@ -81,10 +79,7 @@ protected int getHoveredIndex(List<IXYSeries> series, double xCoordinate) {
             return -1;
         }
         double[] xSeries = series.get(0).getXSeries();
-        if (xSeries == null) {
-            return -1;
-        }
-        if (xSeries.length == 0) {
+        if ((xSeries == null) || (xSeries.length == 0)) {
             return -1;
         }
         int index = Arrays.binarySearch(xSeries, xCoordinate);
@@ -101,12 +96,7 @@ protected void addAdditionalTooltipItems(double xCoordinate, String seriesKey) {
         // Default: no-op
     }
 
-    protected void addSeriesTooltipItem(
-            IXYSeries series,
-            String key,
-            int index,
-            Format format) {
-
+    protected void addSeriesTooltipItem(IXYSeries series, String key, int index, Format format) {
         double[] ySeries = series.getYSeries();
         if (ySeries == null || index < 0 || index >= ySeries.length) {
             return;
@@ -121,16 +111,13 @@ protected void addSeriesTooltipItem(
         }
     }
 
-    protected String formatSeriesLabel(
-            IXYSeries series,
-            String key) {
-
+    protected String formatSeriesLabel(IXYSeries series, String key) {
         String label = (key == null) ? "" : key; //$NON-NLS-1$
         Color color = series.getColor();
         if (color != null) {
             RGBA rgba = color.getRGBA();
             RGBAColor rgbaColor = new RGBAColor(rgba.rgb.red, rgba.rgb.green, rgba.rgb.blue, rgba.alpha);
-            label = String.format(HTML_COLOR_TOOLTIP, rgbaColor, label);
+            label = String.format(TmfCommonXLineChartTooltipProvider.HTML_COLOR_TOOLTIP, rgbaColor, label);
         }
         return label;
     }