[1747] Automatically select more newly created elements

Bug: #1747
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

Author: pcdavid

CHANGELOG.adoc

@@ -46,6 +46,7 @@ This fix ensure that imported models containing, for example, a top-level `Libra
 - https://github.com/eclipse-syson/syson/issues/1565[#1565] Provide a way to duplicate semantic element in the _Explorer_ view.
 - https://github.com/eclipse-syson/syson/issues/1737[#1737] [diagrams] Add creation tools to InterconnectionCompartmentNode
 - https://github.com/eclipse-syson/syson/issues/1395[#1395] Provide a way to duplicate a semantic element ans its representation node in the _General View_ diagram.
+- https://github.com/eclipse-syson/syson/issues/1747[#1747] [diagrams] Most new elements created by invoking a tool on a diagram are now automatically selected
 
 == v2025.12.0
 

backend/views/syson-diagram-common-view/src/main/java/org/eclipse/syson/diagram/common/view/tools/AbstractCompartmentNodeToolProvider.java

@@ -12,8 +12,6 @@
  *******************************************************************************/
 package org.eclipse.syson.diagram.common.view.tools;
 
-import java.util.List;
-
 import org.eclipse.sirius.components.collaborative.diagrams.DiagramContext;
 import org.eclipse.sirius.components.core.api.IEditingContext;
 import org.eclipse.sirius.components.diagrams.Node;
@@ -25,9 +23,9 @@
 import org.eclipse.sirius.components.view.diagram.NodeTool;
 import org.eclipse.sirius.components.view.diagram.SelectionDialogDescription;
 import org.eclipse.sirius.components.view.emf.diagram.ViewDiagramDescriptionConverter;
+import org.eclipse.syson.diagram.common.view.services.ViewNodeService;
 import org.eclipse.syson.diagram.services.aql.DiagramMutationAQLService;
 import org.eclipse.syson.util.AQLConstants;
-import org.eclipse.syson.util.AQLUtils;
 import org.eclipse.syson.util.ServiceMethod;
 
 /**
@@ -37,6 +35,8 @@
  */
 public abstract class AbstractCompartmentNodeToolProvider implements INodeToolProvider {
 
+    private static final String NEW_INSTANCE = "newInstance";
+
     protected final DiagramBuilders diagramBuilderHelper = new DiagramBuilders();
 
     protected final ViewBuilders viewBuilderHelper = new ViewBuilders();
@@ -77,8 +77,8 @@ public NodeTool create(IViewDiagramElementFinder cache) {
         ChangeContextBuilder revealOperation;
         if (this.revealOnCreate()) {
             revealOperation = this.viewBuilderHelper.newChangeContext()
-                    .expression(AQLUtils.getServiceCallExpression(Node.SELECTED_NODE, "revealCompartment",
-                            List.of("self", DiagramContext.DIAGRAM_CONTEXT, IEditingContext.EDITING_CONTEXT, ViewDiagramDescriptionConverter.CONVERTED_NODES_VARIABLE)));
+                    .expression(ServiceMethod.of4(ViewNodeService::revealCompartment).aql(Node.SELECTED_NODE, AQLConstants.SELF, DiagramContext.DIAGRAM_CONTEXT, IEditingContext.EDITING_CONTEXT,
+                            ViewDiagramDescriptionConverter.CONVERTED_NODES_VARIABLE));
         } else {
             revealOperation = this.viewBuilderHelper.newChangeContext().expression(AQLConstants.AQL_SELF);
         }
@@ -87,19 +87,25 @@ public NodeTool create(IViewDiagramElementFinder cache) {
                 .expression(ServiceMethod.of4(DiagramMutationAQLService::expose).aqlSelf(IEditingContext.EDITING_CONTEXT, DiagramContext.DIAGRAM_CONTEXT, Node.SELECTED_NODE,
                         ViewDiagramDescriptionConverter.CONVERTED_NODES_VARIABLE));
 
-        var creationCompartmentItemServiceCall = this.viewBuilderHelper.newChangeContext()
-                .expression(this.getServiceCallExpression())
+        var exposeAndRevealNewInstance = this.viewBuilderHelper.newChangeContext()
+                .expression(AQLConstants.AQL + NEW_INSTANCE)
                 .children(addToExposedElements.build(), revealOperation.build());
 
+        var letNewInstance = this.viewBuilderHelper.newLet()
+                .variableName(NEW_INSTANCE)
+                .valueExpression(this.getServiceCallExpression())
+                .children(exposeAndRevealNewInstance.build());
+
         var rootChangContext = this.viewBuilderHelper.newChangeContext()
                 .expression(AQLConstants.AQL_SELF)
-                .children(creationCompartmentItemServiceCall.build())
+                .children(letNewInstance.build())
                 .build();
 
         return builder.name(this.getNodeToolName())
                 .iconURLsExpression(this.getNodeToolIconURLsExpression())
                 .body(rootChangContext)
                 .preconditionExpression(this.getPreconditionExpression())
+                .elementsToSelectExpression(AQLConstants.AQL + NEW_INSTANCE)
                 .build();
     }
 

backend/views/syson-diagram-common-view/src/main/java/org/eclipse/syson/diagram/common/view/tools/ActionFlowCompartmentNodeToolProvider.java

@@ -12,8 +12,6 @@
  *******************************************************************************/
 package org.eclipse.syson.diagram.common.view.tools;
 
-import java.util.List;
-
 import org.eclipse.sirius.components.collaborative.diagrams.DiagramContext;
 import org.eclipse.sirius.components.core.api.IEditingContext;
 import org.eclipse.sirius.components.diagrams.Node;
@@ -23,8 +21,10 @@
 import org.eclipse.sirius.components.view.builder.providers.INodeToolProvider;
 import org.eclipse.sirius.components.view.diagram.NodeTool;
 import org.eclipse.sirius.components.view.emf.diagram.ViewDiagramDescriptionConverter;
+import org.eclipse.syson.diagram.common.view.services.ViewCreateService;
+import org.eclipse.syson.diagram.common.view.services.ViewNodeService;
 import org.eclipse.syson.diagram.services.aql.DiagramMutationAQLService;
-import org.eclipse.syson.util.AQLUtils;
+import org.eclipse.syson.util.AQLConstants;
 import org.eclipse.syson.util.ServiceMethod;
 
 /**
@@ -34,6 +34,8 @@
  */
 public class ActionFlowCompartmentNodeToolProvider implements INodeToolProvider {
 
+    private static final String NEW_INSTANCE = "newInstance";
+
     private final DiagramBuilders diagramBuilderHelper = new DiagramBuilders();
 
     private final ViewBuilders viewBuilderHelper = new ViewBuilders();
@@ -47,18 +49,19 @@ public NodeTool create(IViewDiagramElementFinder cache) {
                         ViewDiagramDescriptionConverter.CONVERTED_NODES_VARIABLE));
 
         var revealOperation = this.viewBuilderHelper.newChangeContext()
-                .expression(
-                        AQLUtils.getServiceCallExpression(Node.SELECTED_NODE, "revealCompartment",
-                                List.of("self", DiagramContext.DIAGRAM_CONTEXT, IEditingContext.EDITING_CONTEXT, ViewDiagramDescriptionConverter.CONVERTED_NODES_VARIABLE)));
+                .expression(ServiceMethod.of4(ViewNodeService::revealCompartment).aql(Node.SELECTED_NODE, AQLConstants.SELF, DiagramContext.DIAGRAM_CONTEXT, IEditingContext.EDITING_CONTEXT,
+                        ViewDiagramDescriptionConverter.CONVERTED_NODES_VARIABLE));
 
-        var creationServiceCall = this.viewBuilderHelper.newChangeContext()
-                .expression(AQLUtils.getSelfServiceCallExpression("createSubActionUsage"))
+        var letNewInstance = this.viewBuilderHelper.newLet()
+                .variableName(NEW_INSTANCE)
+                .valueExpression(ServiceMethod.of0(ViewCreateService::createSubActionUsage).aqlSelf())
                 .children(addToExposedElements.build(), revealOperation.build())
                 .build();
 
         return builder.name("New Action")
                 .iconURLsExpression("/icons/full/obj16/ActionUsage.svg")
-                .body(creationServiceCall)
+                .body(letNewInstance)
+                .elementsToSelectExpression(AQLConstants.AQL + NEW_INSTANCE)
                 .build();
     }
 }

doc/content/modules/user-manual/pages/release-notes/2026.1.0.adoc

@@ -62,6 +62,8 @@ This applies to: `FeatureTyping`, `Subsetting`, `Redefinition` and `Subclassific
 image::release-notes-redundant-feature-typing-message.png[Message displayed when attempting to create a redundant feature typing]
 
 - In diagrams, it is now possible to create a `SatisfyRequirement` from a `PartDefinition` or `PartUsage` graphical node.
+- In diagrams, many new tools now automatically select the `Elements` they create or expose on a diagram.
+This makes it easy to start editing newly created elements to give them proper names by starting to type directly when the new element appears.
 
 == Technical details