From 4a8f557325eab94d8296af79bfc7ec0fda21fd45 Mon Sep 17 00:00:00 2001 From: Hannes Wellmann Date: Mon, 10 Nov 2025 19:51:17 +0100 Subject: [PATCH] Remove 'Last revised' line from acknowledgements It complicates the generation of acknowledgements and can lead to changes in the git history where only that value is updated and that are therefore mainly noise without real benefit. Because the acknowledgements are now generated and updated regularly and automatically as part of the release process, the value of that field is in general questionable. To keep the workflow simpler respectively to not complicate it more in order to avoid updates of only this field, it's just removed. --- .github/workflows/generateAcknowledgements.yml | 7 ------- news/4.38/acknowledgements.md | 2 -- news/4.x-template/acknowledgements.md | 2 -- news/4.x-template/index.html | 2 +- news/4.x-template/jdt.html | 2 +- news/4.x-template/pde.html | 2 +- news/4.x-template/platform.html | 2 +- news/4.x-template/platform.md | 2 +- news/4.x-template/platform_isv.html | 2 +- 9 files changed, 6 insertions(+), 17 deletions(-) diff --git a/.github/workflows/generateAcknowledgements.yml b/.github/workflows/generateAcknowledgements.yml index aa2b736a..7d8d3662 100644 --- a/.github/workflows/generateAcknowledgements.yml +++ b/.github/workflows/generateAcknowledgements.yml @@ -208,13 +208,6 @@ jobs: } lines.splice(startMarker + 1, endMarker - (startMarker + 1), ...contributorLines) } - // Update last-revised date - const lastRevisedLineIndex = lines.findIndex(l => l.startsWith('Last revised: ')) - lines[lastRevisedLineIndex] = 'Last revised: ' + new Date().toLocaleDateString("en-US", { - year: "numeric", - month: "long", - day: "numeric", - }) fs.writeFileSync(acknowledgementsFile, lines.join('\n'), {encoding: 'utf8'}) // Set adjustments as outputs in order to append them to the PR message diff --git a/news/4.38/acknowledgements.md b/news/4.38/acknowledgements.md index 5ca6d4a3..d2691510 100644 --- a/news/4.38/acknowledgements.md +++ b/news/4.38/acknowledgements.md @@ -1,7 +1,5 @@ ## Eclipse 2025-12 Acknowledgements -Last revised: October 4, 2025 - We would also like to thank the users and adopters who support our efforts through a range of activities, including early testing, being a Friend of Eclipse, contracting special work, or outright employment. A special thanks goes to [Holger Voormann](https://github.com/howlger) for his Eclipse IDE promotion videos. diff --git a/news/4.x-template/acknowledgements.md b/news/4.x-template/acknowledgements.md index da3aa206..bed85dc3 100644 --- a/news/4.x-template/acknowledgements.md +++ b/news/4.x-template/acknowledgements.md @@ -1,7 +1,5 @@ ## Eclipse YYYY-MM Acknowledgements -Last revised: - We would also like to thank the users and adopters who support our efforts through a range of activities, including early testing, being a Friend of Eclipse, contracting special work, or outright employment. A special thanks goes to [Holger Voormann](https://github.com/howlger) for his Eclipse IDE promotion videos. diff --git a/news/4.x-template/index.html b/news/4.x-template/index.html index 13ff4fdc..d282b753 100644 --- a/news/4.x-template/index.html +++ b/news/4.x-template/index.html @@ -7,4 +7,4 @@ - \ No newline at end of file + diff --git a/news/4.x-template/jdt.html b/news/4.x-template/jdt.html index 13ff4fdc..d282b753 100644 --- a/news/4.x-template/jdt.html +++ b/news/4.x-template/jdt.html @@ -7,4 +7,4 @@ - \ No newline at end of file + diff --git a/news/4.x-template/pde.html b/news/4.x-template/pde.html index 13ff4fdc..d282b753 100644 --- a/news/4.x-template/pde.html +++ b/news/4.x-template/pde.html @@ -7,4 +7,4 @@ - \ No newline at end of file + diff --git a/news/4.x-template/platform.html b/news/4.x-template/platform.html index 13ff4fdc..d282b753 100644 --- a/news/4.x-template/platform.html +++ b/news/4.x-template/platform.html @@ -7,4 +7,4 @@ - \ No newline at end of file + diff --git a/news/4.x-template/platform.md b/news/4.x-template/platform.md index 2ad92efe..be6ae523 100644 --- a/news/4.x-template/platform.md +++ b/news/4.x-template/platform.md @@ -30,4 +30,4 @@ A special thanks to everyone who [contributed to Eclipse-Platform](acknowledgeme \ No newline at end of file +--> diff --git a/news/4.x-template/platform_isv.html b/news/4.x-template/platform_isv.html index 13ff4fdc..d282b753 100644 --- a/news/4.x-template/platform_isv.html +++ b/news/4.x-template/platform_isv.html @@ -7,4 +7,4 @@ - \ No newline at end of file +