From 7d16b286569b62e5e9f458d22b64daad0f09d9a1 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Fri, 12 Dec 2025 11:02:36 +0100 Subject: [PATCH] Remove redundant isCanceled checks in SaveablesList and SaveableHelper This addresses the proposal by ptziegler in PR #3542 to split the removal of isCanceled checks. --- .../eclipseui/org/eclipse/ui/internal/SaveableHelper.java | 3 --- .../eclipseui/org/eclipse/ui/internal/SaveablesList.java | 3 --- 2 files changed, 6 deletions(-) diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveableHelper.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveableHelper.java index 582e336be34..4c64b8666da 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveableHelper.java +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveableHelper.java @@ -193,9 +193,6 @@ private static boolean saveModels(ISaveablesSource modelSource, final IWorkbench continue; } doSaveModel(model, subMonitor.split(1), window, confirm); - if (subMonitor.isCanceled()) { - break; - } } } finally { monitorWrap.done(); diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveablesList.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveablesList.java index 7b58f101b41..0e5a82c6795 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveablesList.java +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveablesList.java @@ -796,9 +796,6 @@ public boolean saveModels(final List finalModels, final IShellProvider continue; } SaveableHelper.doSaveModel(model, subMonitor.split(1), shellProvider, blockUntilSaved); - if (subMonitor.isCanceled()) { - break; - } } monitorWrap.done(); };