From 5e645fd02cba8563742072807ce2baa5aed97358 Mon Sep 17 00:00:00 2001 From: Pelayo Felgueroso Date: Thu, 16 Oct 2025 16:23:26 +0200 Subject: [PATCH 1/4] Fix tooltip when components are disabled so it doesn't appear --- packages/lib/src/avatar/Avatar.tsx | 2 +- packages/lib/src/button/Button.tsx | 6 +++--- packages/lib/src/dropdown/Dropdown.tsx | 6 +++--- packages/lib/src/select/Select.tsx | 15 +++++++++------ packages/lib/src/tabs/Tab.tsx | 6 +++--- packages/lib/src/toggle-group/ToggleGroup.tsx | 6 +++--- 6 files changed, 22 insertions(+), 19 deletions(-) diff --git a/packages/lib/src/avatar/Avatar.tsx b/packages/lib/src/avatar/Avatar.tsx index a4e1a13bc..1d46469b6 100644 --- a/packages/lib/src/avatar/Avatar.tsx +++ b/packages/lib/src/avatar/Avatar.tsx @@ -162,7 +162,7 @@ const DxcAvatar = memo( ); return ( - + ( - + - + ); export default DxcButton; diff --git a/packages/lib/src/dropdown/Dropdown.tsx b/packages/lib/src/dropdown/Dropdown.tsx index f2b10b12b..44635e91a 100644 --- a/packages/lib/src/dropdown/Dropdown.tsx +++ b/packages/lib/src/dropdown/Dropdown.tsx @@ -7,7 +7,7 @@ import DxcIcon from "../icon/Icon"; import useWidth from "../utils/useWidth"; import DropdownMenu from "./DropdownMenu"; import DropdownPropsType from "./types"; -import { Tooltip } from "../tooltip/Tooltip"; +import { TooltipWrapper } from "../tooltip/Tooltip"; const sizes = { small: "60px", @@ -260,7 +260,7 @@ const DxcDropdown = ({ size={size} > - + - + ( {multiple && Array.isArray(selectedOption) && selectedOption.length > 0 && ( {selectedOption.length} - + ( > - + )} - + ( {searchable && searchValue.length > 0 && ( - + - + )} diff --git a/packages/lib/src/tabs/Tab.tsx b/packages/lib/src/tabs/Tab.tsx index 2f97d9191..df36471c7 100644 --- a/packages/lib/src/tabs/Tab.tsx +++ b/packages/lib/src/tabs/Tab.tsx @@ -2,7 +2,7 @@ import { forwardRef, KeyboardEvent, MutableRefObject, Ref, useContext, useEffect import styled from "@emotion/styled"; import DxcBadge from "../badge/Badge"; import DxcIcon from "../icon/Icon"; -import { Tooltip } from "../tooltip/Tooltip"; +import { TooltipWrapper } from "../tooltip/Tooltip"; import TabsContext from "./TabsContext"; import { TabProps, TabsContextProps } from "./types"; @@ -128,7 +128,7 @@ const DxcTab = forwardRef( }, [active, tabId, setActiveTabId]); return ( - + - + ); } ); diff --git a/packages/lib/src/toggle-group/ToggleGroup.tsx b/packages/lib/src/toggle-group/ToggleGroup.tsx index db80c10de..79bb53d68 100644 --- a/packages/lib/src/toggle-group/ToggleGroup.tsx +++ b/packages/lib/src/toggle-group/ToggleGroup.tsx @@ -2,7 +2,7 @@ import { KeyboardEvent, useState } from "react"; import styled from "@emotion/styled"; import { spaces } from "../common/variables"; import DxcIcon from "../icon/Icon"; -import { Tooltip } from "../tooltip/Tooltip"; +import { TooltipWrapper } from "../tooltip/Tooltip"; import ToggleGroupPropsType from "./types"; import { getButtonStyles, getHeight } from "../button/utils"; @@ -106,7 +106,7 @@ export default function DxcToggleGroup({ {options.map((option, i) => { const selected = !option.disabled && isToggleButtonSelected(multiple, option.value, value ?? selectedValue); return ( - + {option.label}} - + ); })} From 41b3645182c470f9f2d07ddc4c849b68fbd5c5ac Mon Sep 17 00:00:00 2001 From: Pelayo Felgueroso Date: Thu, 16 Oct 2025 16:56:45 +0200 Subject: [PATCH 2/4] Fix condition --- packages/lib/src/avatar/Avatar.tsx | 2 +- packages/lib/src/button/Button.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/lib/src/avatar/Avatar.tsx b/packages/lib/src/avatar/Avatar.tsx index 1d46469b6..a4e1a13bc 100644 --- a/packages/lib/src/avatar/Avatar.tsx +++ b/packages/lib/src/avatar/Avatar.tsx @@ -162,7 +162,7 @@ const DxcAvatar = memo( ); return ( - + ( - + - + ); export default DxcButton; diff --git a/packages/lib/src/dropdown/Dropdown.tsx b/packages/lib/src/dropdown/Dropdown.tsx index ac9093489..f2b10b12b 100644 --- a/packages/lib/src/dropdown/Dropdown.tsx +++ b/packages/lib/src/dropdown/Dropdown.tsx @@ -7,7 +7,7 @@ import DxcIcon from "../icon/Icon"; import useWidth from "../utils/useWidth"; import DropdownMenu from "./DropdownMenu"; import DropdownPropsType from "./types"; -import { TooltipWrapper } from "../tooltip/Tooltip"; +import { Tooltip } from "../tooltip/Tooltip"; const sizes = { small: "60px", @@ -260,7 +260,7 @@ const DxcDropdown = ({ size={size} > - + - + + - + ); } ); diff --git a/packages/lib/src/toggle-group/ToggleGroup.tsx b/packages/lib/src/toggle-group/ToggleGroup.tsx index 170333e31..db80c10de 100644 --- a/packages/lib/src/toggle-group/ToggleGroup.tsx +++ b/packages/lib/src/toggle-group/ToggleGroup.tsx @@ -2,7 +2,7 @@ import { KeyboardEvent, useState } from "react"; import styled from "@emotion/styled"; import { spaces } from "../common/variables"; import DxcIcon from "../icon/Icon"; -import { TooltipWrapper } from "../tooltip/Tooltip"; +import { Tooltip } from "../tooltip/Tooltip"; import ToggleGroupPropsType from "./types"; import { getButtonStyles, getHeight } from "../button/utils"; @@ -106,7 +106,7 @@ export default function DxcToggleGroup({ {options.map((option, i) => { const selected = !option.disabled && isToggleButtonSelected(multiple, option.value, value ?? selectedValue); return ( - + {option.label}} - + ); })}